Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • VTK-m VTK-m
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 193
    • Issues 193
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 38
    • Merge requests 38
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • VTK
  • VTK-mVTK-m
  • Merge requests
  • !2546

Improve type reporting in `UnknownArrayHandle`

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Kenneth Moreland requested to merge kmorel/vtk-m:better-unknown-type-reporting into master Aug 04, 2021
  • Overview 17
  • Commits 2
  • Pipelines 8
  • Changes 9

Added features with reporting types with UnknownArrayHandle. First, added a method named GetArrayTypeName that returns a string containing the type of the contained array. There were already methods GetValueType and GetStorageType, but this provides a convenience to get the whole name in one go.

Also improved the reporting when an AsArrayHandle call failed. Before, the thrown method just reported that the UnknownArrayHandle could not be converted to the given type. Now, it also reports the type actually held by the UnknownArrayHandle so the user can better understand why the conversion failed.

Also fixed an issue where the GetValueType and GetStorageType were not actually returning the correct type.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: better-unknown-type-reporting