VTK-m merge requestshttps://gitlab.kitware.com/vtk/vtk-m/-/merge_requests2023-07-07T13:27:58-04:00https://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/3068cmake: only set lfs.url when using ssh URL2023-07-07T13:27:58-04:00Vicente Boleavicente.bolea@kitware.comcmake: only set lfs.url when using ssh URLcc: @jeffamstutzcc: @jeffamstutzVicente Boleavicente.bolea@kitware.comVicente Boleavicente.bolea@kitware.comhttps://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/3067Split up the particle advection/streamline test2023-07-07T13:27:58-04:00Kenneth MorelandSplit up the particle advection/streamline testThe test for particle advection filters was one large test that tested 3
versions --- advection, streamlines, and pathlines --- with each tested
for a variety of conditions including asynchronous communication, number
of blocks, ghost ce...The test for particle advection filters was one large test that tested 3
versions --- advection, streamlines, and pathlines --- with each tested
for a variety of conditions including asynchronous communication, number
of blocks, ghost cells, etc. This was causing the test to take a while
and sometimes time out. (It would also sometimes seg fault, which I hope
is related.) To attempt to fix this problem, break up this test into
pieces so that each piece takes a shorter amount of time.
Because these tests share most of their implementation (which is why
they were grouped together in the first place) the common code is placed
in a source file of shared implementation. To support this I also added a
way to mark a source file to `vtkm_unit_tests` as a source file that does
not contain its own test. Normally you would just compile all of the
tests together, select each with command line arguments, and use
duplicate `add_tests` for each argument. But that is not how
`vtkm_unit_tests` works, and it would be too hard to make that change.https://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/3066Draft: Marching cube uncertainty2023-05-25T07:56:04-04:00Nrushad JoshiDraft: Marching cube uncertaintyCompute and Visualize the Uncertainty in Iso-surface extracted with marching cube algorithms.Compute and Visualize the Uncertainty in Iso-surface extracted with marching cube algorithms.https://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/3065Allow ComputeMoments to operate on any scalar field2023-07-07T13:27:52-04:00Kenneth MorelandAllow ComputeMoments to operate on any scalar fieldPreviously, the `ComputeMoments` filter only operated on a finite set of
array types as its input field. This included a prescribed list of `Vec`
sizes for the input. The filter has been updated to use more generic
interfaces to the fiel...Previously, the `ComputeMoments` filter only operated on a finite set of
array types as its input field. This included a prescribed list of `Vec`
sizes for the input. The filter has been updated to use more generic
interfaces to the field's array (and float fallback) to enable the
computation of moments on any type of scalar field.
Fixes #763https://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/3064Add support for CastAndCallVariableVecField in FilterField2023-07-07T13:27:52-04:00Kenneth MorelandAdd support for CastAndCallVariableVecField in FilterFieldThe `FilterField` class provides convenience functions for subclasses to
determine the `ArrayHandle` type for scalar and vector fields. However, you
needed to know the specific size of vectors. For filters that support an
input field of ...The `FilterField` class provides convenience functions for subclasses to
determine the `ArrayHandle` type for scalar and vector fields. However, you
needed to know the specific size of vectors. For filters that support an
input field of any type, a new form, `CastAndCallVariableVecField` has been
added. This calls the underlying functor with an `ArrayHandleRecombineVec`
of the appropriate component type.
The `CastAndaCallVariableVecField` method also reduces the number of
instances created by having a float fallback for any component type that
does not satisfy the field types.https://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/3063Allow CompositeVectors filter to build any size vector2023-07-07T13:27:51-04:00Kenneth MorelandAllow CompositeVectors filter to build any size vectorUsing the new `ArrayHandleRuntimeVec` feature, we can construct an array
with any vec sized value.
Fixes #762Using the new `ArrayHandleRuntimeVec` feature, we can construct an array
with any vec sized value.
Fixes #762https://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/3062Move ArrayHandleRuntimeVec metadata to a separate class2023-07-07T13:27:51-04:00Kenneth MorelandMove ArrayHandleRuntimeVec metadata to a separate classOriginally, the metadata structure used by the `ArrayHandleRuntimeVec`
storage was a nested class of its `Storage`. But the `Storage` is
templated on the component type, and the metadata object is the same
regardless. In addition to the ...Originally, the metadata structure used by the `ArrayHandleRuntimeVec`
storage was a nested class of its `Storage`. But the `Storage` is
templated on the component type, and the metadata object is the same
regardless. In addition to the typical minor issue of having the
compiler create several identical classes, this caused problems when
pulling arrays from equivalent but technically different C types (for
example, `long` is the same as either `int` or `long long`).https://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/3061Handle any Vec size in VTKDataSetReader2023-07-07T13:27:51-04:00Kenneth MorelandHandle any Vec size in VTKDataSetReaderThe legacy VTK file reader previously only supported a specific set of Vec
lengths (i.e., 1, 2, 3, 4, 6, and 9). This is because a basic array
handle has to have the vec length compiled in. However, the new
`ArrayHandleRuntimeVec` featur...The legacy VTK file reader previously only supported a specific set of Vec
lengths (i.e., 1, 2, 3, 4, 6, and 9). This is because a basic array
handle has to have the vec length compiled in. However, the new
`ArrayHandleRuntimeVec` feature is capable of reading in any vec-length
and can be leveraged to read in arbitrarily sized vectors in field
arrays.
Fixes #761https://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/3060ci: setup CUDA arch before sccache2023-07-07T13:27:58-04:00Vicente Boleavicente.bolea@kitware.comci: setup CUDA arch before sccacheI accidentally disabled SCCACHE caching for CUDA source files compilation in !3051. This change should resolve it.I accidentally disabled SCCACHE caching for CUDA source files compilation in !3051. This change should resolve it.Vicente Boleavicente.bolea@kitware.comVicente Boleavicente.bolea@kitware.comhttps://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/3059Fix unused variable in contour test2023-07-07T13:27:51-04:00Kenneth MorelandFix unused variable in contour testhttps://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/3058Fix new instances of ArrayHandleRuntimeVec in UnknownArrayHandle2023-07-07T13:27:51-04:00Kenneth MorelandFix new instances of ArrayHandleRuntimeVec in UnknownArrayHandle`UnknownArrayHandle` is supposed to treat `ArrayHandleRuntimeVec` the
same as `ArrayHandleBasic`. However, the `NewInstance` methods were
failing because they need custom handling of the vec size.`UnknownArrayHandle` is supposed to treat `ArrayHandleRuntimeVec` the
same as `ArrayHandleBasic`. However, the `NewInstance` methods were
failing because they need custom handling of the vec size.https://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/3057Clean up ScalarRenderer2023-08-23T19:31:56-04:00Li-Ta LoClean up ScalarRendererFixed several C++ language usage issues with `ScalarRenderer`.Fixed several C++ language usage issues with `ScalarRenderer`.https://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/3056Implement Flying Edges for structured cellsets with rectilinear and curviline...2023-07-03T04:21:55-04:00Louis GombertImplement Flying Edges for structured cellsets with rectilinear and curvilinear coordinatesDepends on !3050 (will need rebase)
When Flying Edges was introduced to compute contours of a 3D structured cellset, it had [a limitation to uniform data](https://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/2005#note_718607). This MR ...Depends on !3050 (will need rebase)
When Flying Edges was introduced to compute contours of a 3D structured cellset, it had [a limitation to uniform data](https://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/2005#note_718607). This MR implements an alternative path through pass 4 (and 5 for some devices) to handle other type of coordinate systems. The `Contour` filter re-written in !3050 uses Flying Edges for these new supported cases accordingly.
Close #774https://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/3055ci,warnings: add configure warning exceptions2023-07-07T13:27:56-04:00Vicente Boleavicente.bolea@kitware.comci,warnings: add configure warning exceptionsVicente Boleavicente.bolea@kitware.comVicente Boleavicente.bolea@kitware.comhttps://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/3054Making WorldAnnonation non-Virtual2023-07-07T13:27:54-04:00Li-Ta LoMaking WorldAnnonation non-VirtualThere used to be a class hierarchy for `WorldAnnontation`. It is not the case any more. Thus its member functions don't need to declared virtual. Many instances of `const_cast` were also removed by changing data member to `mutable`.There used to be a class hierarchy for `WorldAnnontation`. It is not the case any more. Thus its member functions don't need to declared virtual. Many instances of `const_cast` were also removed by changing data member to `mutable`.Li-Ta LoLi-Ta Lohttps://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/3053clang-tidy: various fixes2023-12-04T10:42:56-05:00Ben Boeckelclang-tidy: various fixes---
All found inside of VTK. While VTK's dashboards don't care, it'd be nice to get things at least a little bit cleaner.---
All found inside of VTK. While VTK's dashboards don't care, it'd be nice to get things at least a little bit cleaner.https://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/3052Draft: Exposing Axis Annonation Rendering Bug (Do Not Merge)2023-05-03T09:03:21-04:00Li-Ta LoDraft: Exposing Axis Annonation Rendering Bug (Do Not Merge)In the process of !3048, it was discovered that the rendering of `AxisAnnonation` is sensitive on the `vtkm::FloatDefault`. Some tick marks would not be rendered if `FloatDefault` is `Float64`.
This MR is for demonstration purpose only....In the process of !3048, it was discovered that the rendering of `AxisAnnonation` is sensitive on the `vtkm::FloatDefault`. Some tick marks would not be rendered if `FloatDefault` is `Float64`.
This MR is for demonstration purpose only. Do not merge.Manish MathaiManish Mathaihttps://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/3051Add warning icon in the pipelines button in MRs2023-07-07T13:27:56-04:00Vicente Boleavicente.bolea@kitware.comAdd warning icon in the pipelines button in MRsThis MR makes the icon of a build in a pipeline to be in a third state (!) to symbolize that there were warnings during that build. This exit state does not cancel the build or mark it as failure it simply notifies the dev the there has ...This MR makes the icon of a build in a pipeline to be in a third state (!) to symbolize that there were warnings during that build. This exit state does not cancel the build or mark it as failure it simply notifies the dev the there has been warnings.
Examples are shown here:
![Screenshot_from_2023-05-01_15-34-13](/uploads/ac8413a3cb9a2afa583cfe8306df5d48/Screenshot_from_2023-05-01_15-34-13.png)
- Due to limitations of the Gitlab Powershell shell execute we cannot do this in our Windows build for the time being. This will be possible after we either update our CI machine to win10 or update its PS to PS7. In the meanwhile, windows warnings will fails the build.
Here is a pipeline displaying warnings: https://gitlab.kitware.com/vtk/vtk-m/-/pipelines/330878Vicente Boleavicente.bolea@kitware.comVicente Boleavicente.bolea@kitware.comhttps://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/3050Split flying edges and marching cells into separate filters2023-05-10T03:34:25-04:00Louis GombertSplit flying edges and marching cells into separate filtersThe `Contour` filter is now using either `ContourFlyingEdges` or `ContourMarchingCubes` filters depending on the type of CellSet provided. These new filters are usable independently and inherit from a common `AbstractContour` interface. ...The `Contour` filter is now using either `ContourFlyingEdges` or `ContourMarchingCubes` filters depending on the type of CellSet provided. These new filters are usable independently and inherit from a common `AbstractContour` interface. The `Contour` API is left unchanged.
Left do to :
- [x] Update unit tests for the new filters
- [x] Make `ContourFlyingEdges` and `ContourMarchingCubes` more robust (don't accept any input)
- [x] Possibly factorize `ContourFlyingEdges.cxx` and `ContourMarchingCubes.cxx` (lots of repetition)
- [x] Update documentation and changelog
- [x] Rebase into 1 commit
Close #773https://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/3049Crusher update rocm2023-07-07T13:27:56-04:00Vicente Boleavicente.bolea@kitware.comCrusher update rocmROCM 4.5 is old, lets update it to the current default ROCm 5.4.0.ROCM 4.5 is old, lets update it to the current default ROCm 5.4.0.Vicente Boleavicente.bolea@kitware.comVicente Boleavicente.bolea@kitware.com