VTK-m merge requestshttps://gitlab.kitware.com/vtk/vtk-m/-/merge_requests2020-12-09T11:19:32-05:00https://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/2224Do not test gcc48 builds.2020-12-09T11:19:32-05:00Nick ThompsonDo not test gcc48 builds.Warning: Flamewar commit)
It appears that support for gcc 4.8 has be effectively given up, since the tests have been unstable for many months now.
This MR does not remove full support for gcc48; it still verifies it compiles, but watch...Warning: Flamewar commit)
It appears that support for gcc 4.8 has be effectively given up, since the tests have been unstable for many months now.
This MR does not remove full support for gcc48; it still verifies it compiles, but watching these tests fail over and over is not informative.https://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/2221Do not run tests on gcc 4.8 build.2020-08-19T10:01:33-04:00Nick ThompsonDo not run tests on gcc 4.8 build.(Warning: Flamewar commit)
It appears that support for gcc 4.8 has be effectively given up, since the tests have been unstable for many months now.
This MR does not remove full support for gcc48; it still verifies it compiles, but watc...(Warning: Flamewar commit)
It appears that support for gcc 4.8 has be effectively given up, since the tests have been unstable for many months now.
This MR does not remove full support for gcc48; it still verifies it compiles, but watching these tests fail over and over is not informative.https://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/2217Ode performance2020-08-19T10:01:32-04:00Nick ThompsonOde performanceIncrease performance of particle advection via solving the issue discovered in 2215.
Note that if `GetCellInfo` can be called from a multithreaded context then this fix is incorrect.Increase performance of particle advection via solving the issue discovered in 2215.
Note that if `GetCellInfo` can be called from a multithreaded context then this fix is incorrect.https://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/2215WIP: Benchmark ode integrators2020-08-18T15:47:04-04:00Nick ThompsonWIP: Benchmark ode integratorsIn order to establish a baseline for improvement via Dormand-Prince, we need some benchmarks for our current particle advection workflows.
Forked off of [2213](https://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/2213).In order to establish a baseline for improvement via Dormand-Prince, we need some benchmarks for our current particle advection workflows.
Forked off of [2213](https://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/2213).https://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/2209Draft: Experiment of using kokkos+cuda on ubuntu2020-08-13T16:04:16-04:00Robert MaynardDraft: Experiment of using kokkos+cuda on ubuntuhttps://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/2203WIP: fomatting: updates vtkm formatting to match clang-format 92020-08-19T13:11:54-04:00Vicente Boleavicente.bolea@kitware.comWIP: fomatting: updates vtkm formatting to match clang-format 9related: !1948
This MR implements the changes intended to be added in the MR !1948related: !1948
This MR implements the changes intended to be added in the MR !1948https://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/2191Fix race condition in UnitTestGraphConnectivity2020-08-27T16:54:16-04:00Kenneth MorelandFix race condition in UnitTestGraphConnectivityThe UnitTestGraphConnectivity would sometimes fail on parallel devices
(even though the tested graph is remarkably small). The issue was likely
a race condition in the pointer jumping worklets where the worklet would
check graph edges in...The UnitTestGraphConnectivity would sometimes fail on parallel devices
(even though the tested graph is remarkably small). The issue was likely
a race condition in the pointer jumping worklets where the worklet would
check graph edges in an array and then update the connections in the
same array.
These race conditions are removed by reading input connections from one
array and writing the results to a separate array. The algorithm now
seems more stable although it now requires more memory.https://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/2190Worket invoker dispatcher2020-07-21T19:29:35-04:00Li-Ta LoWorket invoker dispatcherReverse the dependency between Invoker.h and *Worklet.h. This prevents a recompilation of a large number of file when any one of the Worklet.h is modified.Reverse the dependency between Invoker.h and *Worklet.h. This prevents a recompilation of a large number of file when any one of the Worklet.h is modified.Kenneth MorelandKenneth Morelandhttps://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/2189WIP: dummy MR to see what's going on2020-07-22T14:29:07-04:00Dave PugmireWIP: dummy MR to see what's going ontesttesthttps://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/2187Assertions for proper usage of VecVariable2020-07-22T14:28:57-04:00Dave PugmireAssertions for proper usage of VecVariableI ran into some subtle errors in the use of vtkm::VecVariable while working on !2019.
This MR adds some assertions to the operator[] to alert when improper usage occurs.I ran into some subtle errors in the use of vtkm::VecVariable while working on !2019.
This MR adds some assertions to the operator[] to alert when improper usage occurs.https://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/2179streamline filter with MPI2020-08-24T14:26:46-04:00Dave Pugmirestreamline filter with MPIMoving code over from VTK-h.
This was done in: !2210Moving code over from VTK-h.
This was done in: !2210https://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/2178WIP: distributed memory particle advection2020-07-14T16:48:15-04:00Dave PugmireWIP: distributed memory particle advectionMoving code over from VTK-h.Moving code over from VTK-h.https://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/2155Attempt to debug tempermental VTK read bug2020-08-19T13:13:09-04:00Dave PugmireAttempt to debug tempermental VTK read bughttps://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/2147Float distance.2020-06-24T10:55:25-04:00Nick ThompsonFloat distance.This MR is a small piece of the effort to get more metadata out of unit test failures.This MR is a small piece of the effort to get more metadata out of unit test failures.Nick ThompsonNick Thompsonhttps://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/2144WIP: Use ArrayHandleMultiplexer in VariantArrayHandle::CastAndCall2020-08-19T13:14:00-04:00Kenneth MorelandWIP: Use ArrayHandleMultiplexer in VariantArrayHandle::CastAndCallThe previous behavior of `VariantArrayHandle::CastAndCall` was to
identify all possible `ArrayHandle`s to try and call the provided
functor with each one. This change creates an `ArrayHandleMultiplexer`
for each value type so that the fu...The previous behavior of `VariantArrayHandle::CastAndCall` was to
identify all possible `ArrayHandle`s to try and call the provided
functor with each one. This change creates an `ArrayHandleMultiplexer`
for each value type so that the functor need only be called once for
each value type rather than once for every value-storage type pair.
This results in more complex array types, but should result in fewer
total code paths.https://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/2143WIP: Figure out build timeouts for ArrayHandleMultiplexer fixes2020-06-17T10:21:26-04:00Kenneth MorelandWIP: Figure out build timeouts for ArrayHandleMultiplexer fixesThe `ubuntu1804_gcc7` for !2133 keeps timing out. The code changes are not that much, but something seems to be running slowly. Use this fake MR to try to track down what the issue is.The `ubuntu1804_gcc7` for !2133 keeps timing out. The code changes are not that much, but something seems to be running slowly. Use this fake MR to try to track down what the issue is.https://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/2141WIP: Check ubuntu1804_gcc7 build timeouts2020-06-15T20:34:01-04:00Kenneth MorelandWIP: Check ubuntu1804_gcc7 build timeoutsI've been having an issue with the `ubuntu1804_gcc7` build timing out on
a change that touches a lot of code. I'm adding a small comment deep in
the code to cause a recompile that should not take longer than what is
already on master. If...I've been having an issue with the `ubuntu1804_gcc7` build timing out on
a change that touches a lot of code. I'm adding a small comment deep in
the code to cause a recompile that should not take longer than what is
already on master. If this cannot succeed without timing out, then there
must be an issue with the existing code on master not compiling within
the timeout time.https://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/2131Normal of zero vectors2020-08-19T13:13:50-04:00Kenneth MorelandNormal of zero vectorsThe normal of a vector is the vector divided by the vector's magnitude.
However, if the vector is the 0 vector, you get 0/0, which results in
non-finite numbers.
There might be legitimate situations where you (unintentionally) try to
no...The normal of a vector is the vector divided by the vector's magnitude.
However, if the vector is the 0 vector, you get 0/0, which results in
non-finite numbers.
There might be legitimate situations where you (unintentionally) try to
normalize a 0 vector. For example, you might be using the derivative of
a field to compute the normal to a contour of the field. If the field is
in a static region or critical point, then the gradient goes to 0.
In these cases, we want the `Normal` and `Normalize` functions to return
something reasonable. These functions now return the 0 vector back. This
is no more "correct" than producing NaN values, but it is less likely to
cause problems later.https://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/2126Failing unit test for vtkm::filter::Contour.2020-06-10T10:05:18-04:00Nick ThompsonFailing unit test for vtkm::filter::Contour.@robertmaynard's work in #2125 makes the example code much more useful. However, the previous manifestation of `example/demo/Demo.cxx` was in fact a very good unit test, as it was very understandable. (The isosurface is simply a plane ag...@robertmaynard's work in #2125 makes the example code much more useful. However, the previous manifestation of `example/demo/Demo.cxx` was in fact a very good unit test, as it was very understandable. (The isosurface is simply a plane against a linear gradient.)https://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/2115ci: Add OLCF GitLab-CI2020-12-15T12:03:30-05:00Chuck Atkinsci: Add OLCF GitLab-CIThis adds gitlab-ci using the batch runners on the OLCF ascent system. I've tried to tie it in to your existing infrastructure with ctest scripts. A few caveats to note in this:
* Currently only a GCC + Cuda + Spectrum MPI build
* E...This adds gitlab-ci using the batch runners on the OLCF ascent system. I've tried to tie it in to your existing infrastructure with ctest scripts. A few caveats to note in this:
* Currently only a GCC + Cuda + Spectrum MPI build
* Easy enough to add other configurations, i.e. XL + Cuda + Spectrum MPI
* At OLCF the compute nodes don't have access to the work directory used by the GitLab runners. To account for this the jobs create their own work space on the shared files system based on pipeline ID and build name and then clone into that from the local checkout provided by the GitLab runner.
* No `git-lfs` support in the build as of yet. It's being loaded as an environment module in the build stage but the necessary pieces need to be manually added to get the LFS objects fetched and into the new workspace.
* Since the build jobs run on a shared login node the auto-detection of build parallelism has been augmented to allow a manual override instead of always using the number of CPU cores.
* In order to explicitly configure the MPI environment to use `jsrun` and not rely on auto-detection I've added a mechanism, to have a per-build-name pre-defined cache file.
The builds are hosted on https://code.olcf.gov/ecpcitest/vtk-m