VTK-m merge requestshttps://gitlab.kitware.com/vtk/vtk-m/-/merge_requests2022-01-24T09:35:36-05:00https://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/2668Migrate Entity Extraction Filters, Part II2022-01-24T09:35:36-05:00Li-Ta LoMigrate Entity Extraction Filters, Part IIThis is a follow-up of !2665 and depends/includes that MR. Addresses https://gitlab.kitware.com/vtk/vtk-m/-/issues/601 and https://gitlab.kitware.com/kmorel/ecp-vtk-m-project-management/-/issues/328.This is a follow-up of !2665 and depends/includes that MR. Addresses https://gitlab.kitware.com/vtk/vtk-m/-/issues/601 and https://gitlab.kitware.com/kmorel/ecp-vtk-m-project-management/-/issues/328.https://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/2669Migrate Contour Filters2022-04-08T11:58:34-04:00Li-Ta LoMigrate Contour FiltersMigrate Contour and related filters. Depends on and partially includes !2665. Addresses https://gitlab.kitware.com/vtk/vtk-m/-/issues/601 and https://gitlab.kitware.com/kmorel/ecp-vtk-m-project-management/-/issues/328.Migrate Contour and related filters. Depends on and partially includes !2665. Addresses https://gitlab.kitware.com/vtk/vtk-m/-/issues/601 and https://gitlab.kitware.com/kmorel/ecp-vtk-m-project-management/-/issues/328.https://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/2670Adding changes for cell centered velocities2022-01-28T12:59:34-05:00Abhishek Yenpureabhi.yenpure@kitware.comAdding changes for cell centered velocitieshttps://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/2671CI: set GBench to latest tag2022-04-06T17:37:01-04:00Vicente Boleavicente.bolea@kitware.comCI: set GBench to latest tagPreviously it was set to an specific commit known to work with VTK-m.Previously it was set to an specific commit known to work with VTK-m.v1.7.1Vicente Boleavicente.bolea@kitware.comVicente Boleavicente.bolea@kitware.comhttps://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/2672Draft: CDASH: organize nightly builds tracks2022-09-21T16:05:26-04:00Vicente Boleavicente.bolea@kitware.comDraft: CDASH: organize nightly builds tracksI propose the following schema in our dashboard
```
master
nightly-master (Every day)
release
nightly-release (Every week)
merge-requests
buildbot-vtkm (To be phased out)
```I propose the following schema in our dashboard
```
master
nightly-master (Every day)
release
nightly-release (Every week)
merge-requests
buildbot-vtkm (To be phased out)
```Vicente Boleavicente.bolea@kitware.comVicente Boleavicente.bolea@kitware.comhttps://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/2673Draft: CI: update tags conforming current runners2022-02-02T16:49:03-05:00Vicente Boleavicente.bolea@kitware.comDraft: CI: update tags conforming current runnersJool is the only machine with Pascal GPU that we have in our CI. Unfortunately we are having issues with this machine. In this MR I make the builds that uses to build for Pascal GPUs such as Jool to target turing GPUs.Jool is the only machine with Pascal GPU that we have in our CI. Unfortunately we are having issues with this machine. In this MR I make the builds that uses to build for Pascal GPUs such as Jool to target turing GPUs.Vicente Boleavicente.bolea@kitware.comVicente Boleavicente.bolea@kitware.comhttps://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/2674Changing MIR filter to use FloatDefault for Volume Fractions2022-04-08T11:37:30-04:00Abhishek Yenpureabhi.yenpure@kitware.comChanging MIR filter to use FloatDefault for Volume FractionsThe MIR filter/worklet internally used Float32 to store volume fraction
information. This change allows it to use FloatDefault. Users using
datasets with Float64 will be able to use the filter better.The MIR filter/worklet internally used Float32 to store volume fraction
information. This change allows it to use FloatDefault. Users using
datasets with Float64 will be able to use the filter better.Abhishek Yenpureabhi.yenpure@kitware.comAbhishek Yenpureabhi.yenpure@kitware.comhttps://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/2675Migrate Connected Components filters2022-04-08T11:58:34-04:00Li-Ta LoMigrate Connected Components filtersMigrate ImageConnectivity and CellSetConnectivity filters. Addresses https://gitlab.kitware.com/vtk/vtk-m/-/issues/601 and https://gitlab.kitware.com/kmorel/ecp-vtk-m-project-management/-/issues/328.Migrate ImageConnectivity and CellSetConnectivity filters. Addresses https://gitlab.kitware.com/vtk/vtk-m/-/issues/601 and https://gitlab.kitware.com/kmorel/ecp-vtk-m-project-management/-/issues/328.https://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/2676Prevent error being raised for coincident points in Tube filter2022-04-11T14:35:16-04:00Manish MathaiPrevent error being raised for coincident points in Tube filterCoincident points in polylines will be skipped when generating the
tubes, instead of raising an error.Coincident points in polylines will be skipped when generating the
tubes, instead of raising an error.https://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/2677Migrate Density Estimate Filters2022-04-08T11:58:35-04:00Li-Ta LoMigrate Density Estimate FiltersMigrate density estimate filters. Addresses https://gitlab.kitware.com/vtk/vtk-m/-/issues/601 and https://gitlab.kitware.com/kmorel/ecp-vtk-m-project-management/-/issues/328.Migrate density estimate filters. Addresses https://gitlab.kitware.com/vtk/vtk-m/-/issues/601 and https://gitlab.kitware.com/kmorel/ecp-vtk-m-project-management/-/issues/328.https://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/2678Make ArrayCopy not depend on a device compiler2022-04-08T11:58:34-04:00Kenneth MorelandMake ArrayCopy not depend on a device compilerRather than require `ArrayCopy` to create special versions of copy for
all arrays, use a precompiled versions. This should speed up compiles,
reduce the amount of code being generated, and require the device
compiler on fewer source file...Rather than require `ArrayCopy` to create special versions of copy for
all arrays, use a precompiled versions. This should speed up compiles,
reduce the amount of code being generated, and require the device
compiler on fewer source files.
There are some cases where you still need to copy arrays that are not
well supported by the precompiled versions in `ArrayCopy`. (It will
always work, but the fallback is very slow.) In this case, you will want
to switch over to `ArrayCopyDevice`, which has the old behavior.https://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/2679HIP: remove bogus kokkoscore INTERFACE_COMPILE_DEFINITIONS property2022-10-10T21:18:20-04:00Vicente Boleavicente.bolea@kitware.comHIP: remove bogus kokkoscore INTERFACE_COMPILE_DEFINITIONS propertyWhen Kokkos uses HIP it initialize the properties of the target kokkoscore like this:
```
set_target_properties(Kokkos::kokkoscore PROPERTIES
INTERFACE_COM...When Kokkos uses HIP it initialize the properties of the target kokkoscore like this:
```
set_target_properties(Kokkos::kokkoscore PROPERTIES
INTERFACE_COMPILE_DEFINITIONS "\$<\$<COMPILE_LANGUAGE:CXX>:KOKKOS_DEPENDENCE>"
INTERFACE_COMPILE_FEATURES "cxx_std_14"
INTERFACE_COMPILE_OPTIONS "\$<\$<COMPILE_LANGUAGE:CXX>:-fno-gpu-rdc>;\$<\$<COMPILE_LANGUAGE:CXX>:-x;hip;--offload-arch=gfx900>"
```
These generator expressions create some issues when we try to generate files with a content that depends on it. We already zeroed INTERFACE_COMPILE_OPTIONS and INTERFACE_LINK_OPTIONS for similar reasons, the reason of that we did not the same for `INTERFACE_COMPILE_DEFINITIONS` is that we did not have an issue with this so far.
Unfortunately, for VTK when using kokkos_hip transitively through VTK-m it tries to generate files with the content of `INTERFACE_COMPILE_DEFINITIONS` which results in a configure error.
Eventually this has to make its way to the Kokkos project.v1.7.1Vicente Boleavicente.bolea@kitware.comVicente Boleavicente.bolea@kitware.comhttps://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/2680Migrate Entity Extraction Filters, Part II.b2022-04-08T11:58:34-04:00Kenneth MorelandMigrate Entity Extraction Filters, Part II.bThis is a follow-up of !2665 and depends/includes that MR.
Addresses https://gitlab.kitware.com/vtk/vtk-m/-/issues/601 and https://gitlab.kitware.com/kmorel/ecp-vtk-m-project-management/-/issues/328.
This MR is actually a painstaking r...This is a follow-up of !2665 and depends/includes that MR.
Addresses https://gitlab.kitware.com/vtk/vtk-m/-/issues/601 and https://gitlab.kitware.com/kmorel/ecp-vtk-m-project-management/-/issues/328.
This MR is actually a painstaking rebase of !2668, which got its history trashed.Li-Ta LoLi-Ta Lohttps://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/2681Add CastAndCallScalarField and CastAndCallVecField to NewFilterField2022-04-08T11:58:34-04:00Kenneth MorelandAdd CastAndCallScalarField and CastAndCallVecField to NewFilterFieldThese methods somewhat simplify doing the `CastAndCall` from an
`UnknownArrayhandle` that comes from an input field.
The motivation for this change is for the User's guide, where I am
having a chicken-and-egg problem of wanting to descr...These methods somewhat simplify doing the `CastAndCall` from an
`UnknownArrayhandle` that comes from an input field.
The motivation for this change is for the User's guide, where I am
having a chicken-and-egg problem of wanting to describe how to make a
simple filter implementation without having to go into details about
`UnknownArrayHandle`.
Also updated the `CrossProduct` filter to the new filter structure,
which provides a demonstration of `CastAndCallVecField`.https://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/2682Allow dot product to work with any field type2022-04-08T11:58:34-04:00Kenneth MorelandAllow dot product to work with any field typeThe previous implementation of the `DotProduct` filter only worked with
arrays containing "common" types. The filter has been updated to use the
extract component feature of `UnknownArrayHandle` to support computing
the dot product of ar...The previous implementation of the `DotProduct` filter only worked with
arrays containing "common" types. The filter has been updated to use the
extract component feature of `UnknownArrayHandle` to support computing
the dot product of arrays of almost any type.https://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/2683Add implementation of VecTraits for Range and Bounds2022-04-08T11:58:39-04:00Kenneth MorelandAdd implementation of VecTraits for Range and BoundsAdded specializations of `vtkm::VecTraits` for the simple structures of
`vtkm::Range` and `vtkm::Bounds`. This expands the support for using
these structures in things like `ArrayHandle` and `UnknownArrayHandle`.Added specializations of `vtkm::VecTraits` for the simple structures of
`vtkm::Range` and `vtkm::Bounds`. This expands the support for using
these structures in things like `ArrayHandle` and `UnknownArrayHandle`.https://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/2684Write global fields when saving to VTK files2022-02-03T13:48:33-05:00Gunther WeberWrite global fields when saving to VTK fileshttps://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/2685Fix out of bounds cell location searchs in VolumeRendererStructured2022-04-08T11:58:38-04:00Manish MathaiFix out of bounds cell location searchs in VolumeRendererStructured`RectilinearLocator::LocateCell` and `UniformLocator::LocateCell` assume
that the point is inside the bounds of the cell set but may return a
cell location that does not exist, i.e. cell location that is outside
of the bounds of the cell...`RectilinearLocator::LocateCell` and `UniformLocator::LocateCell` assume
that the point is inside the bounds of the cell set but may return a
cell location that does not exist, i.e. cell location that is outside
of the bounds of the cell set, due to errors from floating-point
operations.
This fix, given the assumption above, bounds the calculated cell
location to within the cell set by capping the indices to within the
limits. This fixes the cause of the crash in Ascent that is noted at
https://github.com/Alpine-DAV/ascent/issues/825
Backport: releasev1.7.1Vicente Boleavicente.bolea@kitware.comVicente Boleavicente.bolea@kitware.comhttps://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/2686Add `CreateResult` to `NewFilter` and absorb field mapping2022-04-08T11:58:34-04:00Kenneth MorelandAdd `CreateResult` to `NewFilter` and absorb field mappingThe original version of `Filter` classes had a helper header file named
`CreateResult.h` that had several forms of a `CreateResult` function that
helped correctly create the `DataSet` to be returned from a filter's
`DoExecute`. With the ...The original version of `Filter` classes had a helper header file named
`CreateResult.h` that had several forms of a `CreateResult` function that
helped correctly create the `DataSet` to be returned from a filter's
`DoExecute`. With the move to the `NewFilter` structure, these functions
did not line up very well with how `DataSet`s should actually be created.
A replacement for these functions have been added as protected helper
methods to `NewFilter` and `NewFilterField`. In addition to moving them
into the filter themselves, the behavior of `CreateResult` has been merged
with the map field to output functionality. The original implementation of
`Filter` did this mapping internally in a different step. The first design
of `NewFilter` required the filter implementer to call a
`MapFieldsOntoOutput` themselves. This new implementation wraps the
functionality of `CreateResult` and `MapFieldsOntoOutput` together so that
the `DataSet` will be created correctly with a single call to
`CreateResult`. This makes it easier to correctly create the output.https://gitlab.kitware.com/vtk/vtk-m/-/merge_requests/2687Draft: LCL: namespace its headers2024-02-28T12:49:02-05:00Vicente Boleavicente.bolea@kitware.comDraft: LCL: namespace its headersCloses: #646Closes: #646Vicente Boleavicente.bolea@kitware.comVicente Boleavicente.bolea@kitware.com