Skip to content
Snippets Groups Projects

Streamline integration in client project

1 unresolved thread

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
18 if (NOT CMAKE_ARCHIVE_OUTPUT_DIRECTORY)
19 set(CMAKE_ARCHIVE_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/${CMAKE_INSTALL_LIBDIR}")
20 endif ()
12 21
13 22 option(BUILD_SHARED_LIBS "Build shared library" ON)
14 23 set(VESPA_BUILD_PV_PLUGIN OFF CACHE BOOL "Build VESPA ParaView plugin")
15 24
16 include(CTest)
25 # Testing
26 set(VESPA_BUILD_TESTING "ON"
27 CACHE STRING "Build module testing directories")
28 set_property(CACHE VESPA_BUILD_TESTING
29 PROPERTY
30 STRINGS "ON;OFF;WANT")
31 if (VESPA_BUILD_TESTING)
32 set_property(CACHE BUILD_TESTING
  • +2 after small question

  • This require a bit more work to improve the generation of vth-config files suitable for both build and install tree.

    I will look into improving https://github.com/KitwareMedical/VTKExternalModule so that it can be re-used (either by vendorizing or copying) in this context.

  • All right, good for me then.

    I tried creating a remote module for VESPA initially, my first draft was using this mechanism. Unfortunately, after discussion, we do not want to add new remote modules for several reasons. They are hard to maintain / debug, they put code (cmake and cxx) into the VTK build which are not under our control, when there is an issue, it is not straightforward to know whom to contact for the fix ...

    Can I continue with the merge here ?

  • @jcfr friendly ping here :)

  • Please register or sign in to reply
    Loading