The change in commit 573713fa (SystemTools: CopyFileIfDifferent: Ensure
that source is a file, 2020-02-11) breaks existing behavior w.r.t.
symbolic links.  Revert it pending further investigation.

Update our report handler to pretend that the user pressed "Retry".
This will continue with what would have happened if there were no
debug hook, such as actually abort()ing the process.

Sean McBride authored Sep 15, 2019 and Brad King committed Sep 17, 2019

- Find/replace of KWSYS_NULLPTR with nullptr
- Find/replace of NULL with nullptr
- Manually fixed -Wzero-as-null-pointer-constant warnings
- Careful review to fix some comments, string output, etc.

Jon Chronopoulos authored Aug 26, 2019 and Brad King committed Aug 28, 2019

The fix in commit 9f6cd407 (SystemTools: Fix removing of soft links to
directories on Windows., 2017-12-14) made the infastructure added by
commit de83c4d4 (SystemTools: support deleting junction points,
2016-02-17) unnecessary.  Remove it.

Before this commit, when a file on Windows was deleted, it would check
if a file is a junction and then delete just the junction.

Now just skip the special case of a junction and allow the rest of the
code to delete it correctly. Can handle symlinks and junctions.

Revert commit 6e36d909 (SystemTools: Reduce scope of 'buf' variable in
CollapseFullPath, 2019-06-18).  A pointer to the buffer is returned by
`Getcwd` and stored in `res_in_base`.  The buffer must remain valid for
the lifetime of that variable.

Although `CollapseFullPath` is meant to construct a full path, it
is possible that a caller will provide a relative base path.
In this case, keep leading `../` components from the base path
instead of discarding them.

bdvd authored Jun 18, 2019 and Brad King committed Jun 20, 2019

The `Realpath` function takes `std::string`.

* Clang with the MSVC STL requires C++14
* Deprecatoion warning suppressions were specific to MSVC and Intel
* An assignment inside a condition resulted in a warning
* kwsysProcessSetExitException was declared, but never defined or used

Ben Boeckel authored Oct 07, 2015 and Brad King committed Apr 17, 2019

When determining full paths, CMake would treat the as-called path for
the source and build directories as real paths even if they were
symlinks. This causes problems when determining the relative path
between the source and build directories when they are symlinks.

Take the following setup as an example:

    /mnt/src/project/
        src/
        build/ -> /mnt/builds/project/build

With the translation map and /mnt/src/project/build/ as the build
directory, CMake would use ../src as the relative path to the source
tree from the build tree rather than ../../../src/project/src and
lookups using ../src would fail. If the build directory were instead
used *as* /mnt/builds/project/build, everything would work just
fine.

This patch makes the core logic which does this logic optional so that
it can be experimented with in CMake itself.

In `SystemToolsStatic::GetEnvBuffered` a pointer to the data of an internal
`std::string` is returned.  This string should only be updated on a change to
keep already emitted pointers valid as long as possible.

Since commit 228c60b8 (SystemTools: CopyFileAlways: try to create a
cheap CoW clone first, 2018-12-07) on Linux copying a file over itself
by specifying `.` as the destination leaves behind an empty file.  This
has long occurred on Windows too.  Move our existing same-file check
to after we know the real destination file.

The new private class SystemToolsStatic is supposed to hold all static
SystemTools variables in a single singleton class.  Static SystemTools
variables will be moved to SystemToolsStatic in following commits.  This patch
only adds the class skeleton type, its allocation and deletion.

Revert commit 7c71e879 (SystemTools: Use copyfile(3) to clone files on
macOS, 2019-03-05) because it changed the semantics of the copy
operation w.r.t. the timestamp left on the new file.  Further
investigation is needed to use `copyfile` while preserving semantics.

This makes file copying a O(1) COW operation on AFPS and
macOS 10.13.

Changed for sequenced container.

They are unused, but if someone used them they would lead to
problems since they would copy the internal raw pointers
and the destructor would cause double delete

Taylor Braun-Jones authored Jan 22, 2019 and Brad King committed Jan 23, 2019

Compares files in a line-ending-insensitive way.