Brad King authored 3 months ago and Kitware Robot committed 3 months ago

2926bae9 SystemTools: Fix CloneFileContent copy-on-write on macOS / APFS

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !315

Nick Begg authored 3 months ago and Brad King committed 3 months ago

`SystemTools::CloneFileContent()` attempts to clone a file using the
underlying filesystem’s copy-on-write features. The call to macOS’s
copyfile() was changed to not use COPYFILE_CLONE some time back due to
it following symlinks - which was not desired. Unfortunately (and the
manpage for copyfile() really doesn’t make this clear) this disables
cloning all together.

Go back to using `COPYFILE_CLONE`, but explicitly check for symlinks.

Additionally, add the `COPYFILE_UNLINK` flag. This fixes a second bug
in the existing implementation - existing files were not overwritten on
macOS which is inconsistent with the Linux implementation which
explicitly removes them, as well as calling `open()` with `O_CREAT`.
In effect this meant that progressively, previously cloned files become
de-cloned from their source as the built-in blockwise copy gets used
instead.

Rewrite the method comments which don't seem to have been updated since
the macOS implementation was added.  The function itself is not
especially well named anymore.

Verified cloning works using this tool:

* https://github.com/dyorgio/apfs-clone-checker

See also:

* https://wadetregaskis.com/copy-on-write-on-apfs/

Brad King authored 4 months ago and Kitware Robot committed 4 months ago

62ad438e Glob: Use case-insensitive matching on CYGWIN

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !314

CYGWIN is implemented on top of Windows, so the filesystem is not case
sensitive.

Brad King authored 4 months ago and Kitware Robot committed 4 months ago

967b2120 Remove legacy unused IMMEDIATE CMake keyword

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !313

This was once supported in CMake 2.x and in current 3.x versions is
ignored.

Brad King authored 4 months ago and Kitware Robot committed 4 months ago

5995fd7d SystemInformation: Ignore stderr from OS query tools

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !312

On macOS, `sw_vers` may print to `stderr` based on environment variables
like `MallocGuardEdges=1`.  Do not capture that as part of the
information it prints to `stdout`.

Issue: cmake/cmake#26466

Brad King authored 5 months ago and Kitware Robot committed 5 months ago

30e9db2d SystemTools: Drop GetActualCaseForPathCached

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !311

It was added temporarily for CMake, which no longer needs it.

Brad King authored 5 months ago and Kitware Robot committed 5 months ago

47dce1a3 SystemTools: Remove path translation map
20b2c992 SystemTools: Remove unused global object

Acked-by: Kitware Robot <kwrobot@kitware.com>
Reviewed-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !310

CMake used this to preserve symlinks through realpath operations, but
its presence caused some undesired side effects.  Those realpath
operations are being replaced with a hand-written alternative that
explicitly preserves symlinks when possible and does not have the side
effects.  Therefore we no longer need the path translation map.

Issue: cmake/cmake#16228

Remove an object unused since commit 4ef36a00 (SystemTools: Remove
Cygwin-specific file lookup optimization, 2020-08-01).

Brad King authored 5 months ago and Kitware Robot committed 5 months ago

fdf4f2f8 SystemTools: Fix ReadSymlink for links to absolute paths on Windows

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !309

Symlinks to absolute paths may use a NT Object Path prefix [1] [2].

[1] https://learn.microsoft.com/en-us/openspecs/windows_protocols/ms-even/c1550f98-a1ce-426a-9991-7509e7c3787c
[2] https://fleexlab.blogspot.com/2016/07/what-are-those-backslash-double.html

Brad King authored 5 months ago and Kitware Robot committed 5 months ago

f5e82d63 SystemTools: Replace malloc() with std::string

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !306

Brad King authored 5 months ago and Kitware Robot committed 5 months ago

210cea0a SystemTools: Replace unused argument to GetFullPathNameW with nullptr
3f14fce6 Process: Replace 0 with NULL in pointer arguments to GetFullPathNameW

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !304

scivision authored 5 months ago and Brad King committed 5 months ago

Refactor to avoid use of `malloc` in C++.  To get a `char*`,
use C++11 style `&buf[0]` rather than C++17 `buf.data()`.

Brad King authored 5 months ago and Kitware Robot committed 5 months ago

6e847d08 SystemInformation: Add missing EOF check when reading /proc/cpuinfo

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !307

Brad King authored 5 months ago and Kitware Robot committed 5 months ago

741c9c96 SystemTools: Expose GetActualCaseForPathCached publicly
5070bdb1 SystemTools: Restore GetActualCaseForPathCached internally

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !308

Callers that previously used it through `CollapseFullPath` may need to
use it directly since commit 4feb470a (SystemTools: Remove
GetActualCaseForPath from CollapseFullPath, 2024-10-23).

Revert the non-CollapseFullPath part of commit 4feb470a (SystemTools:
Remove GetActualCaseForPath from CollapseFullPath, 2024-10-23).  The
caching may still be useful to other callers later.

Brad King authored 5 months ago and Kitware Robot committed 5 months ago

4feb470a SystemTools: Remove GetActualCaseForPath from CollapseFullPath

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !305

Previously, `CollapseFullPath` internally called `GetActualCaseForPath`
on Windows.  This caused disk access for what otherwise should be a
string operation.  Callers can explicitly call `GetActualCaseForPath`
themselves if they need that behavior.

Issue: cmake/cmake#20214

Brad King authored 7 months ago and Kitware Robot committed 7 months ago

ee3223d7 SystemTools: fix clonefile optimization on macOS

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !303

Mike Lundy authored 7 months ago and Brad King committed 7 months ago

Since commit 0969597d (SystemTools: add a clonefile optimization on
macOS, 2022-06-03) input symlinks have been preserved as symlinks,
breaking the intention of producing a copy of the file.

Issue: cmake/cmake#26293

Brad King authored 7 months ago and Kitware Robot committed 7 months ago

68e1f35d SystemInformation: fix use of using

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !302

The automatic conversion from `typedef` to `using` in 7be4043f produced
unexpected results on struct definitions and left over some `typedefs`.
Perform a manual cleanup.

Brad King authored 7 months ago and Kitware Robot committed 7 months ago

5f4012c6 Don't compare to nullptr

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !301

Per C++ Core Guidelines ES.87
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#es87-dont-add-redundant--or--to-conditions
Ref: CMake PR 9778

Brad King authored 10 months ago and Kitware Robot committed 10 months ago

510b13b4 SystemTools: Add FileId class and GetFileId function

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !298

Jochem van Boxtel authored 10 months ago and Brad King committed 10 months ago

Add a FileId class, which encapsulates the identifier internally used
by the existing SystemTools::SameFile function. The GetFileId function
retrieves a FileId object for the given file or directory. This makes the
file identifier cacheable to the calling code, so that checking whether
one file is the same as many other candidates can be done faster.

Brad King authored 10 months ago and Kitware Robot committed 10 months ago

beaf1ca1 ConsoleBuf: Fix test case when running under Windows Terminal

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !299

Since commit 4967ccc0 (ConsoleBuf: Fix output for strings that contain
null byte, 2016-11-09) our test case writes a NUL byte to the console.
The behavior of Windows Terminal differs from Windows Console Host
(conhost.exe).  Detect which of these is in use at runtime and adjust
our expected result accordingly.

Brad King authored 11 months ago and Kitware Robot committed 11 months ago

a347a66b SystemInformation: Implement HasFPU on Apple processors
ff14b4f5 SystemInformation: Fix find logic

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !297