Commit cef03ffb authored by bonnell's avatar bonnell

Fix parallel-engine crash on Windows when using transparency in SR mode. The...

Fix parallel-engine crash on Windows when using transparency in SR mode. The culprit was an MPI_Allreduce with MPI_UNSIGNED_LONG_LONG.  The call aborted the mpi tasks because MPI_MAX is not defined for this datatype with the msmpi we currently use on Windows. The call was modified to use MPI_UNSIGNED_LONG instead.

git-svn-id: http://visit.ilight.com/svn/visit/trunk/src@31540 18c085ea-50e0-402c-830e-de6fd14e8384
parent 9c4387c4
......@@ -1453,6 +1453,10 @@ void avtTransparencyActor::SyncProps()
// Creation: Thu Jun 25 12:34:39 PDT 2015
//
// Modifications:
// Kathleen Biagas, Mon Sep 18 18:52:22 MST 2017
// Changed curMTime from 'unsigned long long' to 'unsigned long', because
// MPI_MAX is not defined for MPI_UNSIGNED_LONG_LONG in the MSMPI we use on
// Windows, and the actual type returned by GetMTime is 'unsigned long'.
//
// ****************************************************************************
......@@ -1461,18 +1465,13 @@ int avtTransparencyActor::SyncProps(vtkProperty *dest, vtkProperty *source)
#ifdef avtTransparencyActorDEBUG
debug2 << "avtTransparencyActor::SyncProps " << dest << " " << source << endl;
#endif
int rank = 0;
int size = 1;
#ifdef PARALLEL
MPI_Comm_rank(VISIT_MPI_COMM, &rank);
MPI_Comm_size(VISIT_MPI_COMM, &size);
#endif
int rank = PAR_Rank();
int size = PAR_Size();
// skip a bunch of communication of props haven't changed
unsigned long long curMTime = source ? source->GetMTime() : 0;
unsigned long curMTime = source ? source->GetMTime() : 0;
#ifdef PARALLEL
MPI_Allreduce(MPI_IN_PLACE, &curMTime, 1, MPI_UNSIGNED_LONG_LONG,
MPI_Allreduce(MPI_IN_PLACE, &curMTime, 1, MPI_UNSIGNED_LONG,
MPI_MAX, VISIT_MPI_COMM);
#endif
#ifdef avtTransparencyActorDEBUG
......
......@@ -103,6 +103,7 @@ enhancements and bug-fixes that were added to this release.</p>
<li>VTK export options have been modified to more explicitly state the combination of Legacy+[Ascii/Binary], XML+[Ascii/Binary]</li>
<li>Removed "Lawrence Livermore National Laboratory (LLNL) rz network" from the list of network configurations to install when installing on Windows since that configuration only works when running VisIt directly on the rz machines.</li>
<li>Fixed documentation regarding Eigenvector and Eigenvalue expression functions to indicate that they work for only symmetric cases. In addition, added documentation that the Eigenvector expression result must be transposed in order to use the component index operator to access a given eigenvector.</li>
<li>Fixed parallel-engine crash on Windows when using transparency in Scalable rendering mode.</li>
</ul>
<a name="Configuration_changes"></a>
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment