1. 22 Aug, 2019 5 commits
  2. 21 Aug, 2019 13 commits
  3. 20 Aug, 2019 14 commits
    • Kenneth Moreland's avatar
      Copy Threshold output to a CellSetExplicit · 42e8a912
      Kenneth Moreland authored
      Perhaps a better title for this change would be "Make the Threshold
      filter not totally useless."
      
      A long standing issue with the Threshold filter is that its output
      CellSet was stored in a CellSetPermutation. This made Threshold hyper-
      efficient because it required hardly any data movement to implement.
      However, the problem was that any other unit that had to use the CellSet
      failed. To have VTK-m handle that output correctly in other filters and
      writers, they all would have to check for the existance of
      CellSetPermutation. And CellSetPermutation is templated on the CellSet
      type it is permuting, so all units would have to compile special cases
      for all these combinations. This is not likely to be feasible in any
      static solution.
      
      The simple solution, implemented here, is to deep copy the cells to a
      CellSetExplicit, which is a known type that is already used everywhere
      in VTK-m. The solution is a bit disappointing since it requires more
      memory and time to build. But it is on par with solutions in other
      libraries (like VTK). And it really does not matter how efficient the
      old solution was if it was useless.
      42e8a912
    • Kenneth Moreland's avatar
      Merge topic 'more-gradient-testing' · 1473c12e
      Kenneth Moreland authored and Kitware Robot's avatar Kitware Robot committed
      c19b312e
      
       Fix gradient issue at apex of pyramid cells
      Acked-by: Kitware Robot's avatarKitware Robot <kwrobot@kitware.com>
      Acked-by: Li-Ta Lo's avatarLi-Ta Lo <ollie@lanl.gov>
      Merge-request: !1785
      1473c12e
    • Robert Maynard's avatar
      Opt into all CMake 3.15 policies · 267f963d
      Robert Maynard authored
      267f963d
    • Kenneth Moreland's avatar
      Use SFINAE to write Set/Get methods in ArrayPortalSOA · aebafc9e
      Kenneth Moreland authored
      Because ArrayPortalSOA calls a delegate portal to get the actual values,
      it can only implement its own Set or Get if the delegate portal supports
      it. Previously this was done by calling an overloaded internal method
      based on the result of PortalSupportsSets/Gets. However, regardless of
      whether the delegate portal supported Set or Get, ArrayPortalSOA
      provided one. Thus, if something else tried to use PortalSupportsSets/
      Gets on ArrayPortalSOA, it would always report true even if it was not
      really supported.
      
      Instead, use SFINAE to remove the Set or Get if that method is not
      supported in the delegate portal.
      
      Since ArrayHandleSOA is only really used for portals from basic storage
      arrays, it will be rare that Set or Get is not supported. However, a
      device adapter is free to remove one of these methods on a device
      portal. For example, if you call PrepareForInput on an ArrayHandle, it
      is possible that the device adapter will create a portal that has no Set
      method because the array is not writable.
      
      Thanks to Allison Vacanti for recomending this solution.
      aebafc9e
    • Kenneth Moreland's avatar
      20c75810
    • Kenneth Moreland's avatar
      Make SOA Portal test more type safe · c5085724
      Kenneth Moreland authored
      I kept getting warnings from different compilers about type conversions
      because I was making values by adding an index to them. Change how we
      create and test values so that these type issues are less likely to come
      up.
      c5085724
    • Kenneth Moreland's avatar
      Fix VS 2015 compile issue with HasVecTraits · 918766e7
      Kenneth Moreland authored
      Apparently, the Visual Studio 2015 has a bug where the result of a
      decltype might not be considered a type. Attempt to get around this
      problem by putting the decltype inside of a struct and then have the
      using statement use the typename keyword. Hopefully if you literally say
      that something is a typename, the compiler will treat it like a type
      name.
      918766e7
    • Kenneth Moreland's avatar
      Add ArrayHandleSOA · 869d6658
      Kenneth Moreland authored
      This ArrayHandle should behave just like the one with basic storage but
      external arrays stored by component can be shallow-copied to them.
      869d6658
    • Allison Vacanti's avatar
      Fix IsArrayHandleWritable for Extrude arrays. · 67f1a772
      Allison Vacanti authored
      The portal Set methods should be left unimplemented for immutable
      array handles.
      67f1a772
    • Allison Vacanti's avatar
      38748a22
    • Li-Ta Lo's avatar
      Merge topic 'contour_hackathon' · 50bdb798
      Li-Ta Lo authored and Kitware Robot's avatar Kitware Robot committed
      9b0a79f1 let's see if I fixe the one last bug
      e66af369 removed isosurface example, add clipped tangle to Contour unit test
      0a020c77 fixed error in TetrahedralizedExplicit, rename MarchineCubes to Contour
      e9e35159 change MarchingCubes to Contour that was missed before merge
      c2e29f5c Merge branch 'master' into contour_hackathon
      6a54d5f7 supress warning about converting vtkm::Id to vtkm::IdComponent
      27a9962f rename MarchingCubes to Contour in benchmarks
      414effa8
      
       remove unused contour unit test
      ...
      Acked-by: Kitware Robot's avatarKitware Robot <kwrobot@kitware.com>
      Acked-by: Kenneth Moreland's avatarKenneth Moreland <kmorel@sandia.gov>
      Merge-request: !1780
      50bdb798
    • Robert Maynard's avatar
      Merge topic 'nice_field_construction_docs' · 7c25929d
      Robert Maynard authored and Kitware Robot's avatar Kitware Robot committed
      78c7a8d8 Add changelog for make_Field changes
      5087b172
      
       Add changelog for CreateResult changes
      Acked-by: Kitware Robot's avatarKitware Robot <kwrobot@kitware.com>
      Acked-by: Kenneth Moreland's avatarKenneth Moreland <kmorel@sandia.gov>
      Merge-request: !1784
      7c25929d
    • Robert Maynard's avatar
      Add changelog for make_Field changes · 78c7a8d8
      Robert Maynard authored
      78c7a8d8
    • Robert Maynard's avatar
      Add changelog for CreateResult changes · 5087b172
      Robert Maynard authored
      5087b172
  4. 19 Aug, 2019 6 commits
  5. 18 Aug, 2019 2 commits