Commit 011f0836 authored by Matt Larsen's avatar Matt Larsen Committed by Kitware Robot

Merge topic 'remove_inverse_check'

88290047 removing matrix inverse because of false negatives
Acked-by: Kitware Robot's avatarKitware Robot <>
Merge-request: !1483
parents 77acc39f 88290047
......@@ -37,9 +37,7 @@ void RayOperations::MapCanvasToRays(Ray<vtkm::Float32>& rays,
vtkm::MatrixMultiply(camera.CreateProjectionMatrix(width, height), camera.CreateViewMatrix());
bool valid;
vtkm::Matrix<vtkm::Float32, 4, 4> inverse = vtkm::MatrixInverse(projview, valid);
if (!valid)
throw vtkm::cont::ErrorBadValue("Inverse Invalid");
(void)valid; // this can be a false negative for really tiny spatial domains.
detail::RayMapCanvas(inverse, width, height, camera.GetPosition()))
.Invoke(rays.PixelIdx, rays.MaxDistance, canvas.GetDepthBuffer());
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment