1. 23 Jul, 2019 2 commits
  2. 22 Jul, 2019 1 commit
  3. 20 Jul, 2019 1 commit
    • Kenneth Moreland's avatar
      Fix IsWritableArrayHandle for portals that exist but cannot be written · 6592e528
      Kenneth Moreland authored
      Previously, IsWriteableArrayHandle just checked to see if an
      ArrayHandle's portal has a ValueType of void* because we had coded the
      special read-only array handles to have fake portals for writing.
      However, we recently removed that because it was more trouble than it
      was worth. Now IsWritableArrayHandle checks for the existance of the Set
      method. If it does not exist, then the portal is considered read-only.
      
      Also corrected spelling (writeable -> writable).
      6592e528
  4. 19 Jul, 2019 4 commits
  5. 18 Jul, 2019 4 commits
    • Robert Maynard's avatar
      Merge topic 'add_odr_warning_flag' · c18f7626
      Robert Maynard authored
      73666461 Cleanup VTK-m warning flags and add in Wodr
      Acked-by: Kitware Robot's avatarKitware Robot <kwrobot@kitware.com>
      Merge-request: !1732
      c18f7626
    • Robert Maynard's avatar
      Cleanup VTK-m warning flags and add in Wodr · 73666461
      Robert Maynard authored
      This was done to help us catch ODR violations quicker
      73666461
    • Kenneth Moreland's avatar
      Enable writing to ArrayHandleCast · 0e15a111
      Kenneth Moreland authored
      Previously, `ArrayHandleCast` was considered a read-only array handle.
      However, it is trivial to reverse the cast (now that `ArrayHandleTransform`
      supports an inverse transform). So now you can write to a cast array
      (assuming the underlying array is writable).
      
      One trivial consequence of this change is that you can no longer make a
      cast that cannot be reversed. For example, it was possible to cast a simple
      scalar to a `Vec` even though it is not possible to convert a `Vec` to a
      scalar value. This was of dubious correctness (it is more of a construction
      than a cast) and is easy to recreate with `ArrayHandleTransform`.
      0e15a111
    • Kenneth Moreland's avatar
      Remove invalid PortalType · 6d37ce94
      Kenneth Moreland authored
      Several ArrayHandles (actuall Storage implementations) had a fake portal
      type that only defined invalid value types and no Get/Set methods. The
      idea was to quickly identify when using a read-only array for writing.
      However, this was more trouble than it was worth as the compiler just
      gives  an incomprehensible error and it is hard to track down the actual
      value.
      
      Now actually define some type even if it is never used.
      6d37ce94
  6. 17 Jul, 2019 8 commits
  7. 16 Jul, 2019 7 commits
  8. 13 Jul, 2019 1 commit
  9. 11 Jul, 2019 2 commits
  10. 10 Jul, 2019 2 commits
    • Kenneth Moreland's avatar
      Fix issues with PointLocatorUniformGrid not finding all points · 461f87db
      Kenneth Moreland authored
      There was a known issue where PointLocatorUniformGrid would quickly quit
      once it found a point. Instead, look at one more level of bins just in
      case there is a closer one near the boundary. (Still not guaranteed, but
      likely.)
      
      Also, fix a typo that caused some bins in the y and z direction to not
      be searched.
      461f87db
    • Kenneth Moreland's avatar
      Fix PointLocatorUniformGrid for points on boundary · e473cb4b
      Kenneth Moreland authored
      When creating the search structures in PointLocatorUniformGrid, a point
      outside the boundary would be given an invalid bin id. These points
      could never be found. Generally, this is not a big deal for points
      outside of the boundary, but it could be a problem for points on the
      boundary. A point on the boundary could be taken as outside the
      boundary. Since the boundary is chosen from limits of the points, some
      will almost always be on the boundary.
      
      Fix this problem by clamping all points to the nearest valid bin. This
      could cause a problem if the user has selected a boundary excluding a
      lot of points. All those points could be grouped to the same edge bins,
      but that is probably not a great idea anyway.
      e473cb4b
  11. 09 Jul, 2019 8 commits