GitLab

Allison Vacanti authored Jul 23, 2019 and Kitware Robot committed Jul 23, 2019

bff75de4

 Use std::is_integral<T>::value instead of is_int<>{}.
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Kenneth Moreland <kmorel@sandia.gov>
Merge-request: !1736

NVCC doesn't seem to handle the construction + implicit conversion
well. Explicitly specifying the value fixes this.

Kenneth Moreland authored Jul 22, 2019 and Kitware Robot committed Jul 22, 2019

6592e528 Fix IsWritableArrayHandle for portals that exist but cannot be written
0e15a111 Enable writing to ArrayHandleCast
6d37ce94

 Remove invalid PortalType
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !1731

Previously, IsWriteableArrayHandle just checked to see if an
ArrayHandle's portal has a ValueType of void* because we had coded the
special read-only array handles to have fake portals for writing.
However, we recently removed that because it was more trouble than it
was worth. Now IsWritableArrayHandle checks for the existance of the Set
method. If it does not exist, then the portal is considered read-only.

Also corrected spelling (writeable -> writable).

Allison Vacanti authored Jul 19, 2019 and Kitware Robot committed Jul 19, 2019

094cf215

 Rename a file to match CMakeLists.txt in an example.
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !1734

Allison Vacanti authored Jul 19, 2019 and Kitware Robot committed Jul 19, 2019

694d1e11

 Add methods to BoundaryState to query specific offsets.
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Robert Maynard <robert.maynard@kitware.com>
Merge-request: !1733

The existing functionality worked on radii, but it's helpful to
know if a specific sample location will be in bounds, too.

Fixes #385.

Robert Maynard authored Jul 18, 2019 and Kitware Robot committed Jul 18, 2019

73666461

 Cleanup VTK-m warning flags and add in Wodr
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !1732

This was done to help us catch ODR violations quicker

Previously, `ArrayHandleCast` was considered a read-only array handle.
However, it is trivial to reverse the cast (now that `ArrayHandleTransform`
supports an inverse transform). So now you can write to a cast array
(assuming the underlying array is writable).

One trivial consequence of this change is that you can no longer make a
cast that cannot be reversed. For example, it was possible to cast a simple
scalar to a `Vec` even though it is not possible to convert a `Vec` to a
scalar value. This was of dubious correctness (it is more of a construction
than a cast) and is easy to recreate with `ArrayHandleTransform`.

Several ArrayHandles (actuall Storage implementations) had a fake portal
type that only defined invalid value types and no Get/Set methods. The
idea was to quickly identify when using a read-only array for writing.
However, this was more trouble than it was worth as the compiler just
gives  an incomprehensible error and it is hard to track down the actual
value.

Now actually define some type even if it is never used.

Robert Maynard authored Jul 17, 2019 and Kitware Robot committed Jul 17, 2019

46a1df6c DecodePNG uses the namespaced lodepng from thirdparty/
26e50065 Merge branch 'upstream-lodepng' into namespace_lodepng
43e0185b

 lodepng 2019-07-17 (82328a33)
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Matt Larsen <larsen30@llnl.gov>
Merge-request: !1728

Kenneth Moreland authored Jul 17, 2019 and Kitware Robot committed Jul 17, 2019

b622c796 Fixed index out of bounds error for the cell counts array
4d61066e Removed all modifications in the internal device adapter algorithm header files.
06ac9f72 Revised version of the original mesh quality merge request
e5400136 Added few lines of code missing from cuda device adapter header
3dd34d25 Added custom CopyIf function
417dbcea Removed all modifications in the internal device adapter algorithm header files.
50cb805c Fixed cuda device adapter alg
8c070caa

 Added few lines of code missing from cuda device adapter header
...
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Kenneth Moreland <kmorel@sandia.gov>
Merge-request: !1714

* upstream-lodepng:
  lodepng 2019-07-17 (82328a33)

Code extracted from:

    https://gitlab.kitware.com/third-party/lodepng.git

at commit 82328a339c20149365089c6b969be00a9166780b (for/vtk-m).

Robert Maynard authored Jul 17, 2019 and Kitware Robot committed Jul 17, 2019

772e36ba

 When VTKm_ENABLE_MPI is enabled finding MPI is always required
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Allison Vacanti <allison.vacanti@kitware.com>
Merge-request: !1727

Robert Maynard authored Jul 17, 2019 and Kitware Robot committed Jul 17, 2019

6de7d07d

 VTK-m requires CMake 3.13 to compile CUDA
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Kenneth Moreland <kmorel@sandia.gov>
Merge-request: !1725

Allison Vacanti authored Jul 17, 2019 and Kitware Robot committed Jul 17, 2019

41894a97 Unroll reduction loops for non-integral types on OpenMP.
e30cb087

 Fix OpenMP for gcc-9 backwards incompatibility.
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Robert Maynard <robert.maynard@kitware.com>
Merge-request: !1724

Hank authored Jul 16, 2019 and Kitware Robot committed Jul 16, 2019

2fc7cb02 remove unused variable
5064854a

 Add error message with bad file open
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Sujin Philip <sujin.philip@kitware.com>
Merge-request: !1722

This is to resolve issues related to FindThreads and CUDA
compilation.

For details, see

https://www.gnu.org/software/gcc/gcc-9/porting_to.html

Previously we had logic where find_package(MPI) wasn't required

Robert Maynard authored Jul 16, 2019 and Kitware Robot committed Jul 16, 2019

28484fc6 Update examples and benchmarks to use new VTK-m CMake helper function
ea50e82a Move VTK-m CMake testing wrappers to the testing folder
0b7dd7c3 Add CMake vtkm_add_target_information() to make using vtk-m easier
e934e227 vtkm_library WRAP_FOR_CUDA renamed to clarify the intent of the property
a2e6660f

 Remove unused vtkm_compile_as_cuda CMake function
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Matt Larsen <larsen30@llnl.gov>
Merge-request: !1718

Li-Ta Lo authored Jul 11, 2019 and Kitware Robot committed Jul 11, 2019

461f87db Fix issues with PointLocatorUniformGrid not finding all points
e473cb4b

 Fix PointLocatorUniformGrid for points on boundary
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Li-Ta Lo <ollie@lanl.gov>
Merge-request: !1720

Robert Maynard authored Jul 11, 2019 and Kitware Robot committed Jul 11, 2019

4a5ef8c6 VTKmCPUVectorization GCC native supports ppc64le
68a9167a VTKmCPUVectorization now uses -march=<cpu_arch>
d0d67804

 Correctly enable vectorization of avx512 when using gcc.
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !1719

There was a known issue where PointLocatorUniformGrid would quickly quit
once it found a point. Instead, look at one more level of bins just in
case there is a closer one near the boundary. (Still not guaranteed, but
likely.)

Also, fix a typo that caused some bins in the y and z direction to not
be searched.

When creating the search structures in PointLocatorUniformGrid, a point
outside the boundary would be given an invalid bin id. These points
could never be found. Generally, this is not a big deal for points
outside of the boundary, but it could be a problem for points on the
boundary. A point on the boundary could be taken as outside the
boundary. Since the boundary is chosen from limits of the points, some
will almost always be on the boundary.

Fix this problem by clamping all points to the nearest valid bin. This
could cause a problem if the user has selected a boundary excluding a
lot of points. All those points could be grouped to the same edge bins,
but that is probably not a great idea anyway.

The VTK-m testing infrastructure isn't public facing so it doesn't
need to be installed or clutter the main VTKmWrappers file.

At the same time I have refactored the code to make it clearer
to understand, and remove unused options.

The function allows consumers to modify an existing target to allow
for correct compilation with VTK-m.

We want the option name to be clear that it might be applicable for
more than just CUDA. If VTK-m ever supported something like SYCL
it would not be clear that those sources should go in `WRAP_FOR_CUDA`.

Robert Maynard authored Jul 09, 2019 and Kitware Robot committed Jul 09, 2019

65f169b3

 VTK-m now will now error when mixing CUDA and shared builds
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Kenneth Moreland <kmorel@sandia.gov>
Merge-request: !1717

The PowerPC front end uses mcpu instead of march.