From ecd5c963e4dc24f83cd55d174c9a324fb400da06 Mon Sep 17 00:00:00 2001
From: Jaswant Panchumarti <jaswant.panchumarti@kitware.com>
Date: Wed, 17 Jan 2024 18:47:21 -0500
Subject: [PATCH] vtkParseProperties: Restrict suffix detection to AsString
- Otherwise, GetOutputAsDataSet was matched as a getter function for a property named 'Output'. This occurred for the vtkHDFReader::GetOutputAsDataSet function.
(cherry picked from commit f3b963c9d716460ccda89fff8247b173d9a61b91)
---
Wrapping/Tools/vtkParseProperties.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Wrapping/Tools/vtkParseProperties.c b/Wrapping/Tools/vtkParseProperties.c
index 1c0dc82f727..56ab1a6eb4a 100644
--- a/Wrapping/Tools/vtkParseProperties.c
+++ b/Wrapping/Tools/vtkParseProperties.c
@@ -401,8 +401,9 @@ static int isValidSuffix(const char* methName, const char* propertyName, const c
return 1;
}
+ /* AsString or MaxValue or MinValue or AsN or */
else if (isGetMethod(methName) &&
- ((suffix[0] == 'A' && suffix[1] == 's' && (isupper(suffix[2]) || isdigit(suffix[2]))) ||
+ ((suffix[0] == 'A' && suffix[1] == 's' && ((suffix[2] == 'S') || isdigit(suffix[2]))) ||
(((suffix[0] == 'M' && suffix[1] == 'a' && suffix[2] == 'x') ||
(suffix[0] == 'M' && suffix[1] == 'i' && suffix[2] == 'n')) &&
(suffix[3] == 'V' && suffix[4] == 'a' && suffix[5] == 'l' && suffix[6] == 'u' &&
--
GitLab