GitLab

This commit will ensure that ITK IO factory are properly registered on all
supported platforms.

When ITKv4 is build shared, the library holding the factory registration code
are build statically. As a consequence, when CLI module are loaded as library
the factory are registered multiple times. Around 800 factories where registered
and this was leading to poor performance when loading images.

This commit enable the building of a shared library named ITKFactoryRegistration
that should be linked against to ensure loading of the factory. This approach
can succeed thanks to the help of the ITK variable ITK_NO_IO_FACTORY_REGISTER_MANAGER.

This variable allow to disable the automatic registration of factory in selected part
of the code.

The following two cases are handled:
 - Registration of the factories within the Slicer executable.
 - Registration of the factories within CLI executable.

Fixes #2813

From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21592 3bd1e089-480b-0410-8dfb-8563597acbee

Visual Studio defines min as a macro and collides with the use of
std::min. Here we conditionally undefine the min macro.

Contributed by Luis Ibanez

From: Jean-Christophe Fillion-Robin <jchris.fillionr@kitware.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21591 3bd1e089-480b-0410-8dfb-8563597acbee

When multiple paths were passed, they were incorrectly converted to a single
path containing a space instead of a list of paths.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21590 3bd1e089-480b-0410-8dfb-8563597acbee

Contributed by Bill Lorensen

From: Bill Lorensen <bill.lorensen@gmail.com>

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21589 3bd1e089-480b-0410-8dfb-8563597acbee

vtkCollectionIterator and vtkCollection had still a reference count of 1
at exit.
Regression from r21523

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21588 3bd1e089-480b-0410-8dfb-8563597acbee

The cleanup() method can't delete the scene in the testResetScene() case

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21587 3bd1e089-480b-0410-8dfb-8563597acbee

Don't listen to nodes that are filtered out by the sort&filter proxy model.
Issue #2642

Example of performance on MacBookPro laptop:
AddData (BrainAtlas2012.mrb) took 22741 msecs -10000msecs
CloseScene () took 11827 msecs  -10000msecs
AddData (BrainAtlas2012.mrb) took 20909 msecs
ModifyNode (vtkMRMLScalarVolumeNode1) took 4 msecs
ModifyNode (vtkMRMLScalarVolumeNode2) took 24 msecs
ModifyNode (vtkMRMLScalarVolumeDisplayNode2) took 22 msecs
ModifyNode (vtkMRMLScalarVolumeNode3) took 15 msecs
ModifyNode (vtkMRMLModelHierarchyNode2) took 10 msecs
ModifyNode (vtkMRMLModelNode4) took 0 msecs
ModifyNode (vtkMRMLModelDisplayNode5) took 11 msecs
ModifyNode (vtkMRMLModelHierarchyNode3) took 10 msecs
ModifyNode (vtkMRMLModelStorageNode1) took 0 msecs
AddNode (vtkMRMLModelNode302) took 20 msecs
Layout (3) took 51 msecs
Layout (2) took 24 msecs
RestoreSceneView (vtkMRMLSceneViewNode15) took 865 msecs  -1000msecs
RestoreSceneView (vtkMRMLSceneViewNode15) took 622 msecs

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21586 3bd1e089-480b-0410-8dfb-8563597acbee

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21585 3bd1e089-480b-0410-8dfb-8563597acbee

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21584 3bd1e089-480b-0410-8dfb-8563597acbee

Issue #2642

Example of performance on a MacBookPro laptop:
AddData (BrainAtlas2012.mrb) took 30911 msecs
CloseScene () took 21943 msecs
CloseScene () took 76 msecs
AddData (BrainAtlas2012.mrb) took 29535 msecs
ModifyNode (vtkMRMLScalarVolumeNode1) took 4 msecs
ModifyNode (vtkMRMLScalarVolumeNode2) took 25 msecs
ModifyNode (vtkMRMLScalarVolumeDisplayNode2) took 23 msecs
ModifyNode (vtkMRMLScalarVolumeNode3) took 15 msecs
ModifyNode (vtkMRMLModelHierarchyNode2) took 10 msecs
ModifyNode (vtkMRMLModelNode4) took 0 msecs
ModifyNode (vtkMRMLModelDisplayNode5) took 11 msecs
ModifyNode (vtkMRMLModelHierarchyNode3) took 11 msecs
ModifyNode (vtkMRMLModelStorageNode1) took 5 msecs
AddNode (vtkMRMLModelNode302) took 31 msecs
Layout (3) took 9 msecs
Layout (2) took 27 msecs
Layout (3) took 50 msecs
RestoreSceneView (vtkMRMLSceneViewNode15) took 2701 msecs
RestoreSceneView (vtkMRMLSceneViewNode15) took 1542 msecs

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21583 3bd1e089-480b-0410-8dfb-8563597acbee

Issue #2642

Example of performance on a MacBookPro laptop:
AddData (BrainAtlas2012.mrb) took 32574 msecs
CloseScene () took 24954 msecs
CloseScene () took 104 msecs
AddData (BrainAtlas2012.mrb) took 30087 msecs
ModifyNode (vtkMRMLScalarVolumeNode1) took 4 msecs
ModifyNode (vtkMRMLScalarVolumeNode1) took 3 msecs
ModifyNode (vtkMRMLScalarVolumeNode2) took 25 msecs
ModifyNode (vtkMRMLScalarVolumeNode3) took 16 msecs
ModifyNode (vtkMRMLScalarVolumeDisplayNode2) took 22 msecs
ModifyNode (vtkMRMLModelHierarchyNode2) took 10 msecs
ModifyNode (vtkMRMLModelNode4) took 0 msecs
ModifyNode (vtkMRMLModelDisplayNode5) took 11 msecs
ModifyNode (vtkMRMLModelHierarchyNode3) took 10 msecs
ModifyNode (vtkMRMLModelStorageNode1) took 4 msecs
AddNode (vtkMRMLModelNode302) took 31 msecs
Layout (3) took 66 msecs
Layout (2) took 20 msecs
Layout (3) took 53 msecs
Layout (2) took 19 msecs
RestoreSceneView (vtkMRMLSceneViewNode15) took 2730 msecs
RestoreSceneView (vtkMRMLSceneViewNode15) took 1556 msecs

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21582 3bd1e089-480b-0410-8dfb-8563597acbee

Issue #2642

Example of performance on a MacBookPro laptop:
AddData (BrainAtlas2012.mrb) took 37541 msecs
CloseScene () took 26276 msecs
CloseScene () took 117 msecs
AddData (BrainAtlas2012.mrb) took 37057 msecs
ModifyNode (vtkMRMLScalarVolumeNode1) took 4 msecs
ModifyNode (vtkMRMLScalarVolumeNode2) took 26 msecs
ModifyNode (vtkMRMLScalarVolumeNode3) took 15 msecs
ModifyNode (vtkMRMLScalarVolumeDisplayNode2) took 22 msecs
ModifyNode (vtkMRMLModelHierarchyNode2) took 10 msecs
ModifyNode (vtkMRMLModelNode4) took 0 msecs
ModifyNode (vtkMRMLModelDisplayNode5) took 11 msecs
ModifyNode (vtkMRMLModelHierarchyNode3) took 11 msecs
ModifyNode (vtkMRMLModelStorageNode1) took 4 msecs
AddNode (vtkMRMLModelNode302) took 41 msecs
Layout (3) took 52 msecs
Layout (2) took 18 msecs
RestoreSceneView (vtkMRMLSceneViewNode15) took 2911 msecs
RestoreSceneView (vtkMRMLSceneViewNode15) took 1608 msecs

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21581 3bd1e089-480b-0410-8dfb-8563597acbee

Issue #2642

Example of performance on a MacBookPro laptop:
AddData (BrainAtlas2012.mrb) took 39877 msecs
CloseScene () took 26271 msecs
CloseScene () took 136 msecs
AddData (BrainAtlas2012.mrb) took 36945 msecs
ModifyNode (vtkMRMLScalarVolumeNode1) took 4 msecs
ModifyNode (vtkMRMLScalarVolumeNode2) took 28 msecs
ModifyNode (vtkMRMLScalarVolumeNode3) took 16 msecs
ModifyNode (vtkMRMLModelHierarchyNode2) took 13 msecs
ModifyNode (vtkMRMLModelNode5) took 1 msecs
ModifyNode (vtkMRMLModelNode4) took 0 msecs
ModifyNode (vtkMRMLModelDisplayNode5) took 12 msecs
ModifyNode (vtkMRMLModelHierarchyNode3) took 12 msecs
ModifyNode (vtkMRMLModelStorageNode1) took 4 msecs
ModifyNode (vtkMRMLModelHierarchyNode301) took 17 msecs
ModifyNode (vtkMRMLModelDisplayNode304) took 21 msecs
ModifyNode (vtkMRMLModelHierarchyNode302) took 17 msecs
AddNode (vtkMRMLModelNode5) took 90 msecs
AddNode (vtkMRMLModelNode302) took 45 msecs

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21580 3bd1e089-480b-0410-8dfb-8563597acbee

It measures time spent by some scene actions such as loading, closing,
restoring, relayouting a scene or modifying/adding nodes.
Issue #2642

Example of performance on a MacBookPro laptop (2.4GHz):
AddData (BrainAtlas2012.mrb) took 44865 msecs
CloseScene () took 28706 msecs
AddData (BrainAtlas2012.mrb) took 44579 msecs
ModifyNode (vtkMRMLScalarVolumeNode1) took 4 msecs
ModifyNode (vtkMRMLScalarVolumeNode2) took 35 msecs
ModifyNode (vtkMRMLScalarVolumeNode3) took 20 msecs
ModifyNode (vtkMRMLModelHierarchyNode2) took 14 msecs
ModifyNode (vtkMRMLModelNode4) took 0 msecs
ModifyNode (vtkMRMLModelDisplayNode5) took 14 msecs
ModifyNode (vtkMRMLModelHierarchyNode3) took 13 msecs
ModifyNode (vtkMRMLModelStorageNode1) took 4 msecs
ModifyNode (vtkMRMLModelHierarchyNode301) took 18 msecs
ModifyNode (vtkMRMLModelDisplayNode304) took 23 msecs
ModifyNode (vtkMRMLModelHierarchyNode51) took 19 msecs
AddNode (vtkMRMLModelNode302) took 46 msecs

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21579 3bd1e089-480b-0410-8dfb-8563597acbee

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21578 3bd1e089-480b-0410-8dfb-8563597acbee

BUG: Corrected bug 2381 the DTI volume glyphs now use the correct color map when in color by orientation mode

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21577 3bd1e089-480b-0410-8dfb-8563597acbee

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21576 3bd1e089-480b-0410-8dfb-8563597acbee

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21575 3bd1e089-480b-0410-8dfb-8563597acbee

The message "File ... qSlicerBaseQTCore_fr.qm" doesn't exist."
won't occur anymore when starting Slicer.

See http://www.na-mic.org/Bug/view.php?id=2863

Fixes #2863

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21574 3bd1e089-480b-0410-8dfb-8563597acbee

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21573 3bd1e089-480b-0410-8dfb-8563597acbee

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21572 3bd1e089-480b-0410-8dfb-8563597acbee

Since github.com deprecated its download api [1], the launcher packages
have been uploaded on packages.kitware.com.

[1] https://github.com/blog/1302-goodbye-uploads

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21571 3bd1e089-480b-0410-8dfb-8563597acbee

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21570 3bd1e089-480b-0410-8dfb-8563597acbee

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21569 3bd1e089-480b-0410-8dfb-8563597acbee

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21568 3bd1e089-480b-0410-8dfb-8563597acbee

The generated XTK code is now compatible with the slightly new API and linking against the tag of release 9 should ensure stability in the future.



git-svn-id: http://svn.slicer.org/Slicer4/trunk@21567 3bd1e089-480b-0410-8dfb-8563597acbee

Fixes #2848

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21566 3bd1e089-480b-0410-8dfb-8563597acbee

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21565 3bd1e089-480b-0410-8dfb-8563597acbee

Avoid a degenerate transform by checking for null column
and replacing it with the cross product.  This can happen
when the ijkToRAS transform is not uniquely aligned with the
cardinal axes and the algorithm to determine the correspondence
between volume axes and patient axes fails.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21564 3bd1e089-480b-0410-8dfb-8563597acbee

BUG 2764. Made vtkMRMLSceneViewNode handle node ids cache: NodeIDs. Restructured handling of  NodeIDs in the vtkMRMLScene

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21563 3bd1e089-480b-0410-8dfb-8563597acbee

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21562 3bd1e089-480b-0410-8dfb-8563597acbee

Note that it does not fix the import of annotation hierarchies.
For some reasons (see vtkSlicerAnnotationModuleLogic::OnSceneNodeAdded),
the hierarchies are automatically loaded into the wrong hierarchy node
parent.
Issue #2849

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21561 3bd1e089-480b-0410-8dfb-8563597acbee

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21560 3bd1e089-480b-0410-8dfb-8563597acbee

Moved loadTranslations() and loadLanguage() methods from qSlicerApplicationHelper
to qSlicerCoreApplication. This enables loading them before instantiating the
main Slicer GUI.
Many thanks to zengwenye <iamzengwenye@163.com> for submitting the patch.
Fixes issue 2836

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21559 3bd1e089-480b-0410-8dfb-8563597acbee

when Slicer_APPLICATIONS_DIR was defined but empty

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21558 3bd1e089-480b-0410-8dfb-8563597acbee

Slicer_BUILD_EXTENSIONMANAGER_SUPPORT is OFF

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21557 3bd1e089-480b-0410-8dfb-8563597acbee

Can temporarily force the filtering of a qMRMLTreeView.
Character ! on tree view switches filtering mode in debug mode.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21556 3bd1e089-480b-0410-8dfb-8563597acbee

Allows to programatically set the default action without activating
the place mode:
 - vtkMRMLSelectionNode::SetActiveAnnotationID
Don't listen to unnecessary events like ActiveAnnotationIDChangedEvent,
AnnotationIDListModifiedEvent, InteractionModePersistenceChangedEvent.
Listening to ModifiedEvent is enough.
Todo: remove the unnecessary events.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21555 3bd1e089-480b-0410-8dfb-8563597acbee

If qSlicerModulesMenu::setCurrentModule() is called before the module has
been loaded, qSlicerModulesMenu was not triggering the action which could
result in observers not being notified. (the module selection toolbar)

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21554 3bd1e089-480b-0410-8dfb-8563597acbee

Categories are separated with ; character.
Empty categories are allowed (become top level)

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21553 3bd1e089-480b-0410-8dfb-8563597acbee