Slicer merge requestshttps://gitlab.kitware.com/sjh26/Slicer/-/merge_requests2017-03-20T09:41:59-04:00https://gitlab.kitware.com/sjh26/Slicer/-/merge_requests/514Modify build to allow external projects to change VTK repo.2017-03-20T09:41:59-04:00Sam HorvathModify build to allow external projects to change VTK repo.*Created by: tjcorona*
This commit is in reference to Issue # 4148. The default VTK repository and
tag are now force set and are used as a fallback if
'Slicer_VTKv6_GIT_REPOSITORY' or 'Slicer_VTKv6_GIT_TAG' are not already set in
the pr...*Created by: tjcorona*
This commit is in reference to Issue # 4148. The default VTK repository and
tag are now force set and are used as a fallback if
'Slicer_VTKv6_GIT_REPOSITORY' or 'Slicer_VTKv6_GIT_TAG' are not already set in
the project.
https://gitlab.kitware.com/sjh26/Slicer/-/merge_requests/5352864 simplify crop logic2017-03-14T01:46:43-04:00Sam Horvath2864 simplify crop logic*Created by: jcfr*
*Created by: jcfr*
https://gitlab.kitware.com/sjh26/Slicer/-/merge_requests/618CircleCI Error: `CircleCI does not build changes to Slicer dependencies`2017-02-23T19:57:54-05:00Mayeul ChassagnardCircleCI Error: `CircleCI does not build changes to Slicer dependencies`This error appears when the slicer/slicer-build-deps docker image is not updated with the actual version of slicer.
In order to fix the issue, please create a Pull Request like this one:
https://github.com/thewtex/SlicerDocker/pull...This error appears when the slicer/slicer-build-deps docker image is not updated with the actual version of slicer.
In order to fix the issue, please create a Pull Request like this one:
https://github.com/thewtex/SlicerDocker/pull/21
This will build and push all images based on the newer version of Slicer
CC @thewtex https://gitlab.kitware.com/sjh26/Slicer/-/merge_requests/621Python scripted interface2016-12-16T12:13:29-05:00Sam HorvathPython scripted interface*Created by: vovythevov*
This branch aims to add nice-to-have python methods for scripted modules.
Those methods were typically the kind of method I found myself copy/pasting all over my scripted modules and I think they could be benef...*Created by: vovythevov*
This branch aims to add nice-to-have python methods for scripted modules.
Those methods were typically the kind of method I found myself copy/pasting all over my scripted modules and I think they could be beneficial to the community.https://gitlab.kitware.com/sjh26/Slicer/-/merge_requests/639WIP: TEST: CircleCI Time Kill command2016-12-15T13:32:22-05:00Mayeul ChassagnardWIP: TEST: CircleCI Time Kill commandOnce the Pull Request is done, CircleCI will trigger and launch
kill_time_test.sh which is a simple while true displaying a dot every minutes
and the number of hours elapsed every hour.Once the Pull Request is done, CircleCI will trigger and launch
kill_time_test.sh which is a simple while true displaying a dot every minutes
and the number of hours elapsed every hour.https://gitlab.kitware.com/sjh26/Slicer/-/merge_requests/561WIP: CI: set DISPLAY in CircleCI; check if image updated before re-saving2016-09-20T10:57:32-04:00IsaiahWIP: CI: set DISPLAY in CircleCI; check if image updated before re-savingThis seems to work -- I can't shell in to a running build container itself because CircleCI doesn't support `docker exec`, but launching a new instance does allow to connect to the X server on the host.
For now this hard-codes the defau...This seems to work -- I can't shell in to a running build container itself because CircleCI doesn't support `docker exec`, but launching a new instance does allow to connect to the X server on the host.
For now this hard-codes the default IP address used for the `docker0` bridge and client. We can do a little more work with some awk'ing to get the values dynamically.
Also adds a check for whether `docker pull` actually updated anything, to avoid re-saving the image unnecessarily (saves 3-5 minutes).
Mayeul ChassagnardMayeul Chassagnardhttps://gitlab.kitware.com/sjh26/Slicer/-/merge_requests/530BUG: 2087 - Configuration of vtkSlicerVersionConfigure.cmake.in at bu…2016-06-13T17:58:42-04:00Francois BudinBUG: 2087 - Configuration of vtkSlicerVersionConfigure.cmake.in at bu……ild time.
vtkSlicerVersionConfigure.cmake was build at configuration time. As
reported in bug report 2087 [1], if one updates the source code of Slicer,
this file main not always be updated. This patch configures
vtkSlicerVersionConfig...…ild time.
vtkSlicerVersionConfigure.cmake was build at configuration time. As
reported in bug report 2087 [1], if one updates the source code of Slicer,
this file main not always be updated. This patch configures
vtkSlicerVersionConfigure.cmake at build time instead.
[1] http://na-mic.org/Mantis/view.php?id=2087
https://gitlab.kitware.com/sjh26/Slicer/-/merge_requests/458BUG: change "slicer.util.findChildren" behavior from "or" to "and" filter2016-03-10T13:36:50-05:00Sam HorvathBUG: change "slicer.util.findChildren" behavior from "or" to "and" filter*Created by: jonieva*
*Created by: jonieva*
https://gitlab.kitware.com/sjh26/Slicer/-/merge_requests/328ENH: Create function GetValue()2016-03-03T11:50:39-05:00Sam HorvathENH: Create function GetValue()*Created by: agirault*
Until now vtkMRMLDoubleArrayNode values could only be obtained
using GetXYValue(int, double_, double_), by passing the index
as a copy and the values we want to get as pointers. In python
such a method can not be ...*Created by: agirault*
Until now vtkMRMLDoubleArrayNode values could only be obtained
using GetXYValue(int, double_, double_), by passing the index
as a copy and the values we want to get as pointers. In python
such a method can not be wrapped if it passes pointers.
The function double GetValue(int, int, int&) allows to return
one value by giving its index, and specifying the component
number. The last parameter is a reference to indicate if the
method succeeded or not, so that we can use GetValue() within
GetXYValue(). We also apply more robust conditions on the index
and the component number.
We were interested in creating this method for vtkMRMLDoubleArrayNode
because this node can be used to transfer double vectors between
CLIs and Slicer [1]. The needs we had were :
(1) Getting the returned values in a python module running the CLIs
(2) Being able to get a specified component (not limited to X and Y)
[1] https://github.com/Slicer/Slicer/blob/866900a/Modules/CLI/ExecutionModelTour/ExecutionModelTour.xml#L183-L199
https://gitlab.kitware.com/sjh26/Slicer/-/merge_requests/306STYLE: SimpleMarkupsWidget: Add Markups logic setter/getter.2016-02-22T00:57:15-05:00Sam HorvathSTYLE: SimpleMarkupsWidget: Add Markups logic setter/getter.*Created by: jcfr*
Allow the widget to be used with any given Markups logic
*Created by: jcfr*
Allow the widget to be used with any given Markups logic
https://gitlab.kitware.com/sjh26/Slicer/-/merge_requests/358Two clis in a row issue2016-01-05T14:33:05-05:00Sam HorvathTwo clis in a row issue*Created by: vovythevov*
There is an issue when running the same CLI twice in a row, the second CLI never completes.
This implements a test and a fix.
*Created by: vovythevov*
There is an issue when running the same CLI twice in a row, the second CLI never completes.
This implements a test and a fix.
https://gitlab.kitware.com/sjh26/Slicer/-/merge_requests/432ENH: VolumeRenderingModuleWidget: Extend API adding two new signals:2015-12-11T05:56:43-05:00Davide Punzopunzodavide@hotmail.itENH: VolumeRenderingModuleWidget: Extend API adding two new signals:- newCurrentDisplayNode
- newCurrentMRMLVolumeNode
***\* WIP ****
Why ?
signals to synch the current MRMLVolumeRendeingDisplayNode from the VolumeRenderingModuleWidget to another ModuleWidgets.
if the signal approach is wrong, what ...- newCurrentDisplayNode
- newCurrentMRMLVolumeNode
***\* WIP ****
Why ?
signals to synch the current MRMLVolumeRendeingDisplayNode from the VolumeRenderingModuleWidget to another ModuleWidgets.
if the signal approach is wrong, what about one of these two approaches (using MRML):
1) storing the current VolumeRenderingDisplayNodeID in the vtkMRMLVolumeRenderingScenarioNode.
or
2) storing the current VolumeRenderingDisplayNodeID in the SelectionNode.
Davide.
https://gitlab.kitware.com/sjh26/Slicer/-/merge_requests/356ENH: Built-in module categories are listed separately in modules list2015-10-03T10:05:14-04:00Csaba PinterENH: Built-in module categories are listed separately in modules listModules that are loaded from the Slicer build/install tree are marked as built-in, modules from different folders are not built-in. If a non-built-in module adds a category, then it is shown above the built-in categories, divided by a se...Modules that are loaded from the Slicer build/install tree are marked as built-in, modules from different folders are not built-in. If a non-built-in module adds a category, then it is shown above the built-in categories, divided by a separator.
https://gitlab.kitware.com/sjh26/Slicer/-/merge_requests/329ENH: update DCMTK to use snapshot DCMTK-3.6.1_201509242015-09-29T21:42:26-04:00Sam HorvathENH: update DCMTK to use snapshot DCMTK-3.6.1_20150924*Created by: fedorov*
The important improvements provided by the current DCMTK is the introduction of
dcmiod, dcmfg and dcmseg classes that will be helpful in creating multiframe
DICOM objects, such as segmentation and parametric map ob...*Created by: fedorov*
The important improvements provided by the current DCMTK is the introduction of
dcmiod, dcmfg and dcmseg classes that will be helpful in creating multiframe
DICOM objects, such as segmentation and parametric map objects. This updated
version also includes the feature to embed standard and private DICOM dictionaries.
This makes it unnecessary to use DCMDICTPATH for loading dictionaries from external
file, thus that functionality is removed.