Slicer merge requestshttps://gitlab.kitware.com/sjh26/Slicer/-/merge_requests2015-10-07T16:26:45-04:00https://gitlab.kitware.com/sjh26/Slicer/-/merge_requests/368BUG: Remove codebase for old GrowCut2015-10-07T16:26:45-04:00Hans JohnsonBUG: Remove codebase for old GrowCutRemoved old grow cut based on conversation in:
https://www.na-mic.org/Mantis/view.php?id=2873
This patch set removes code that has been abandoned,
lassoan (developer)
2015-05-07 18:01
Yes, FastGrowCut works well. It may be also an opti...Removed old grow cut based on conversation in:
https://www.na-mic.org/Mantis/view.php?id=2873
This patch set removes code that has been abandoned,
lassoan (developer)
2015-05-07 18:01
Yes, FastGrowCut works well. It may be also an option to retire the
basic GrowCut.
pieper (administrator)
2015-05-07 19:08
Yes, the FastGrowCut developers have been suggesting that we could
retire the old GrowCut - it would be a good project for someone. I
believe they do not give exactly the same answer, so it might be an
option to include both versions and let the user decide which to use
(assuming the crash scenarios are excluded).
https://gitlab.kitware.com/sjh26/Slicer/-/merge_requests/415STYLE: vtkMRMLColorLogic: Improve AddDefaultColorNodes() doxygen2015-11-19T17:16:50-05:00Sam HorvathSTYLE: vtkMRMLColorLogic: Improve AddDefaultColorNodes() doxygen*Created by: jcfr*
The updated doxygen looks like this:
![screenshot from 2015-11-19 17 00 56](https://cloud.githubusercontent.com/assets/219043/11285757/2e20c3a2-8edf-11e5-89be-c3313999aab2.png)
![screenshot from 2015-11-19 17 01 12](...*Created by: jcfr*
The updated doxygen looks like this:
![screenshot from 2015-11-19 17 00 56](https://cloud.githubusercontent.com/assets/219043/11285757/2e20c3a2-8edf-11e5-89be-c3313999aab2.png)
![screenshot from 2015-11-19 17 01 12](https://cloud.githubusercontent.com/assets/219043/11285796/614d80da-8edf-11e5-90f3-6ee042905243.png)
https://gitlab.kitware.com/sjh26/Slicer/-/merge_requests/392BUG: Fix vtkSlicerDoubleArraysLogicAddFileTest2015-10-30T13:06:08-04:00Sam HorvathBUG: Fix vtkSlicerDoubleArraysLogicAddFileTest*Created by: jcfr*
**WIP** DO NOT INTEGRATE
This commit fixes test vtkSlicerDoubleArraysLogicAddFileTest to account
for commit introduced in r24675 (BUG: Fix support for missing labels in
vtkMRMLDoubleArrayStorage reader)
At time of i...*Created by: jcfr*
**WIP** DO NOT INTEGRATE
This commit fixes test vtkSlicerDoubleArraysLogicAddFileTest to account
for commit introduced in r24675 (BUG: Fix support for missing labels in
vtkMRMLDoubleArrayStorage reader)
At time of integration, only the test vtkMRMLDoubleArrayStorageNodeTest1
updated in r24676 (ENH: Add test for vtkMRMLDoubleArrayStorageNode
reader/writer) has been executed to confirm it was working.
Failure reported on the dashboard:
- Linux: http://slicer.cdash.org/testDetails.php?test=6885663&build=700523
- MacOSX: http://slicer.cdash.org/testDetails.php?test=6885265&build=700522
- Windows: http://slicer.cdash.org/testDetails.php?test=6886406&build=700521
https://gitlab.kitware.com/sjh26/Slicer/-/merge_requests/722BUG: Update Volume loading logic to consider default nodes properties2017-05-05T23:55:09-04:00Sam HorvathBUG: Update Volume loading logic to consider default nodes properties*Created by: jcfr*
This commit enables customization of the LabelMapVolumeDisplayNode
attributes by ensuring the custom properties set on the corresponding
default node are effectively re-used.*Created by: jcfr*
This commit enables customization of the LabelMapVolumeDisplayNode
attributes by ensuring the custom properties set on the corresponding
default node are effectively re-used.https://gitlab.kitware.com/sjh26/Slicer/-/merge_requests/458BUG: change "slicer.util.findChildren" behavior from "or" to "and" filter2016-03-10T13:36:50-05:00Sam HorvathBUG: change "slicer.util.findChildren" behavior from "or" to "and" filter*Created by: jonieva*
*Created by: jonieva*
https://gitlab.kitware.com/sjh26/Slicer/-/merge_requests/949BUG: Fix pydicom check when using system python2018-05-25T12:19:48-04:00phcerdanBUG: Fix pydicom check when using system pythonhttps://gitlab.kitware.com/sjh26/Slicer/-/merge_requests/561WIP: CI: set DISPLAY in CircleCI; check if image updated before re-saving2016-09-20T10:57:32-04:00IsaiahWIP: CI: set DISPLAY in CircleCI; check if image updated before re-savingThis seems to work -- I can't shell in to a running build container itself because CircleCI doesn't support `docker exec`, but launching a new instance does allow to connect to the X server on the host.
For now this hard-codes the defau...This seems to work -- I can't shell in to a running build container itself because CircleCI doesn't support `docker exec`, but launching a new instance does allow to connect to the X server on the host.
For now this hard-codes the default IP address used for the `docker0` bridge and client. We can do a little more work with some awk'ing to get the values dynamically.
Also adds a check for whether `docker pull` actually updated anything, to avoid re-saving the image unnecessarily (saves 3-5 minutes).
Mayeul ChassagnardMayeul Chassagnardhttps://gitlab.kitware.com/sjh26/Slicer/-/merge_requests/348ENH: adding more Suffixes in Units2015-09-22T11:49:29-04:00Davide Punzopunzodavide@hotmail.itENH: adding more Suffixes in UnitsHi,
in order to enable proper format for units with more suffixes (see figure below), I'd like to propose the following changes:
1) adding SecondSuffix and ThirdSuffix in MRML, Logic and Qt classes of Units.
2) Overload of GetDisplay...Hi,
in order to enable proper format for units with more suffixes (see figure below), I'd like to propose the following changes:
1) adding SecondSuffix and ThirdSuffix in MRML, Logic and Qt classes of Units.
2) Overload of GetDisplayStringFromValue
3) Overload of GetDisplayStringFromDisplayValueString
![capture](https://cloud.githubusercontent.com/assets/7985338/9981775/b5a65852-5fc6-11e5-953e-44ddf88c9ce2.png)
@pieper, @jcfr and @finetjul may you kindly check the pull request?
Thanks ,
Davide.
https://gitlab.kitware.com/sjh26/Slicer/-/merge_requests/447BUG: Fixed the argument given to FileExists2016-01-19T22:59:53-05:00Sam HorvathBUG: Fixed the argument given to FileExists*Created by: ayamada0614*
The argument for FileExists function was converted from std::string to char type since FileExists requires const char\* argument. I failed to build Slicer application on OS X 10.10.5 by this part.
*Created by: ayamada0614*
The argument for FileExists function was converted from std::string to char type since FileExists requires const char\* argument. I failed to build Slicer application on OS X 10.10.5 by this part.
https://gitlab.kitware.com/sjh26/Slicer/-/merge_requests/329ENH: update DCMTK to use snapshot DCMTK-3.6.1_201509242015-09-29T21:42:26-04:00Sam HorvathENH: update DCMTK to use snapshot DCMTK-3.6.1_20150924*Created by: fedorov*
The important improvements provided by the current DCMTK is the introduction of
dcmiod, dcmfg and dcmseg classes that will be helpful in creating multiframe
DICOM objects, such as segmentation and parametric map ob...*Created by: fedorov*
The important improvements provided by the current DCMTK is the introduction of
dcmiod, dcmfg and dcmseg classes that will be helpful in creating multiframe
DICOM objects, such as segmentation and parametric map objects. This updated
version also includes the feature to embed standard and private DICOM dictionaries.
This makes it unnecessary to use DCMDICTPATH for loading dictionaries from external
file, thus that functionality is removed.
https://gitlab.kitware.com/sjh26/Slicer/-/merge_requests/353ENH:adding DisplayHint attribute in MRML, Logic and Qt of Units2015-09-22T13:51:47-04:00Davide Punzopunzodavide@hotmail.itENH:adding DisplayHint attribute in MRML, Logic and Qt of UnitsImplementation of DisplayHint attribute in MRMLUnitNode classe as discussed in
ENH: adding more Suffixes in Units #348. Plus added also in widgets and logic for user input.
@pieper @jcfr @lassoan
Can you check it, please?
Thanks,
D...Implementation of DisplayHint attribute in MRMLUnitNode classe as discussed in
ENH: adding more Suffixes in Units #348. Plus added also in widgets and logic for user input.
@pieper @jcfr @lassoan
Can you check it, please?
Thanks,
Davide.
https://gitlab.kitware.com/sjh26/Slicer/-/merge_requests/808BUG: fix PlotInfo GUI MarkerComboBox unEnabling for Box type2017-10-16T04:52:45-04:00Davide Punzopunzodavide@hotmail.itBUG: fix PlotInfo GUI MarkerComboBox unEnabling for Box typea very minor fix for the PlotInformation GUI. @jcfr or @lassoan may you merge this as well? Thanks!a very minor fix for the PlotInformation GUI. @jcfr or @lassoan may you merge this as well? Thanks!https://gitlab.kitware.com/sjh26/Slicer/-/merge_requests/432ENH: VolumeRenderingModuleWidget: Extend API adding two new signals:2015-12-11T05:56:43-05:00Davide Punzopunzodavide@hotmail.itENH: VolumeRenderingModuleWidget: Extend API adding two new signals:- newCurrentDisplayNode
- newCurrentMRMLVolumeNode
***\* WIP ****
Why ?
signals to synch the current MRMLVolumeRendeingDisplayNode from the VolumeRenderingModuleWidget to another ModuleWidgets.
if the signal approach is wrong, what ...- newCurrentDisplayNode
- newCurrentMRMLVolumeNode
***\* WIP ****
Why ?
signals to synch the current MRMLVolumeRendeingDisplayNode from the VolumeRenderingModuleWidget to another ModuleWidgets.
if the signal approach is wrong, what about one of these two approaches (using MRML):
1) storing the current VolumeRenderingDisplayNodeID in the vtkMRMLVolumeRenderingScenarioNode.
or
2) storing the current VolumeRenderingDisplayNodeID in the SelectionNode.
Davide.
https://gitlab.kitware.com/sjh26/Slicer/-/merge_requests/566Json cpp support2016-09-09T18:05:02-04:00Sam HorvathJson cpp support*Created by: vovythevov*
This is the first step in the integration of the Parameter Serializer in Slicer.
JsonCpp support is off by default.
*Created by: vovythevov*
This is the first step in the integration of the Parameter Serializer in Slicer.
JsonCpp support is off by default.
https://gitlab.kitware.com/sjh26/Slicer/-/merge_requests/648WIP: Support qt52017-04-07T20:28:37-04:00Sam HorvathWIP: Support qt5*Created by: jcfr*
This topic allows to compile Slicer against either Qt4 or Qt5.
* It supports version of Qt5 with/without webkit support.
* It was tested on Ubuntu with **CMake >= 3.4.2**
* When building with Qt5, a library named...*Created by: jcfr*
This topic allows to compile Slicer against either Qt4 or Qt5.
* It supports version of Qt5 with/without webkit support.
* It was tested on Ubuntu with **CMake >= 3.4.2**
* When building with Qt5, a library named `Slicer/Libs/qtstyleplugins/` it basically includes the `QCleanlooksStyle` classes that were removed from Qt5 core. See http://code.qt.io/cgit/qt/qtstyleplugins.git/ and http://blog.qt.io/blog/2012/10/30/cleaning-up-styles-in-qt5-and-adding-fusion/
### How to configure Slicer with Qt5 ?
If not installed on your system, you should specify the option `-DQt5_DIR` (e.g `-DQt5_DIR:PATH=/home/jcfr/Software/Qt5.7.1/5.7/gcc_64/lib/cmake/Qt5`)
### Missing:
See https://www.slicer.org/wiki/Documentation/Labs/Qt5#To_Do_List
### Known issues:
See https://www.slicer.org/wiki/Documentation/Labs/Qt5#Known_Issues
### Update to dependent projects:
* CTK
* DataStore
* EMSegment
* MultiVolumeExporter
* OpenIGTLinkIFhttps://gitlab.kitware.com/sjh26/Slicer/-/merge_requests/411BUG: Enable high-resolution screenshots of slice views2017-10-15T00:37:13-04:00Sam HorvathBUG: Enable high-resolution screenshots of slice views*Created by: msmolens*
This commit enables rendering high-resolution screenshots of the slice views.
Previously the screenshots were scaled and interpolated after being captured at
screen resolution.
Alternative attempts to render thes...*Created by: msmolens*
This commit enables rendering high-resolution screenshots of the slice views.
Previously the screenshots were scaled and interpolated after being captured at
screen resolution.
Alternative attempts to render these screenshots, using vtkRenderLargeImage or
vtkWindowToImageFilter without offscreen rendering, resulted in incorrect
rendering of one or more of: the slice image, the annotations (ruler,
orientation marker, etc.), or lightbox mode.
Open issues are:
- Some text doesn't scale in the high-resolution screenshot (corner annotation,
ruler measurement, orientation marker labels)
- Ruler height is fixed
On Windows this depends on offscreen rendering fixes in
vtkWin32OpenGLRenderWindow: https://gitlab.kitware.com/vtk/vtk/merge_requests/992
Fixes #3885
Co-authored-by: Alexis Girault alexis.girault@kitware.com