1. 31 May, 2016 12 commits
  2. 30 May, 2016 1 commit
  3. 26 May, 2016 3 commits
  4. 25 May, 2016 1 commit
  5. 24 May, 2016 1 commit
    • naucoin's avatar
      COMP: fix illegal character compiler warning · 33d2a396
      naucoin authored
      Change invalid character to an apostrophe in Tables module acknowledgement text.
      
      Fixes the following compiler warning:
      Slicer/Modules/Loadable/Tables/qSlicerTablesModule.cxx:95:187: warning: illegal character encoding in string literal [-Winvalid-source-encoding]
        ...funded by OCAIRO, the Applied Cancer Research Unit program of Cancer Care Ontario, and Department of Anesthesia and Critical Care Medicine, Children<92>s Hospital of Philadelphia.";
      
      
      
      git-svn-id: http://svn.slicer.org/Slicer4/trunk@25118 3bd1e089-480b-0410-8dfb-8563597acbee
      33d2a396
  6. 23 May, 2016 10 commits
  7. 21 May, 2016 8 commits
    • pinter's avatar
      COMP: Fixed build error on windows · 877a086a
      pinter authored
      Standard output did not accept const string with the << operator:
      http://slicer.cdash.org/viewBuildError.php?buildid=831173
      If my fix of choice is not satisfactory, please feel free to override.
      
      git-svn-id: http://svn.slicer.org/Slicer4/trunk@25107 3bd1e089-480b-0410-8dfb-8563597acbee
      877a086a
    • pieper's avatar
      BUG: #4191 back out optimization that broke tests · 7a1d7300
      pieper authored
      https://github.com/Slicer/Slicer/pull/505
      
      From: Steve Pieper <pieper@isomics.com>
      
      git-svn-id: http://svn.slicer.org/Slicer4/trunk@25106 3bd1e089-480b-0410-8dfb-8563597acbee
      7a1d7300
    • lassoan's avatar
      BUG: Fixed crash in vtkNRRDReader when attepting to read a 4D spatial file · 14a9c5ca
      lassoan authored
      Problem was that when scalar type was not supported, target memory area pointer for memcpy remained NULL.
      Also reduced the number of cases when CanReadFile returns true but the reader cannot actually read the file.
      
      The reader was really messy, so cleaned it up (smart pointers, variable definitions, formatting, etc), without any functional changes.
      
      git-svn-id: http://svn.slicer.org/Slicer4/trunk@25105 3bd1e089-480b-0410-8dfb-8563597acbee
      14a9c5ca
    • jcfr's avatar
      PERF: Reduce startup time by lazily loading Welcome module HTML. Fixes #4198 · 9cf170a4
      jcfr authored
      This commit reduces startup time by ~30% (5.5s -> 3.9s).
      
      Results obtained for a release build on Ubuntu 15.10, 64GB/M.2 PCIe
      NVMe SSD/Quad Core 3.80GHz.
      
      While loading the Welcome module is still  slower (~10ms), the improvement
      is significant.
      
      
      Details Stats:
      
      
      Notes: MeasureStartupTimes.py has been locally modified to avoid generating
      Modules.json. Modules.json has been updated to list only 4 modules.
      
      
      $ ~/Projects/Slicer/Applications/SlicerApp/Testing/Python/MeasureStartupTimes.py --excluding-one-module -n5 ./Slicer
      
      [1/4]
      Slicer --no-splash --exit-after-startup --testing --modules-to-ignore EventBroker
      1/5: 3.81s
      Slicer --no-splash --exit-after-startup --testing --modules-to-ignore EventBroker
      2/5: 3.81s
      Slicer --no-splash --exit-after-startup --testing --modules-to-ignore EventBroker
      3/5: 3.79s
      Slicer --no-splash --exit-after-startup --testing --modules-to-ignore EventBroker
      4/5: 3.82s
      Slicer --no-splash --exit-after-startup --testing --modules-to-ignore EventBroker
      5/5: 3.84s
      Average: 3.81s
      
      [2/4]
      Slicer --no-splash --exit-after-startup --testing --modules-to-ignore GradientAnisotropicDiffusion
      1/5: 3.84s
      Slicer --no-splash --exit-after-startup --testing --modules-to-ignore GradientAnisotropicDiffusion
      2/5: 3.83s
      Slicer --no-splash --exit-after-startup --testing --modules-to-ignore GradientAnisotropicDiffusion
      3/5: 3.83s
      Slicer --no-splash --exit-after-startup --testing --modules-to-ignore GradientAnisotropicDiffusion
      4/5: 3.75s
      Slicer --no-splash --exit-after-startup --testing --modules-to-ignore GradientAnisotropicDiffusion
      5/5: 3.85s
      Average: 3.82s
      
      [3/4]
      Slicer --no-splash --exit-after-startup --testing --modules-to-ignore Welcome
      1/5: 3.70s
      Slicer --no-splash --exit-after-startup --testing --modules-to-ignore Welcome
      2/5: 3.75s
      Slicer --no-splash --exit-after-startup --testing --modules-to-ignore Welcome
      3/5: 3.73s
      Slicer --no-splash --exit-after-startup --testing --modules-to-ignore Welcome
      4/5: 3.76s
      Slicer --no-splash --exit-after-startup --testing --modules-to-ignore Welcome
      5/5: 3.68s
      Average: 3.72s
      
      [4/4]
      Slicer --no-splash --exit-after-startup --testing --modules-to-ignore CompareVolumes
      1/5: 3.78s
      Slicer --no-splash --exit-after-startup --testing --modules-to-ignore CompareVolumes
      2/5: 3.78s
      Slicer --no-splash --exit-after-startup --testing --modules-to-ignore CompareVolumes
      3/5: 3.80s
      Slicer --no-splash --exit-after-startup --testing --modules-to-ignore CompareVolumes
      4/5: 3.82s
      Slicer --no-splash --exit-after-startup --testing --modules-to-ignore CompareVolumes
      5/5: 3.76s
      Average: 3.79s
      
      git-svn-id: http://svn.slicer.org/Slicer4/trunk@25104 3bd1e089-480b-0410-8dfb-8563597acbee
      9cf170a4
    • jcfr's avatar
      ENH: Improve MeasureStartupTimes script adding "--repeat" argument · e4c49494
      jcfr authored
      timecall decorator learned how to repeat a run and compute the average time
      across all runs.
      
      git-svn-id: http://svn.slicer.org/Slicer4/trunk@25103 3bd1e089-480b-0410-8dfb-8563597acbee
      e4c49494
    • jcfr's avatar
      a1151ccb
    • jcfr's avatar
      ENH: Improve MeasureStartupTimes script · f14ba786
      jcfr authored
      collect_startup_times_overall:
      
       * Move existing code into "collect_startup_times_overall" function and
         save stats to a json file "StartupTimes.json" to facilitate analysis.
      
      collect_startup_times_excluding_one_module:
      
       * Added "collect_startup_times_excluding_one_module" starting Slicer N
         times excluding each one of the N modules one by one. Stats are
         then saved to "StartupTimesExcludingOneModule.json".
      
       * List of module names (and their type) is also saved to "Modules.json"
      
       * This allows to check if there are modules impacting the startup
         time more than the average.
      
      git-svn-id: http://svn.slicer.org/Slicer4/trunk@25101 3bd1e089-480b-0410-8dfb-8563597acbee
      f14ba786
    • jcfr's avatar
      BUG: Fix regression: python code "exit(status)" will now exit with "status" · acd8220e
      jcfr authored
      This commit fixes py_nomainwindow_SlicerPythonCodeTest2 fixing a regression
      introduced in r25083 (STYLE: Automatically enable "ignore-slicerrc" if
      "testing" option is given).
      
      Associating the test with "--testing" option was causing the application
      to always exit with EXIT_SUCCESS when "exit(EXIT_FAILURE)" was called.
      
      This commit ensures the all to slicer.app.exit() in "slicer.util.exit()"
      is considered.
      
      git-svn-id: http://svn.slicer.org/Slicer4/trunk@25100 3bd1e089-480b-0410-8dfb-8563597acbee
      acd8220e
  8. 20 May, 2016 4 commits