1. 17 Apr, 2018 1 commit
    • lassoan's avatar
      ENH: Added new volume rendering quality option: Normal · e94653c8
      lassoan authored
      SetLockSampleDistanceToInputSpacing usually provides good quality rendering at acceptable speed, but on slow computers or in virtual reality views (where very high frame rate is needed), it is still necessary to allow choose between volume rendering speed and quality.
      
      Added a new option to clearly distinguish between quality settings:
      - adaptive: sampling computed from desired fps
      - normal: sampling computed from input volume
      - maximum quality: sampling computed from input volume, with 10x oversampling
      
      git-svn-id: http://svn.slicer.org/Slicer4/trunk@27153 3bd1e089-480b-0410-8dfb-8563597acbee
      e94653c8
  2. 16 Apr, 2018 3 commits
  3. 14 Apr, 2018 2 commits
  4. 13 Apr, 2018 2 commits
  5. 11 Apr, 2018 6 commits
  6. 10 Apr, 2018 6 commits
    • lassoan's avatar
      BUG: Fixed qMRMLLayoutManagerVisibilityTest · 010f74fc
      lassoan authored
      Crashed on exit due to known issue with Qt web widget.
      
      Fixed by creating and using safeApplicationQuit() function that can shutdown the application without crashing.
      
      git-svn-id: http://svn.slicer.org/Slicer4/trunk@27139 3bd1e089-480b-0410-8dfb-8563597acbee
      010f74fc
    • lassoan's avatar
      BUG: Updated to latest SimpleFilters version · 128c758a
      lassoan authored
      Fixes crash in Simple Filters module when filter GUI contains coordinates widget.
      Also fixes py_SimpleFiltersModuleTest test failure on the dashboard.
      
      git-svn-id: http://svn.slicer.org/Slicer4/trunk@27138 3bd1e089-480b-0410-8dfb-8563597acbee
      128c758a
    • lassoan's avatar
      BUG: Fixed py_NeurosurgicalPlanningTutorialMarkupsSelfTest · 5def3dee
      lassoan authored
      There was an error in running one of the Editor effects.
      Instead of trying to fix the problem using the legacy Editor, upgraded the test to use Segment Editor instead.
      
      git-svn-id: http://svn.slicer.org/Slicer4/trunk@27137 3bd1e089-480b-0410-8dfb-8563597acbee
      5def3dee
    • pieper's avatar
      COMP: fix typo in linux tbb path · 61d31042
      pieper authored
      An extra asterisk prevented the build from working.
      
      From: Steve Pieper <pieper@isomics.com>
      
      git-svn-id: http://svn.slicer.org/Slicer4/trunk@27136 3bd1e089-480b-0410-8dfb-8563597acbee
      61d31042
    • pieper's avatar
      COMP: fix TBB lib paths for linux and max · 4ad71ad3
      pieper authored
      Adds prefix so e.g. ttb_debug becomes libtbb_debug
      to match the platform conventions.
      
      From: Steve Pieper <pieper@isomics.com>
      
      git-svn-id: http://svn.slicer.org/Slicer4/trunk@27135 3bd1e089-480b-0410-8dfb-8563597acbee
      4ad71ad3
    • pieper's avatar
      COMP: add missing vtkNew header for Qt4 build · 6ead2fd8
      pieper authored
      Fixes this build error for qt4 builds (happened on both
      linux and mac builds).
      
          [ 25%] Building CXX object Libs/MRML/DisplayableManager/CMakeFiles/MRMLDisplayableManager.dir/vtkMRMLAbstractSliceViewDisplayableManager.cxx.o
          /Users/pieper/slicer4/latest/Slicer/Libs/MRML/DisplayableManager/vtkMRMLAbstractSliceViewDisplayableManager.cxx:124:3: error: use of undeclared identifier 'vtkNew'
            vtkNew<vtkMatrix4x4> rasToXYZ;
            ^
          /Users/pieper/slicer4/latest/Slicer/Libs/MRML/DisplayableManager/vtkMRMLAbstractSliceViewDisplayableManager.cxx:124:10: error: 'vtkMatrix4x4' does not refer to a value
            vtkNew<vtkMatrix4x4> rasToXYZ;
                   ^
          /Users/pieper/slicer4/latest/Slicer-superbuild/VTKv9/Rendering/Core/vtkProp.h:33:7: note: declared here
          class vtkMatrix4x4;
                ^
          /Users/pieper/slicer4/latest/Slicer/Libs/MRML/DisplayableManager/vtkMRMLAbstractSliceViewDisplayableManager.cxx:124:24: error: use of undeclared identifier 'rasToXYZ'
            vtkNew<vtkMatrix4x4> rasToXYZ;
                                 ^
          /Users/pieper/slicer4/latest/Slicer/Libs/MRML/DisplayableManager/vtkMRMLAbstractSliceViewDisplayableManager.cxx:125:49: error: use of undeclared identifier 'rasToXYZ'
      
      From: Steve Pieper <pieper@isomics.com>
      
      git-svn-id: http://svn.slicer.org/Slicer4/trunk@27134 3bd1e089-480b-0410-8dfb-8563597acbee
      6ead2fd8
  7. 09 Apr, 2018 2 commits
    • lassoan's avatar
      COMP: Fixed test errors occurring when slicerrc file was present · ace77a3b
      lassoan authored
      When .slicerrc file is specified on a computer and running tests, some failures occurred when Slicer was started using --disable-modules option (.slicerrc file tried to load data that required some modules).
      
      Fixed the issue by always adding --ignore-slicerrc when module loading is disabled.
      
      git-svn-id: http://svn.slicer.org/Slicer4/trunk@27133 3bd1e089-480b-0410-8dfb-8563597acbee
      ace77a3b
    • lassoan's avatar
      ENH: Added option to use TBB as SMP backend in VTK · e44903fb
      lassoan authored
      TBB (Threading Building Blocks) provides tools for writing parallel C++ programs. VTK can use TBB to improve efficiency of execution of many filters.
      
      Using TBB over default multi-threading (Sequential), multi-threaded image filter execution is typically improved by 20-30%. In cases where many threads are created (e.g., pipeline updates performed 10-100 per second, on an 8 or more core machine) and the computation load is very small, the speed may be improved by a factor of 10-20x. On some systems image reslicing performance is increased from 10fps to 130fps by switching from Sequential to TBB.
      
      TBB is now enabled by default on Windows. Slicer with TBB has not been tested on Linux and MacOSX yet (probably building and packaging need some fixes).
      
      git-svn-id: http://svn.slicer.org/Slicer4/trunk@27132 3bd1e089-480b-0410-8dfb-8563597acbee
      e44903fb
  8. 06 Apr, 2018 1 commit
  9. 05 Apr, 2018 2 commits
  10. 04 Apr, 2018 1 commit
  11. 03 Apr, 2018 2 commits
  12. 01 Apr, 2018 1 commit
  13. 31 Mar, 2018 3 commits
  14. 30 Mar, 2018 8 commits
    • jcfr's avatar
      COMP: StorageNode/SegmentationModuleLogic: Fix compilation against Qt4 · 0efdac69
      jcfr authored
      This commit excludes the code integrated in r27107 (ENH: Write coordinate
      system name into OBJ file header). These methods are available only when
      compiling against VTK9 >= kitware/VTK@0f8cf03.
      
      See https://discourse.slicer.org/t/slicer-nightly-build-error-with-vtk/2482
      
      git-svn-id: http://svn.slicer.org/Slicer4/trunk@27121 3bd1e089-480b-0410-8dfb-8563597acbee
      0efdac69
    • lassoan's avatar
      ENH: Always set segmentation nrrd file vector axis to "list" kind · a5cb03fe
      lassoan authored
      When only a few segments were in the segmentation then axis kind was set to complex, RGB, RGBA, ..., which was not meaningful and caused some nrrd readers to fail to read the image (see this discussion for an example https://discourse.itk.org/t/reading-segmentation-file-from-slicer-nrrd-with-multiple-segments-with-simpleitk-shows-exception/808/14).
      
      Solution: non-spatial axis kind is always set to "list".
      
      git-svn-id: http://svn.slicer.org/Slicer4/trunk@27120 3bd1e089-480b-0410-8dfb-8563597acbee
      a5cb03fe
    • jcfr's avatar
      COMP: Update python to fix linuxaudiodev build error · 23720d28
      jcfr authored
      This commit fixes the version handling and prevents the flag -std=c99
      from being used. See python-cmake-buildsystem/python-cmake-buildsystem@3e00b46
      and python-cmake-buildsystem/python-cmake-buildsystem@5530813
      
      It fixes error like this one:
      
        linuxaudiodev.c:69:17: error: ‘AFMT_MU_LAW’ undeclared here (not in a function)
           {  8,       AFMT_MU_LAW, "logarithmic mu-law 8-bit audio" },
      
      
      List of changes:
      
      $ git shortlog 3e0e336..16d41fe --no-merges
      Jean-Christophe Fillion-Robin (2):
            cmake: Use PY_VERSION instead of PYTHON_VERSION
            cmake: Ensure PYTHON_VERSION cache variable is up-to-date
      
      git-svn-id: http://svn.slicer.org/Slicer4/trunk@27119 3bd1e089-480b-0410-8dfb-8563597acbee
      23720d28
    • jcfr's avatar
      COMP: Fix install of python (at build time) on system without python installed · 72ae807d
      jcfr authored
      Highlighted list of changes
      ---------------------------
      
      python-cmake-buildsystem/python-cmake-buildsystem@fe078f9:
        Fix install on system without python already on the system
      
          This commit ensures the Grammar generation (current happening at install
          time) can complete no system without python already installed on the system.
      
          It fixes error like the following:
      
          -- Up-to-date: /work/Preview/Slicer-0-build/python-install/include/python2.7/pyconfig.h
          /path/to/python-install/bin/python: error while loading shared libraries: libpython2.7.so: cannot open shared object file: No such file or directory
          /path/to/python-install/bin/python: error while loading shared libraries: libpython2.7.so: cannot open shared object file: No such file or directory
      
        Slicer: Fix build using "qt5-centos7" environment. See https://github.com/Slicer/SlicerBuildEnvironment
                This issue was discovered while trying to build Slicer using the build
                environment "qt5-centos7" that doesn't come with python2 pre-installed
      
      
      topic support-3.5-and-3.6 adding support for building python3.x
      
        Slicer: This is one of the step that will allow to build
                Slicer against python 3.5 or Python 3.6
      
      
      
      Complete list of changes
      ------------------------
      $ git shortlog f55f8db..3e0e336 --no-merges
      Jean-Christophe Fillion-Robin (28):
            cmake: Accept configuring against any python version
            cmake: Support downloading Python 2.7.14
            cmake: Support downloading Python 3.5.3 to 3.5.5, and 3.6.0 to 3.6.4
            PythonApplyPatches: Use git executable it found, and check for older version of patch
            patches: Support building python 3.6.x on windows with BUILD_EXTENSIONS_AS_BUILTIN ON
            cmake: Update default python version from 3.5.2 to 3.6.4
            ConfigureChecks: Add a specific configure check for sys/random.h
            ConfigureChecks: Include sys/sysmacros.h
            Extensions: Support building CPython including new version of libexpat
            ConfigureChecks: Fix setting of HAVE_GETPRIORITY
            ConfigureChecks: Enable HAVE_COMPUTED_GOTOS test with Python 2.7
            appveyor: Build Python 2.7.14 with VS2013/VS2015 in 32-bit
            patches: Use patches for 2.7.13 with all version >= 2.7.13
            PythonApplyPatches: Fix whitespaces when applying patch with git
            PythonApplyPatches: Ensure patches are always checked out using LF line ending
            PythonApplyPatches: Ensure "git apply" works if source in already versioned tree
            cmake: Add "-std=c99" flag
            cmake/python: Update name of sysconfigdata to support Python >= 3.6
            cmake: Add "-std=c99" flag only if PYTHON_VERSION >= 3.6
            patches: 2.7.3 to 2.7.6: Fix build with GNU readline >= 6.3
            python3/extension_io: Include "winconsoleio.c" introduced in Python 3.6
            python3: Associate MS_DLL_ID definition with dl_nt.c (introduced in python 3.5)
            python3/sysmodule: Link against "version.lib"
            python3/getpathp: Fix Python3.6 link error adding "shlwapi.lib" dependency
            cmake/pyconfig: Set HAVE_RL_RESIZE_TERMINAL
            patches: 2.7.3 to 2.7.6: Fix build with GNU readline >= 6.3 on macOS
            python3: Fix link error by improving generation of python3stub.def
            Fix install on system without python already on the system
      
      Marcel Metz (1):
            PythonApplyPatches: Use upper & lowercase *_FOUND vars when locating git & patch
      
      git-svn-id: http://svn.slicer.org/Slicer4/trunk@27118 3bd1e089-480b-0410-8dfb-8563597acbee
      72ae807d
    • jcfr's avatar
      ENH: Update ExternalProjectDependency system based on commontk/Artichoke@9c98004 · 45855ab1
      jcfr authored
      Add support for CMAKE_JOB_* variables. This should help limit the overall
      number of link job on service like CircleCI.
      
      See https://discourse.slicer.org/t/ninja-build-using-too-many-cores/2304
      
      List of CTK changes:
      
      $ git shortlog 550eef7..1e70c97 --no-merges
      Jean-Christophe Fillion-Robin (1):
            ENH: Update ExternalProjectDependency system based on commontk/Artichoke@9c98004
      
      git-svn-id: http://svn.slicer.org/Slicer4/trunk@27117 3bd1e089-480b-0410-8dfb-8563597acbee
      45855ab1
    • jcfr's avatar
      COMP: Fix DCMTK external project warning by removing extra quotes · 0b902eaf
      jcfr authored
      This commit fixes the following warning introduced by r27114 (STYLE: Update
      ExternalProject to consistently handle CMAKE_[CACHE_]ARGS)
      
        loading initial cache file /Volumes/Dashboards/Preview/Slicer-0-build/DCMTK-prefix/tmp/DCMTK-cache-Release.cmake
        CMake Warning (dev) at /Volumes/Dashboards/Preview/Slicer-0-build/DCMTK-prefix/tmp/DCMTK-cache-Release.cmake:82:
          Syntax Warning in cmake code at column 35
      
          Argument not separated from preceding token by whitespace.
        This warning is for project developers.  Use -Wno-dev to suppress it
      
      git-svn-id: http://svn.slicer.org/Slicer4/trunk@27116 3bd1e089-480b-0410-8dfb-8563597acbee
      0b902eaf
    • jcfr's avatar
      STYLE: Update curl ExternalProject to consistently handle CMAKE_ARGS · f94c5315
      jcfr authored
      git-svn-id: http://svn.slicer.org/Slicer4/trunk@27115 3bd1e089-480b-0410-8dfb-8563597acbee
      f94c5315
    • jcfr's avatar
      STYLE: Update ExternalProject to consistently handle CMAKE_[CACHE_]ARGS · 2bf0e4ac
      jcfr authored
      git-svn-id: http://svn.slicer.org/Slicer4/trunk@27114 3bd1e089-480b-0410-8dfb-8563597acbee
      2bf0e4ac