GitLab

To ensure existing tests pass, the Cxx folder has been added to the list
of sub dirs to consider when looking up IntDir.

That said, the recommended solution is to set the target property
RUNTIME_OUTPUT_DIRECTORY for the test executable. The value of this property
should be ${CMAKE_BINARY_DIR}/${Slicer_BIN_DIR}

See http://na-mic.org/Mantis/view.php?id=2348

Fixes #2348

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21200 3bd1e089-480b-0410-8dfb-8563597acbee

This is commit improve the url encoding of parameter for sake of completeness
only. It doesn't fix the problem.

It resumes that URL passed as parameter to the midas api can't have any
ampersand. Indeed, the value following the ampersand will be considered
as a parameter of the API call itself.

See #2643 / http://www.na-mic.org/Bug/view.php?id=2643

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21199 3bd1e089-480b-0410-8dfb-8563597acbee

Fixed range of rotation sliders to -180,180.
Range of rotation sliders not affected by OnMRMLTransformNodeModified
event.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21198 3bd1e089-480b-0410-8dfb-8563597acbee

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21197 3bd1e089-480b-0410-8dfb-8563597acbee

This is a follow-up of commit r21186. It explains why "SetAndObserveInteractor"
has to be called after calling "AdditionalInitializeStep".

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21196 3bd1e089-480b-0410-8dfb-8563597acbee

Also update the test to be more helpful in diagnosing.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21195 3bd1e089-480b-0410-8dfb-8563597acbee

A and 0 were being incorrectly percent encoded.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21194 3bd1e089-480b-0410-8dfb-8563597acbee

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21193 3bd1e089-480b-0410-8dfb-8563597acbee

It prevent Slicer from being built on some linux system.

See http://www.na-mic.org/Bug/view.php?id=2633

Fixes #2633

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21192 3bd1e089-480b-0410-8dfb-8563597acbee

It will fix the following error:

error: invalid Python installation: unable to open /home/jchris/Projects/Slicer4-Superbuild-Debug/Slicer-build/_CPack_Packages/linux-amd64/TGZ/Slicer-4.1.0-2012-10-15-linux-amd64/lib/Python/include/python2.6/pyconfig.h (No such file or directory)
Something went wrong during the installation.

occurring when install distribute applying the following steps:

1) curl -O http://python-distribute.org/distribute_setup.py
2) ./Slicer --launch /usr/bin/python2.6 distribute_setup.py

Note: A different error occurs when "distribute_setup.py" is executed
directly using Slicer executable:

Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "setup.py", line 8, in <module>
    os.chdir(os.path.dirname(os.path.abspath(__file__)))
NameError: name '__file__' is not defined

This is tracked by issue #2649

See http://www.na-mic.org/Bug/view.php?id=2636

Fixes #2636

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21191 3bd1e089-480b-0410-8dfb-8563597acbee

See http://www.na-mic.org/Bug/view.php?id=2641

Fixes #2461

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21190 3bd1e089-480b-0410-8dfb-8563597acbee

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21189 3bd1e089-480b-0410-8dfb-8563597acbee

Note that this is a sub-optimal solution, ideally parameter to the ctest
script should be passed either configuring a file and passing the path
to that file or using the -D syntax supported in recent version of
ctest (>= 2.8.9).

See http://www.na-mic.org/Bug/view.php?id=2643

Fixes #2643

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21188 3bd1e089-480b-0410-8dfb-8563597acbee

When using Crosshair in cross-referencing mode (as opposed to navigator mode) and
using Shift-MouseMove to jump the slices, the crosshair on the other slices would
sometimes disappear or blink.

This is caused by the crosshair being turned off when it is not on the current slice.

The crosshair was not always on the current slice because the CrosshairDisplayableManager
could receive the MouseMove event BEFORE the InteractorStyle (which handles the jump slice
behavior).  Hence the crosshair was built for one slice but since the slicenode had not been
updated, it wasn't on the slice being display (yet) and was turned off.

Set the priority of the MouseMoveEvent to -1 for the CrosshairDisplayableManager so that
the InteractorStyle receives the event first, which allows the slice to jump to the proper
RAS before the crosshair is drawn.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21187 3bd1e089-480b-0410-8dfb-8563597acbee

BUG: r21160 fixed crosshairs but broke 3D viewer. r21165 fixed 3D viewer but brok crosshairs. This patch fixes both.

Moved the code introduced in r21165 down a few lines.

If the interactor is cached earlier, then the events registered in
AdditionalInitializationStep() don't get observed (which the Crosshairs depend
on).

I don't understand why moving the lines fixes the issue.  In both r21165 and
in this patch, the events added in AdditionalInitializeStep() are only cached
locally and are not actually assigned to the interactor at that time.

But there must be some observer side effect that by observing the interactor,
another event is triggered, which causes the events/observers to be lost.
Perhaps another interactor gets puts in place? Or not in place?

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21186 3bd1e089-480b-0410-8dfb-8563597acbee

ENH: the test is simplified: the crash happens trying to quit Slicer after initializing the node selectors in the first step of the wizard (see issue #2590)


git-svn-id: http://svn.slicer.org/Slicer4/trunk@21185 3bd1e089-480b-0410-8dfb-8563597acbee

Since data bundles must sometimes make filenames on-the-fly
based on the node names, add a step to ensure filenames
do not contain special characters (like colon or slash).

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21184 3bd1e089-480b-0410-8dfb-8563597acbee

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21183 3bd1e089-480b-0410-8dfb-8563597acbee

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21182 3bd1e089-480b-0410-8dfb-8563597acbee

By moving the displayable managers into their own library,
it is then possible for modules to use and link to it.
The Annotations VTKWidgets had to be moved as well.

Issue #2606

Conflicts:
	Modules/Loadable/Annotations/CMakeLists.txt

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21181 3bd1e089-480b-0410-8dfb-8563597acbee

Unused variable for vtkMRMLModelSliceDisplayableManagerTest
Automatic cast for vtkMRMLFreeSurferModelOverlayStorageNode

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21180 3bd1e089-480b-0410-8dfb-8563597acbee

It can then be used when designing your module with Qt Designer

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21179 3bd1e089-480b-0410-8dfb-8563597acbee

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21178 3bd1e089-480b-0410-8dfb-8563597acbee

The python unittest framework considers any test* method to be
a test and calls it with no arguments.  By renaming the helper
method to be perform_ rather than test_ we let the test
succeed.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21177 3bd1e089-480b-0410-8dfb-8563597acbee

The layout node in the layout logic was not cleared when a scene
was restored, which meant that it was out of date with respect
to the current scene and led to a crash.  Now we explicitly unreference
it when a scene restore begins and then re-access it after
the scene has been restored.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21176 3bd1e089-480b-0410-8dfb-8563597acbee

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21175 3bd1e089-480b-0410-8dfb-8563597acbee

Make sure the widgets exist before updating the layout.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21174 3bd1e089-480b-0410-8dfb-8563597acbee

Make sure qt has had time to process events before teardown of the
userinterface - otherwise pythonqt may hold references to QStandardItem
instances (and perhaps other objects) that Qt has destroyed.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21173 3bd1e089-480b-0410-8dfb-8563597acbee

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21172 3bd1e089-480b-0410-8dfb-8563597acbee

Use the specific methods for node added and remove events rather
than the generic modified events. This avoids creating/destroying
Qt classes while the scene is being torn down and avoids a
crash in the ThresholdThreading test.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21171 3bd1e089-480b-0410-8dfb-8563597acbee

The intensity image is assigned to the first input on the
vtkITKGrowCutImageFilter which forces the output segmentation
image to have the same pixel type.  But the output segmetentation
is assumed at the ITK level to be same pixel type as the gesture
image.

Overrode ExecuteInformation() so information from the second
input is propagated to the output image, so the gesture image
and output segmentation image have the same pixel type.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21170 3bd1e089-480b-0410-8dfb-8563597acbee

See http://slicer-devel.65872.n3.nabble.com/Build-error-in-SlicerRT-extension-cannot-open-input-file-qSlicerBaseQTCLIPythonD-lib-tc4026390.html

Thanks to Csaba for reporting the issue.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21169 3bd1e089-480b-0410-8dfb-8563597acbee

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21168 3bd1e089-480b-0410-8dfb-8563597acbee

The linker ld for OSX does not have --as-needed and --no-as-needed
flags.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21167 3bd1e089-480b-0410-8dfb-8563597acbee

Because the ctk range widget rounds the values for display, it
can have the effect of truncating the values such that the
selected range does not include the highest
value(s) in the volume.  Adding 1 to the max value avoids this
problem with no anticipated downsides.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21166 3bd1e089-480b-0410-8dfb-8563597acbee

The problem is that Interactor member is not initialized for Displayable
manager that don't have at list on Interactor event to observe.

Before the change, the interactor was returned using
GetRenderWindow()->GetInteractor()

After the change, this->Interactor is returned.

This commit ensures that Interactor variable is set when the Render
is also set.

See https://github.com/Slicer/Slicer/commit/1264dac8ca9aaeba54627b8f8a37333c0f5f8a49#L0R648

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21165 3bd1e089-480b-0410-8dfb-8563597acbee

Delete the old testing settings file and creates a new one for current
testing.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21164 3bd1e089-480b-0410-8dfb-8563597acbee

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21163 3bd1e089-480b-0410-8dfb-8563597acbee

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21162 3bd1e089-480b-0410-8dfb-8563597acbee

git-svn-id: http://svn.slicer.org/Slicer4/trunk@21161 3bd1e089-480b-0410-8dfb-8563597acbee