GitLab

git-svn-id: http://svn.slicer.org/Slicer4/trunk@14219 3bd1e089-480b-0410-8dfb-8563597acbee

Ultimately, all logic should have such method. That way, the events
that  the MRMLScene should listen are set by the logic class itself
and not by their client.

Testing will also be simplified.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@14218 3bd1e089-480b-0410-8dfb-8563597acbee

git-svn-id: http://svn.slicer.org/Slicer4/trunk@14217 3bd1e089-480b-0410-8dfb-8563597acbee

Also changed the signature of FitSliceToBackground to have width/height
optional.

If width/height are not passed to FitSliceToBackground, the value set
using SetSliceViewSize will be used.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@14216 3bd1e089-480b-0410-8dfb-8563597acbee

git-svn-id: http://svn.slicer.org/Slicer4/trunk@14215 3bd1e089-480b-0410-8dfb-8563597acbee

git-svn-id: http://svn.slicer.org/Slicer4/trunk@14212 3bd1e089-480b-0410-8dfb-8563597acbee

git-svn-id: http://svn.slicer.org/Slicer4/trunk@14194 3bd1e089-480b-0410-8dfb-8563597acbee

git-svn-id: http://svn.slicer.org/Slicer4/trunk@14193 3bd1e089-480b-0410-8dfb-8563597acbee

git-svn-id: http://svn.slicer.org/Slicer4/trunk@14190 3bd1e089-480b-0410-8dfb-8563597acbee

The scene "spl_pnl_brain_atlas_2007_slicer3/atlas-2007.mrml" loads in 2.5seconds

Note that the number of enabled modules is also small. (Data, MRMLTree and Color are disabled)

git-svn-id: http://svn.slicer.org/Slicer4/trunk@14189 3bd1e089-480b-0410-8dfb-8563597acbee

BUG: MRMLScene - Updated function SetIsImporting, now use correct value to perform binary and/or operation

git-svn-id: http://svn.slicer.org/Slicer4/trunk@14187 3bd1e089-480b-0410-8dfb-8563597acbee

git-svn-id: http://svn.slicer.org/Slicer4/trunk@14180 3bd1e089-480b-0410-8dfb-8563597acbee

BUG: vtkMRMLAbstractDisplayableManager - InMRMLCallbackFlag shouldn't be checked within ProcessMRMLEvents

Indeed, the flag InMRMLCallbackFlag is set in MRMLCallback static function and
will always be True in ProcessMRMLEvents.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@14174 3bd1e089-480b-0410-8dfb-8563597acbee

ENH: qMRMLSliceViewWidget - In setMRMLSliceNode, the widget is either disabled or enabled if the given node is NULL or not.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@14171 3bd1e089-480b-0410-8dfb-8563597acbee

BUG: qMRMLSliceViewWidget - Since the node passed to setMRMLSliceNode could be Null, updateWidgetFromMRMLSliceNode is now conditionally called.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@14170 3bd1e089-480b-0410-8dfb-8563597acbee

ENH: qMRMLThreeDRenderView - Updated Initialize - Factory are now conditionnally registered using IsDisplayableManagerRegistered

Since the factory is a singleton, the DisplayableManager could be
registered only one time by the application itself.

That would imply to move the Registration of the factory out of the ThreeDRenderView.
Nevertheless it's somehow nice (group the functionality) to let
the ThreeDRenderView registers the DisplayableManager
that will be instantiated and associated with its underlying Renderer.

This commit use the new function IsDisplayableManagerRegistered to check
if a given DisplayableManager has been registered or not, and then register it if required.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@14169 3bd1e089-480b-0410-8dfb-8563597acbee

git-svn-id: http://svn.slicer.org/Slicer4/trunk@14168 3bd1e089-480b-0410-8dfb-8563597acbee

ENH: qMRMLThreeDRenderView - In setMRMLViewNode, the widget is either disabled or enabled if given node is NULL or not.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@14167 3bd1e089-480b-0410-8dfb-8563597acbee

git-svn-id: http://svn.slicer.org/Slicer4/trunk@14166 3bd1e089-480b-0410-8dfb-8563597acbee

This is was preventing the CameraDisplayableManager to create missing
vtkMRMLCameraNode after a scene was loaded (using Scene::Connect).

git-svn-id: http://svn.slicer.org/Slicer4/trunk@14165 3bd1e089-480b-0410-8dfb-8563597acbee

It's now possible to disable console output. This is particularly useful
when the widget listing the MRML event is visible and ones doesn't
want to see extra output in the console.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@14164 3bd1e089-480b-0410-8dfb-8563597acbee

ENH: MRMLScene - Change existing call to GetIsClosing into GetIsUpdating. Also updated Import function.

Scene::Import function doesn't set the IsClosing flag anymore

Code which was relying on GetIsClosing is now using GetIsUpdating

See http://massmail.spl.harvard.edu/public-archives/slicer-devel/2010/005057.html

git-svn-id: http://svn.slicer.org/Slicer4/trunk@14163 3bd1e089-480b-0410-8dfb-8563597acbee

IsImporting flag is set to True when Import starts and set to False when it ends

See http://massmail.spl.harvard.edu/public-archives/slicer-devel/2010/005057.html

git-svn-id: http://svn.slicer.org/Slicer4/trunk@14162 3bd1e089-480b-0410-8dfb-8563597acbee

There were both equal to 66008.

Now SceneRestoredEvent = 66005 and ImportProgressFeedbackEvent = 66008

git-svn-id: http://svn.slicer.org/Slicer4/trunk@14161 3bd1e089-480b-0410-8dfb-8563597acbee

Since Load{Start,End}Event has been renamed into SceneAboutToBeImported and SceneImported,
the event LoadProgressFeedbackEvent has also been renamed into ImportProgressFeedbackEvent

git-svn-id: http://svn.slicer.org/Slicer4/trunk@14160 3bd1e089-480b-0410-8dfb-8563597acbee

ENH: MRMLScene - Event SceneLoad{Start|End}Event renamed into SceneAboutToBeImportedEvent and SceneImportedEvent

The event were invoked within Scene::Import() method.
Whereas in slicer "Loading" a scene means that method Scene::Connect should be called

To limit confusion, the event invoked within the function Import have been
named after the associated function.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@14159 3bd1e089-480b-0410-8dfb-8563597acbee

This choice has been motivated to improve readability and limit confusion.

http://massmail.spl.harvard.edu/public-archives/slicer-devel/2010/005057.html

git-svn-id: http://svn.slicer.org/Slicer4/trunk@14158 3bd1e089-480b-0410-8dfb-8563597acbee

The choice has been motivated to improve readability and limit confusion.

See http://massmail.spl.harvard.edu/public-archives/slicer-devel/2010/005057.html

git-svn-id: http://svn.slicer.org/Slicer4/trunk@14157 3bd1e089-480b-0410-8dfb-8563597acbee

git-svn-id: http://svn.slicer.org/Slicer4/trunk@14156 3bd1e089-480b-0410-8dfb-8563597acbee

Since the flag is set to true when the scene start to close and set to false
when it's done. It was decided to rename it.

See http://massmail.spl.harvard.edu/public-archives/slicer-devel/2010/005057.html

git-svn-id: http://svn.slicer.org/Slicer4/trunk@14155 3bd1e089-480b-0410-8dfb-8563597acbee

Since Connect corresponds to Close followed by Import, it make sens
to call these functions instead of duplicating the code.

See http://massmail.spl.harvard.edu/public-archives/slicer-devel/2010/005057.html

git-svn-id: http://svn.slicer.org/Slicer4/trunk@14154 3bd1e089-480b-0410-8dfb-8563597acbee

IsConnecting flag is set to true when Connect start and set to False at the end

See http://massmail.spl.harvard.edu/public-archives/slicer-devel/2010/005057.html

git-svn-id: http://svn.slicer.org/Slicer4/trunk@14153 3bd1e089-480b-0410-8dfb-8563597acbee

Listening SceneLoadEndEvent and checking for the error code allow
to handle case with error.

See http://massmail.spl.harvard.edu/public-archives/slicer-devel/2010/005057.html

git-svn-id: http://svn.slicer.org/Slicer4/trunk@14152 3bd1e089-480b-0410-8dfb-8563597acbee

BUG: vtkMRMLSliceLogic - Updated DeleteSliceModel method, it now makes sure {SliceModel, SliceModelDisplay, SliceModelTransform}Node are present before calling scene->RemoveNode

Doing so ensure that the events NodeAboutToBeRemovedEvent and NodeRemovedEvent
are not invoked multiple times.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@14151 3bd1e089-480b-0410-8dfb-8563597acbee

git-svn-id: http://svn.slicer.org/Slicer4/trunk@14147 3bd1e089-480b-0410-8dfb-8563597acbee

git-svn-id: http://svn.slicer.org/Slicer4/trunk@14143 3bd1e089-480b-0410-8dfb-8563597acbee

in qMRMLSceneModels

git-svn-id: http://svn.slicer.org/Slicer4/trunk@14142 3bd1e089-480b-0410-8dfb-8563597acbee

git-svn-id: http://svn.slicer.org/Slicer4/trunk@14139 3bd1e089-480b-0410-8dfb-8563597acbee

The added observers are not used - In case they are needed, that use case
should tested within vtkMRMLCameraDisplayableManagerTest1.

Moreover, instead of being separate function call, this functions should
be integrated to the existing method SetAndObserveCameraNode.

git-svn-id: http://svn.slicer.org/Slicer4/trunk@14137 3bd1e089-480b-0410-8dfb-8563597acbee

git-svn-id: http://svn.slicer.org/Slicer4/trunk@14136 3bd1e089-480b-0410-8dfb-8563597acbee