1. 08 Mar, 2019 2 commits
    • jcfr's avatar
      COMP: Fix unused warnings related to use of vtkMRMLNodePropertyMacros · 29be7973
      jcfr authored
      These classes where using the macros vtkMRMLWriteXMLBeginMacro and
      vtkMRMLWriteXMLEndMacro but without any content printed or written
      between those calls.
      
      This commit fixes warnings like the following:
      
      ```cpp
      [...]
      Modules/Loadable/VolumeRendering/MRML/vtkMRMLGPURayCastVolumeRenderingDisplayNode.cxx: In member function ‘virtual void vtkMRMLGPURayCastVolumeRenderingDisplayNode::ReadXMLAttributes(const char**)’:
      Libs/MRML/Core/vtkMRMLNodePropertyMacros.h:148:15: warning: variable ‘xmlReadAttName’ set but not used [-Wunused-but-set-variable]
         const char* xmlReadAttName; \
                     ^~~~~~~~~~~~~~
      Modules/Loadable/VolumeRendering/MRML/vtkMRMLGPURayCastVolumeRenderingDisplayNode.cxx:48:3: note: in expansion of macro ‘vtkMRMLReadXMLBeginMacro’
         vtkMRMLReadXMLBeginMacro(atts);
         ^~~~~~~~~~~~~~~~~~~~~~~~
      [...]
      Modules/Loadable/VolumeRendering/MRML/vtkMRMLGPURayCastVolumeRenderingDisplayNode.cxx: In member function ‘virtual void vtkMRMLGPURayCastVolumeRenderingDisplayNode::WriteXML(std::ostream&, int)’:
      Libs/MRML/Core/vtkMRMLNodePropertyMacros.h:30:12: warning: unused variable ‘xmlWriteOutputStream’ [-Wunused-variable]
         ostream& xmlWriteOutputStream = of;
                  ^~~~~~~~~~~~~~~~~~~~
      Modules/Loadable/VolumeRendering/MRML/vtkMRMLGPURayCastVolumeRenderingDisplayNode.cxx:57:3: note: in expansion of macro ‘vtkMRMLWriteXMLBeginMacro’
         vtkMRMLWriteXMLBeginMacro(of);
         ^~~~~~~~~~~~~~~~~~~~~~~~~
      ```
      
      ```cpp
      [...]
      Modules/Loadable/VolumeRendering/MRML/vtkMRMLGPURayCastVolumeRenderingDisplayNode.cxx: In member function ‘virtual void vtkMRMLGPURayCastVolumeRenderingDisplayNode::PrintSelf(std::ostream&, vtkIndent)’:
      Libs/MRML/Core/vtkMRMLNodePropertyMacros.h:417:12: warning: unused variable ‘printOutputStream’ [-Wunused-variable]
         ostream& printOutputStream = os; \
                  ^~~~~~~~~~~~~~~~~
      Modules/Loadable/VolumeRendering/MRML/vtkMRMLGPURayCastVolumeRenderingDisplayNode.cxx:78:3: note: in expansion of macro ‘vtkMRMLPrintBeginMacro’
         vtkMRMLPrintBeginMacro(os, indent);
         ^~~~~~~~~~~~~~~~~~~~~~
      Libs/MRML/Core/vtkMRMLNodePropertyMacros.h:418:13: warning: variable ‘printOutputIndent’ set but not used [-Wunused-but-set-variable]
         vtkIndent printOutputIndent = indent;
                   ^~~~~~~~~~~~~~~~~
      Modules/Loadable/VolumeRendering/MRML/vtkMRMLGPURayCastVolumeRenderingDisplayNode.cxx:78:3: note: in expansion of macro ‘vtkMRMLPrintBeginMacro’
         vtkMRMLPrintBeginMacro(os, indent);
      ```
      
      From: Pablo Hernandez-Cerdan <pablo.hernandez@kitware.com>
      
      git-svn-id: http://svn.slicer.org/Slicer4/trunk@27999 3bd1e089-480b-0410-8dfb-8563597acbee
      29be7973
    • jcfr's avatar
      ENH: Update SlicerExecutionModel · 3ce64641
      jcfr authored
      List of changes:
      
      $ git shortlog 0dee798..c560102 --no-merges
      Hans Johnson (2):
            BUG: Fix compilation when policies are less than 3.13.0
            COMP: ModuleDescriptionParser: Replace obsolete add_compiler_export_flags
      
      Jean-Christophe Fillion-Robin (1):
            cmake: Add support for including an additional find package configuration
      
      Matt McCormick (1):
            SEMMacroBuildCLI: Enable interprocedural optimization on targets
      
      Sankhesh Jhaveri (1):
            BUG: Replace newline characters by line breaks
      
      git-svn-id: http://svn.slicer.org/Slicer4/trunk@27998 3bd1e089-480b-0410-8dfb-8563597acbee
      3ce64641
  2. 06 Mar, 2019 5 commits
    • jcfr's avatar
      850a7e1e
    • jcfr's avatar
      BUG: Fix linux package removing dependency to GLVND libraries · 245097a6
      jcfr authored
      By setting OpenGL_GL_PREFERENCE to LEGACY, this commit ensures that
      the applications and libraries are linked against libGL.so (legacy) instead
      of libOpenGL.so and libGLX.so (GL Vendor Neutral Dispatch library). It allows
      to run the application on system where only libGL is available.
      
      It fixes a regression introduced in r27988 (COMP: Update CMake minimum required
      version from 3.5 to 3.13) after which one CMP0072 was set to NEW and led to
      have the GLVND libraries being used by default.
      
      Detailed explanation about GLVND (thanks @chuckatkins
      
      ):
      libOpenGL.so and libGLX.so are actually just the stub GLVND interface
      libraries with no implementation behind them. GLVND uses a config file
      to locate and dlopen the implementation at runtime like a plugin
      (/usr/lib64/libGLX_nvidia.so.418.39 for instance).
      So it's not really suitable for redistribution unless an implementation
      like a glvnd-enabled mesa and associated config files are also packaged.
      For broad redistributability, it is preferable to use use the legacy libGL
      for now so at runtime it will be available on most systems.
      That will likely need to be the case for the next few years until
      the non-glvnd implementations are much less common.
      Co-authored-by: Chuck Atkins's avatarChuck Atkins <chuck.atkins@kitware.com>
      
      git-svn-id: http://svn.slicer.org/Slicer4/trunk@27996 3bd1e089-480b-0410-8dfb-8563597acbee
      245097a6
    • jcfr's avatar
      COMP: Fix install of "pyparsing" and "packaging" adding setuptools dependency · 72bc6b4d
      jcfr authored
      Following r27374 (ENH: Update pip from 10.0.1 to 18.0, and setuptools
      from 39.2.0 to 40.2.0), pyparsing and packaging packages were removed
      because they were vendorized in the new updated setuptools.
      
      Then, they were re-introduced in r27279 (BUG: Ensure python-packaging is
      available) because they were in fact directly used in script like
      "DICOMWidgets.py" to parse version relying on "packaging.version".
      
      This commit fixes regression introduced in r27279 by explicitly adding
      setuptools as a dependency of "pyparsing" and "packaging".
      
      It avoids error like the following:
      
      ```
      cat /Volumes/Dashboards/Preview/Slicer-0-build/python-pyparsing-prefix/src/python-pyparsing-stamp/python-pyparsing-install-err.log
      Traceback (most recent call last):
        File "setup.py", line 5, in <module>
          from setuptools import setup
      ImportError: No module named setuptools
      ```
      
      git-svn-id: http://svn.slicer.org/Slicer4/trunk@27995 3bd1e089-480b-0410-8dfb-8563597acbee
      72bc6b4d
    • jcfr's avatar
      COMP: Fix -Wcatch-value and -Wunused-variable warnings · cd74ede9
      jcfr authored
      - Catch by value exception in `Testing/VTKITKVectorReader.cxx`
      
      ```cpp
      warning: catching polymorphic type ‘class itk::ExceptionObject’ by value [-Wcatch-value=]
      ```
      
      - unused variable in vtkAddon/vtkOpenGLShaderComputation.cxx
      
      ```cpp
      /Libs/vtkAddon/vtkOpenGLShaderComputation.cxx:423:10: warning: unused variable ‘status’ [-Wunused-variable]
         GLenum status;
                ^~~~~~
      ```
      
      From: Pablo Hernandez-Cerdan <pablo.hernandez.cerdan@outlook.com>
      
      git-svn-id: http://svn.slicer.org/Slicer4/trunk@27994 3bd1e089-480b-0410-8dfb-8563597acbee
      cd74ede9
    • jcfr's avatar
      COMP: Update CMake minimum required version from 3.5 to 3.13.4 in internal projects · 3be2c3f8
      jcfr authored
      This commit is a follow-up of commit r27888 (COMP: Update CMake minimum
      required version from 3.5 to 3.13)
      
      From: Pablo Hernandez-Cerdan <pablo.hernandez.cerdan@outlook.com>
      
      git-svn-id: http://svn.slicer.org/Slicer4/trunk@27993 3bd1e089-480b-0410-8dfb-8563597acbee
      3be2c3f8
  3. 05 Mar, 2019 3 commits
  4. 04 Mar, 2019 16 commits
  5. 03 Mar, 2019 1 commit
  6. 01 Mar, 2019 2 commits
  7. 27 Feb, 2019 2 commits
    • jcfr's avatar
      BUG: Update VTK to integrate vtkLabelHierarchy fix · 8f10bc7e
      jcfr authored
      
      
      The fix is needed for the widgets to work properly when multiple markups
      are placed into the same position.
      Suggested-by: Andras Lasso's avatarAndras Lasso <lasso@queensu.ca>
      
      List of VTK changes:
      
      $ git shortlog 99797966b6..0c356e1d78 --no-merges
      David E. DeMarle (1):
            [backport] fix a crash when rebuilding labelhierarchy
      
      git-svn-id: http://svn.slicer.org/Slicer4/trunk@27970 3bd1e089-480b-0410-8dfb-8563597acbee
      8f10bc7e
    • jcfr's avatar
      BUG: ScreenCapture: Fix deprecated use of QPixmap::grabWidget · 109bd90b
      jcfr authored
      This fixes a deprecation warning QPixmap::grabWidget is deprecated, use
      QWidget::grab() instead.
      To replicate the warning, use ScreenCapture module to capture a single
      image of all views.
      
      This use case was accidentally overlooked when r26255 was committed
      which fixed other instances.
      
      Once Slicer is no longer trying to support both Qt4 and Qt5, then
      QWidget::grab() can be used directly. Currently
      ctkWidgetUtils.grabWidget is used which uses QPixmap::grabWidget if Qt4
      and QWidget::grab if Qt5.
      
      From: jamesobutler <jbutler@sonovol.com>
      
      git-svn-id: http://svn.slicer.org/Slicer4/trunk@27969 3bd1e089-480b-0410-8dfb-8563597acbee
      109bd90b
  8. 19 Feb, 2019 2 commits
  9. 18 Feb, 2019 1 commit
    • cpinter's avatar
      ENH: Use subject hierarchy in Models module · e9f25f8c
      cpinter authored
      - Only shows model and model hierarchy nodes (which are represented as SH folders)
      - All plugins are disabled except for Models, Folder, Opacity (and Default)
      - Apply color to branch action provided by the Folder plugin replaces the checkbox in model hierarchy
        - When the user changes the color of the folder then this option gets enabled automatically
        - Can be enabled/disabled using a checkable visibility action (right-click on eye icon or color)
        - If enabled, then visibility only applies to the folder, otherwise the default SH behavior is used (show/hide all items in whole branch)
      
      git-svn-id: http://svn.slicer.org/Slicer4/trunk@27966 3bd1e089-480b-0410-8dfb-8563597acbee
      e9f25f8c
  10. 15 Feb, 2019 2 commits
  11. 12 Feb, 2019 1 commit
  12. 11 Feb, 2019 1 commit
  13. 09 Feb, 2019 2 commits