1. 11 Mar, 2019 3 commits
  2. 10 Mar, 2019 2 commits
  3. 09 Mar, 2019 1 commit
    • jcfr's avatar
      COMP: Fix configuration on macOS · c6cfa1b6
      jcfr authored
      This commit fixes a regression introduced in r28000 (COMP: Update build
      system removing support for C++98/Qt4/VTK7).
      
      Following commit r28000 the ivar "required_deployment_target" was never
      set because the module SlicerInitializeOSXVariables CMake  module is
      included from the top-level CMakeLists.txt before the "project()" statement
      and in that case Slicer_SOURCE_DIR was not defined too.
      
      git-svn-id: http://svn.slicer.org/Slicer4/trunk@28009 3bd1e089-480b-0410-8dfb-8563597acbee
      c6cfa1b6
  4. 08 Mar, 2019 11 commits
  5. 06 Mar, 2019 5 commits
    • jcfr's avatar
      850a7e1e
    • jcfr's avatar
      BUG: Fix linux package removing dependency to GLVND libraries · 245097a6
      jcfr authored
      By setting OpenGL_GL_PREFERENCE to LEGACY, this commit ensures that
      the applications and libraries are linked against libGL.so (legacy) instead
      of libOpenGL.so and libGLX.so (GL Vendor Neutral Dispatch library). It allows
      to run the application on system where only libGL is available.
      
      It fixes a regression introduced in r27988 (COMP: Update CMake minimum required
      version from 3.5 to 3.13) after which one CMP0072 was set to NEW and led to
      have the GLVND libraries being used by default.
      
      Detailed explanation about GLVND (thanks @chuckatkins
      
      ):
      libOpenGL.so and libGLX.so are actually just the stub GLVND interface
      libraries with no implementation behind them. GLVND uses a config file
      to locate and dlopen the implementation at runtime like a plugin
      (/usr/lib64/libGLX_nvidia.so.418.39 for instance).
      So it's not really suitable for redistribution unless an implementation
      like a glvnd-enabled mesa and associated config files are also packaged.
      For broad redistributability, it is preferable to use use the legacy libGL
      for now so at runtime it will be available on most systems.
      That will likely need to be the case for the next few years until
      the non-glvnd implementations are much less common.
      Co-authored-by: Chuck Atkins's avatarChuck Atkins <chuck.atkins@kitware.com>
      
      git-svn-id: http://svn.slicer.org/Slicer4/trunk@27996 3bd1e089-480b-0410-8dfb-8563597acbee
      245097a6
    • jcfr's avatar
      COMP: Fix install of "pyparsing" and "packaging" adding setuptools dependency · 72bc6b4d
      jcfr authored
      Following r27374 (ENH: Update pip from 10.0.1 to 18.0, and setuptools
      from 39.2.0 to 40.2.0), pyparsing and packaging packages were removed
      because they were vendorized in the new updated setuptools.
      
      Then, they were re-introduced in r27279 (BUG: Ensure python-packaging is
      available) because they were in fact directly used in script like
      "DICOMWidgets.py" to parse version relying on "packaging.version".
      
      This commit fixes regression introduced in r27279 by explicitly adding
      setuptools as a dependency of "pyparsing" and "packaging".
      
      It avoids error like the following:
      
      ```
      cat /Volumes/Dashboards/Preview/Slicer-0-build/python-pyparsing-prefix/src/python-pyparsing-stamp/python-pyparsing-install-err.log
      Traceback (most recent call last):
        File "setup.py", line 5, in <module>
          from setuptools import setup
      ImportError: No module named setuptools
      ```
      
      git-svn-id: http://svn.slicer.org/Slicer4/trunk@27995 3bd1e089-480b-0410-8dfb-8563597acbee
      72bc6b4d
    • jcfr's avatar
      COMP: Fix -Wcatch-value and -Wunused-variable warnings · cd74ede9
      jcfr authored
      - Catch by value exception in `Testing/VTKITKVectorReader.cxx`
      
      ```cpp
      warning: catching polymorphic type ‘class itk::ExceptionObject’ by value [-Wcatch-value=]
      ```
      
      - unused variable in vtkAddon/vtkOpenGLShaderComputation.cxx
      
      ```cpp
      /Libs/vtkAddon/vtkOpenGLShaderComputation.cxx:423:10: warning: unused variable ‘status’ [-Wunused-variable]
         GLenum status;
                ^~~~~~
      ```
      
      From: Pablo Hernandez-Cerdan <pablo.hernandez.cerdan@outlook.com>
      
      git-svn-id: http://svn.slicer.org/Slicer4/trunk@27994 3bd1e089-480b-0410-8dfb-8563597acbee
      cd74ede9
    • jcfr's avatar
      COMP: Update CMake minimum required version from 3.5 to 3.13.4 in internal projects · 3be2c3f8
      jcfr authored
      This commit is a follow-up of commit r27888 (COMP: Update CMake minimum
      required version from 3.5 to 3.13)
      
      From: Pablo Hernandez-Cerdan <pablo.hernandez.cerdan@outlook.com>
      
      git-svn-id: http://svn.slicer.org/Slicer4/trunk@27993 3bd1e089-480b-0410-8dfb-8563597acbee
      3be2c3f8
  6. 05 Mar, 2019 3 commits
  7. 04 Mar, 2019 15 commits