Brad King authored Nov 01, 2021 and Kitware Robot committed Nov 01, 2021

bcddb31b

 SystemTools: Fix Windows app exec alias layout
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !240

Fix the layout added by commit 025a4951 (SystemTools: Add Windows app
exec alias support to ReadSymlink, 2021-10-28) to match this reference:

  https://www.tiraniddo.dev/2019/09/overview-of-windows-execution-aliases.html

Reported-by: Yuriy O'Donnell <yuriy.odonnell@epicgames.com>

Brad King authored Oct 29, 2021 and Kitware Robot committed Oct 29, 2021

f5b3500f

 SystemTools: Simplify FileIsExecutable on Windows
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !239

Brad King authored Oct 29, 2021 and Kitware Robot committed Oct 29, 2021

025a4951

 SystemTools: Add Windows app exec alias support to ReadSymlink
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !238

Revert commit 41700ca4 (SystemTools: Fix FileIsExecutable on Windows,
2020-04-09).  The purpose of that change was to avoid treating the path
`%USERPROFILE%\AppData\Local\Microsoft\WindowsApps\python.exe` as an
executable because it might point at an application installer instead of
a working Python.  Since commit 29f31d17 (SystemTools: Add Windows app
exec alias support to FileExists(), 2021-10-22), the implementation
using `FileExists` will find it anyway.  Client (e.g. CMake) will need
another way to avoid using that python app link incorrectly.

Brad King authored Oct 27, 2021 and Kitware Robot committed Oct 27, 2021

29f31d17

 SystemTools: Add Windows app exec alias support to FileExists()
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !236

Brad King authored Oct 27, 2021 and Kitware Robot committed Oct 27, 2021

44718539 Fix for extraneous semi-colon warning
0f44b620 Fix Wreserved-id-macro warning by removing double underscore
31d25023 Fix all Wold-style-cast warnings
6f4a1826 Fix Wmissing-variable-declarations by declaring variable in a header
f3d4b12b Fix Wmissing-prototypes warnings by making functions static
f771c009 Fix -Wunused-macros warning by defining under same conditions as usage
f9f6d67b Replace non-standard _snprintf with standard snprintf
704a63d4

 Replace sprintf with snprintf
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !235

This also allowed the compiler to notice a mismatch of format specifiers, and so changed %X to %lX.

Not handling execution aliases causes CMake find_program to report false
negatives for applications installed through Microsoft Store. As a specific
example, this affects PowerShell Core (pwsh.exe) used by Microsoft's vcpkg,
rendering it unusable on some machines.

This change preserves the existing behavior of regular symlinks but now treats
execution aliases as valid files. The alias target itself is not validated.

Brad King authored Oct 15, 2021 and Kitware Robot committed Oct 15, 2021

e28d7282

 DynamicLoader: Add RTLD_GLOBAL as a supported flag on linux
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !233

Brad King authored Oct 08, 2021 and Kitware Robot committed Oct 08, 2021

15effd64

 MD5: Fix Clang 13 Wnull-pointer-subtraction warning
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !231

Brad King authored Oct 06, 2021 and Kitware Robot committed Oct 06, 2021

f9e45083

 CTestConfig: Always set CTEST_DROP_METHOD to https
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !230

Sean McBride authored Oct 05, 2021 and Brad King committed Oct 05, 2021

open.cdash.org has long supported https

Brad King authored Sep 15, 2021 and Kitware Robot committed Sep 15, 2021

6ccbfc12

 SystemTools: Add a Join function
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Mathieu Westphal <mathieu.westphal@kitware.com>
Acked-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !229

* The Join function joins a vector of strings in a single string with
  a specific separator in between

Brad King authored Sep 03, 2021 and Kitware Robot committed Sep 03, 2021

4ef5b106

 SystemTools: Ensure Windows Vista APIs are available before using them
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !228

Steven Boswell authored Aug 30, 2021 and Brad King committed Sep 02, 2021

Since commit 3683e5ab (SystemTools: Implement CreateSymlink and
ReadSymlink on Windows, 2021-05-06) we use `CreateSymbolicLinkW`, which
is only available under Windows Vista or later.

Brad King authored Aug 06, 2021 and Kitware Robot committed Aug 06, 2021

a6a0bb15 Status: use the new IsSuccess method
40bbf3fd

 Status: offer an `IsSuccess` method
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !227

It is much easier to read (especially when coming from the POSIX side of
things).

This method makes usage much easier to read than prepending with `!!` or
`static_cast<bool>` to extract a boolean from the structure.

Brad King authored Jul 29, 2021 and Kitware Robot committed Jul 29, 2021

5d4c8b04

 SystemInformation: Simplify demangle buffer management
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !226

If the buffer we pass to `__cxa_demangle` is not large enough, it will
be reallocated internally.  Avoid dealing with possibly two allocations
to free by just letting `__cxa_demangle` allocate a suitable buffer.

Brad King authored Jul 26, 2021 and Kitware Robot committed Jul 26, 2021

4e69b791

 SystemInformation: Add option to explicitly avoid using execinfo
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !225

Đoàn Trần Công Danh authored Jul 18, 2021 and Brad King committed Jul 26, 2021

backtrace(3) from libexecinfo in musl will run into crash [1].

Provide an option to disable it explicitly even if libexecinfo is present.

1: https://www.openwall.com/lists/musl/2021/07/17/1

Brad King authored Jul 08, 2021 and Kitware Robot committed Jul 08, 2021

7079df74

 SystemTools: Fix GetOperatingSystemNameAndVersion empty string return
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !224

Dženan Zukić authored Jul 07, 2021 and Brad King committed Jul 07, 2021

Avoid undefined behavior caused by constructing `std::string` from `0`.

Brad King authored Jun 28, 2021 and Kitware Robot committed Jun 28, 2021

b954dd54

 testDynamicLoader: Use LIBC_SO if LIBDL_SO is not defined by glibc anymore.
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !223

Björn Esser authored Jun 28, 2021 and Brad King committed Jun 28, 2021

`LIBC_SO` is a more long-term choice, suitable for new targets that may
no longer define `LIBDL_SO`.
Signed-off-by: Björn Esser <besser82@fedoraproject.org>

Brad King authored Jun 28, 2021 and Kitware Robot committed Jun 28, 2021

ab959cd2 SystemInformation: fix typo in comment
df91e5f1

 EncodingC: use NULL for pointers
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !222

Brad King authored Jun 25, 2021 and Kitware Robot committed Jun 25, 2021

b4a2a03c

 testDynamicLoader: Use LIBDL_SO macro if defined.
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !221