1. 24 May, 2018 1 commit
    • Lucas Gandel's avatar
      Improve QVTKOpenGLWidget and add QVTKOpenGLWindow class based on QOpenGLWindow · 45704131
      Lucas Gandel authored
      Fixing stereo support with Qt5.
      Commit 139f787a was introducing QVTKOpenGLWidget to couple a vtkRenderWindow with a QOpenGLWidget.
      However, both QVTKOpenGLWidget and its superclass QOpenGLWidget manage a single frame buffer.
      
      QVTKOpenGLWindow derives the QOpenGLWindow class to benefit from an OpenGL context managing multiple frame buffers.
      It can be used as a QWidget by calling QWidget::createWindowContainer() on your QVTKOpenGLWindow instance.
      QVTKOpenGLWidget has been reimplemented to use thes QVTKOpenGLWindow directly has a widget.
      It is recommended to do so.
      
      The old QVTKOpenGLWidget is been moved into QVTKOpenGLSimpleWidget and should not be removed as it support being a native widget,
      wich the new implementation does not.
      
      There is a new QVTKOpenGLWidget::isValid() method to check that the widget is ready to render.
      
      It is to be noted that there is a specific implementation of
      event handling in order to work around QTBUG-61836.
      The Qt::WindowTransparentForInputFlag has no effect on Mac. Thus events
      are not being passed to the widget. We let the window grabbing all events
      and then forward them to the widget.
      We also take care for providing a method to forward back events to the
      window if events were explicitely triggered on the widget instance. This
      is the case for some paraview testing logic that should now use the provided
      testingEvent() method instead of notifying the widget with events.
      
      It is to be noted that, on OSX, the widget is always resized to its internal vtkRenderWindow
      size to ensure that the viewport is correct.
      This is necessary only on MacOS when HiDPI is supported. Enabling HiDPI
      has the side effect that Cocoa will start overriding any glViewport calls
      in application code. For reference, see QCocoaWindow::initialize().
      
      This also improve tests and examples using the QVTKOpenGLWidget
      45704131
  2. 31 Dec, 2017 1 commit
    • Hans Johnson's avatar
      COMP: Add more C++11 override instrumentation · bcf798e7
      Hans Johnson authored
      Providing override key work allows for extra checking
      that the function signatures are correct.
      
      https://stackoverflow.com/questions/39932391/virtual-override-or-both-c?answertab=active#tab-top
      
      In the derived class the function is virtual by way of having the ¹same
      type as the base class function.
      
      However, an override can help avoid bugs by producing a compilation
      error when the intended override isn't technically an override. E.g.
      that the function type isn't exactly like the base class function. Or
      that a maintenance of the base class changes that function's type, e.g.
      adding a defaulted argument.
      
      In the same way, a virtual keyword in the derived class can make such a
      bug more subtle, by ensuring that the function is still virtual in
      further derived classes.
      
      The general advice is,
           -Use virtual for the base class function declaration.
            This is technically necessary.
      
           -Use override (only) for a derived class' override.
            This helps maintenance.
      bcf798e7
  3. 21 Dec, 2017 1 commit
  4. 06 Dec, 2017 1 commit
  5. 04 Dec, 2017 1 commit
  6. 13 Nov, 2017 1 commit
  7. 06 Oct, 2017 1 commit
  8. 04 Oct, 2017 5 commits
  9. 23 Sep, 2016 2 commits
    • Kitware Robot's avatar
      Reindent using the reindentation script. · f830ff47
      Kitware Robot authored
      This commit reindents the code with the following utility:
      Utilities/Maintenance/vtk-reindent-code.py
      
      This utility changes the positions of the braces so that they are no
      longer indented relative to the code block they reside in.
      
      The bash command line used was the following:
      
      for d in Charts Common Deprecated Domains Examples Filters GUISupport \
               Geovis IO Imaging Infovis Interaction Parallel Rendering \
               Testing Views Web Wrapping; do
        for e in cxx cxx.in txx txx.in hxx hxx.in h h.in c c.in; do
          find "${d}" -name "*.${e}" -exec \
            python Utilities/Maintenance/vtk_reindent_code.py {} +
        done
      done
      f830ff47
    • David DeMarle's avatar
      replace VTK's nonstandard Doxygen with standard markup · 6a7e5148
      David DeMarle authored
      generated via:
      cd $VTKSRC
      perl Utilities/Doxygen/doc_header2doxygen.pl --to ~/tmp/vtkheaders .
      cp -r ~/tmp/vtkheaders/* .
      6a7e5148
  10. 07 Jul, 2016 2 commits
    • Sean McBride's avatar
      Applied VTK_DELETE_FUNCTION to many constructors · 1853e030
      Sean McBride authored
      vtk(.*)\(const vtk\1&\);\s*//\s*Not implemented[\.]*
      to
      vtk\1(const vtk\1\&) VTK_DELETE_FUNCTION;
      
      vtk(.*)\(const vtk\1 &\);\s*//\s*Not implemented[\.]*
      to
      vtk\1(const vtk\1 \&) VTK_DELETE_FUNCTION;
      
      vtk(.*)\( const vtk\1 & \);\s*//\s*Not implemented[\.]*
      to
      vtk\1( const vtk\1 \& ) VTK_DELETE_FUNCTION;
      
      vtk(.*)\( const vtk\1& \);\s*//\s*Not implemented[\.]*
      to
      vtk\1( const vtk\1\& ) VTK_DELETE_FUNCTION;
      
      vtk(.*) \(const vtk\1&\);\s*//\s*Not implemented[\.]*
      to
      vtk\1 (const vtk\1\&) VTK_DELETE_FUNCTION;
      1853e030
    • Sean McBride's avatar
      Applied VTK_DELETE_FUNCTION for operator= · 2d0e11ef
      Sean McBride authored
      (operator\s*=.*);\s*//\s*Not\s*implemented[\.]*
      to
      \1 VTK_DELETE_FUNCTION;
      
      After that, this finds basically nothing:
      
      operator.*implemented
      
      then manually reverted changed files in VPIC and KWSys folders.
      2d0e11ef
  11. 25 May, 2016 1 commit
    • Kitware Robot's avatar
      Remove all BTX and ETX markers from VTK headers · 4d127b1d
      Kitware Robot authored
      Perl was used to remove all the BTX and ETX markers from the code.
      The specific command that was run on all "vtk*.h" files was this:
          perl -0777 -i -pe 's/(\n* *\/\/ *[BE]TX *\n+)+/\n\n/g'
      
      This regex replaces each BTX/ETX line, plus any leading or trailing
      blank lines, with a single blank line.
      4d127b1d
  12. 08 Mar, 2016 1 commit
  13. 07 Oct, 2015 1 commit
  14. 18 Dec, 2014 1 commit
  15. 29 Oct, 2014 1 commit
  16. 01 Jan, 2012 1 commit
  17. 13 Dec, 2011 1 commit
  18. 08 Nov, 2011 1 commit
  19. 04 Oct, 2011 1 commit
  20. 22 Aug, 2010 4 commits
  21. 13 Aug, 2010 1 commit
  22. 06 Aug, 2010 1 commit
  23. 10 Jun, 2010 1 commit
  24. 20 May, 2010 1 commit
    • Mark Olesen's avatar
      Remove vtk(Cxx|Type)RevisionMacro · ecbbf7f7
      Mark Olesen authored
      The CVS $Revision$ keyword replacement will no longer maintain these
      macros automatically.  They were used only to implement CollectRevisions
      and vtkObjectBase::PrintRevisions, an API that was never used.
      
      Automated as follows:
      
        pass 0:
        catch templates
        ---------------
        $ git grep 'vtk\(Cxx\|Type\)RevisionMacro' | grep '<'
      
        pass 1:
        main changes
        ---------------
        $ git grep -l '^vtkCxxRevisionMacro' | while read file; do
          echo "$file" 1>&2
          perl -i -ne 'print unless (/^vtkCxxRevisionMacro/ and /\)/)' $file
        done
        $ git grep -l -e 'vtkTypeRevisionMacro(' | while read file; do
          echo "$file" 1>&2
          perl -i -pe 's/vtkTypeRevisionMacro/vtkTypeMacro/g' $file
        done
      
        pass 2:
        verify
        ---------------
        $ git grep 'vtk\(Cxx\|Type\)RevisionMacro'
      
      Fixed multi-line vtkCxxRevisionMacro and templates by hand.
      ecbbf7f7
  25. 23 Apr, 2010 1 commit
    • Mark Olesen's avatar
      Remove vtk(Cxx|Type)RevisionMacro · 19c55e0e
      Mark Olesen authored
      The CVS $Revision$ keyword replacement will no longer maintain these
      macros automatically.  They were used only to implement CollectRevisions
      and vtkObjectBase::PrintRevisions, an API that was never used.
      
      Automated as follows:
      
        pass 0:
        catch templates
        ---------------
        $ git grep 'vtk\(Cxx\|Type\)RevisionMacro' | grep '<'
      
        pass 1:
        main changes
        ---------------
        $ git grep -l '^vtkCxxRevisionMacro' | while read file; do
          echo "$file" 1>&2
          perl -i -ne 'print unless (/^vtkCxxRevisionMacro/ and /\)/)' $file
        done
        $ git grep -l -e 'vtkTypeRevisionMacro(' | while read file; do
          echo "$file" 1>&2
          perl -i -pe 's/vtkTypeRevisionMacro/vtkTypeMacro/g' $file
        done
      
        pass 2:
        verify
        ---------------
        $ git grep 'vtk\(Cxx\|Type\)RevisionMacro'
      
      Fixed multi-line vtkCxxRevisionMacro and templates by hand.
      19c55e0e
  26. 27 Dec, 2009 1 commit
  27. 23 Dec, 2009 3 commits