1. 20 Mar, 2018 1 commit
  2. 08 Mar, 2018 1 commit
  3. 31 Dec, 2017 1 commit
    • Hans Johnson's avatar
      COMP: Add more C++11 override instrumentation · bcf798e7
      Hans Johnson authored
      Providing override key work allows for extra checking
      that the function signatures are correct.
      
      https://stackoverflow.com/questions/39932391/virtual-override-or-both-c?answertab=active#tab-top
      
      In the derived class the function is virtual by way of having the ¹same
      type as the base class function.
      
      However, an override can help avoid bugs by producing a compilation
      error when the intended override isn't technically an override. E.g.
      that the function type isn't exactly like the base class function. Or
      that a maintenance of the base class changes that function's type, e.g.
      adding a defaulted argument.
      
      In the same way, a virtual keyword in the derived class can make such a
      bug more subtle, by ensuring that the function is still virtual in
      further derived classes.
      
      The general advice is,
           -Use virtual for the base class function declaration.
            This is technically necessary.
      
           -Use override (only) for a derived class' override.
            This helps maintenance.
      bcf798e7
  4. 29 Sep, 2017 1 commit
    • Andrew Bauer's avatar
      Improvements for vtkNew for stl containers and comparison operations · fd04b442
      Andrew Bauer authored
      Adding in functionality to allow inserting vtkNew objects into
      stl containers of vtkSmartPointer objects as well as comparisons
      between vtkNew objects and raw pointers. Also removing Get() and
      GetPointer() calls from vtkNew objects since in most instances we
      can just pass in the vtkNew<> object instead of having to use the
      Get() or GetPointer() methods to get the raw pointer.
      fd04b442
  5. 12 Sep, 2017 2 commits
  6. 18 Aug, 2017 2 commits
  7. 17 Aug, 2017 1 commit
    • David E. DeMarle's avatar
      miscellaneous cleanup for merge readiness · 06e08644
      David E. DeMarle authored
      * pedantic spacing, doxygen and other style changes
      * fix unused variable warnings
      * fix sign comparison warnings
      * fix overridden variable warnings.
      * use nullptr instead of NULL or 0
      * use VTK_DELETE_FUNCTION instead of //Not implemented.
      * update a stray __WRAP__ to __VTK_WRAP__ (can likely remove too)
      * fixup override, should now be virtual only on base class, override
      on intermediate children. I'm not familar enough to know if any of the
      override should be final so I didn't add any.
      * revert the change to vtkCellTypeSource as it should not be required
      * fix a faulty test and commit the baseline image
      * can not stack allocate parentCursors dynamic array
      * fix potential use of uninitialized variable warnings with good defaults
      * remove declarations without implementations
      * fix type converion warnings
      * mtime declation and implementation return types must agree
      * M_SQRT2 is not cross platform
      * remove non-cross platform rusage from test
      * fix address unsigned<0 warnings
      * fix virtual function hidden warning
      * VTK_NEWINSTANCE hint so wrappers avoid comp warning
      * fix missing braces warning
      * fix bool vs number comparison warnings
      * fix invalid character literal escape sequence
      * streamline types in GetShiftedLevelZeroIndex to avoid warnings and
      make -1's meaningfule
      * revert planecutter changes as they are harmful and not needed
      * increase test tolerance and add alternate baseline images
          A couple of the dashboard machines draw lines slightly differently.
       Increase test tolerance to just above current failed level and in a
       few cases do that and add alternate images to settle down the noise.
      * disable two tests that do not work on every machine
         Authors are not yet able to reproduce and fix whatever the
       root cause is. disabling the tests until they can.
      06e08644
  8. 08 Aug, 2017 1 commit
    • Philippe P. Pébaÿ's avatar
      Full revision and extension of support for hypertreegrid objects and filters · 61908bd7
      Philippe P. Pébaÿ authored
      In this commit, we provide a complete revision and extension of support for
      hypertreegrid objects and filters, hereby entirely superseding the first
      versions thereof which we developed in 2011-2012.
      When compared to those obtained by constructing an intermediate
      unstructured mesh with fully described connectivity, this new structure
      demonstrates a gain of at least 80% in terms of memory footprint,
      with a better rendering while retaining similar execution speed.
      
      All ancillary structures such as cursors and supercursors have also
      been entirely refactored, for the sake of performance as well as of
      ease of maintenance. Existing native filters, i.e., that operate
      directly on hypertreegrid objects, have been revised accordingly.
      In addition, several new native filters have been added, together with
      a large set of non-regression tests and baseline images.
      
      This commit also implements an adaptive approach in order to accelerate the
      rendering of 2-dimensional hypertreegrids, hereby solving the problem posed
      by the loss of interactivity that occurs when dealing with large and/or
      deeply refined meshes. Specifically, view parameters are taken into account,
      in order to: on one hand, avoid creating surface elements that are
      outside of  the view area; on the other hand, utilize level-of-detail
      properties to cull those cells that are deemed too small to be visible
      with respect to the given view parameters. This adaptive approach typically
      results in a massive increase in rendering performance.
      
      Please refer to the following articles for a comprehensive description:
      https://arxiv.org/abs/1702.04852
      https://arxiv.org/abs/1703.00212
      61908bd7
  9. 26 Jul, 2017 1 commit
    • Kitware Robot's avatar
      Replace many NULL and 0 occurances with nullptr · a855cab0
      Kitware Robot authored
      This topic is the result of running clang-tidy to
      modernize our usage of NULL and 0 to nullptr. It also
      includes some manual and semi manual changes where
      clang-tidy would not be expected to work (such as in
      comments, or classes not compiled on this build)
      
      There are definitely many comments and occurances that
      this topic misses that we will need to fix over time.
      a855cab0
  10. 03 Jul, 2017 4 commits
    • Mathieu Westphal's avatar
      Fixe a few bugs in the vtkPlaneCutter and vtkSphereTree · 33c4a1e8
      Mathieu Westphal authored
      There was a few bugs remaining in vtkPlaneCutter and vtkSphereTree
      This fixes it.
      33c4a1e8
    • Mathieu Westphal's avatar
      Enable vtkPlaneCutter without SphereTree · 8f33da43
      Mathieu Westphal authored
      This commit enables to use vtkPlaneCutter
      without using a vtkSphereTree. When slicing,
      if the sphere tree is not available, an array of
      in/out value will be computed for each points,
      wich allows an easy selection of cells. This mode is not as fast
      as the sphere tree but does not require to build
      any structure with the first slice.
      This also corrects a bug with cellData construction
      in SMP and updates the tests.
      8f33da43
    • Mathieu Westphal's avatar
      Correct Multiblock support in vtkPlaneCutter · 667f71b2
      Mathieu Westphal authored
      The multiblock support was not optimized as it was rebuilding the sphere tree
      at each slice, this fixes it by caching a sphere tree for each block to slice
      667f71b2
    • Mathieu Westphal's avatar
      Improve The SphereTree when not building Hierarchy · 90cd7217
      Mathieu Westphal authored
      This commit improves the vtkSphereTree when not building the tree
      hierarchy by not computing unused bounds and average
      This also expose the BuildHierarchy parameter in vtkPlaneCutter
      90cd7217
  11. 12 Jun, 2017 1 commit
  12. 01 Jun, 2017 1 commit
  13. 31 May, 2017 2 commits
  14. 30 May, 2017 1 commit
  15. 26 May, 2017 1 commit
  16. 24 May, 2017 4 commits
  17. 03 Apr, 2017 2 commits
  18. 28 Mar, 2017 1 commit
    • Will Schroeder's avatar
      Created sphere tree class (vtkSphereTree) · c5b89cba
      Will Schroeder authored
      Created sphere tree class (vtkSphereTree) for processing structured,
      unstructured, and other types of data. The sphere tree supports
      different types of geometric queries such as extracting candidate
      cells from points, lines, and plane cuts. Hooked the sphere tree
      up with a specialized plane cutter. Created a vtkSphereTreeFilter to
      view the sphere tree and test it's output.
      c5b89cba
  19. 19 Mar, 2017 1 commit