GitLab

Mostly removing superflous double whitespace on both user-facing and non-user-facing strings. Some misc. typo fixes sprinkled in as well.

Now that VTK requires a C++11 compiler we can ditch using custom typedefs

updating the tests to follow modern standards

This topic is the result of running clang-tidy to
modernize our usage of NULL and 0 to nullptr. It also
includes some manual and semi manual changes where
clang-tidy would not be expected to work (such as in
comments, or classes not compiled on this build)

There are definitely many comments and occurances that
this topic misses that we will need to fix over time.

- Made a few APIs' params const
- Changed many usages of the evil GetBounds() to expect a const
  return value, even though it does not (yet?) return const
- Slightly changed return values of vtkTextActor3D::GetBounds()
  to return its own ivar instead of its ImageActor's

CHECK_ERROR_MSG and CHECK_WARNING_MSG are used to check the
content of error and warning messages. Error and warning code is often
overlooked during testing. Over the years, these two macros have been
refined to increase their utility. Tests that use the macros defined
their own interpretations. Three different API's have been used in the
macros.

This patch replaces the CHECK_ERROR_MSG and CHECK_WARNING_MSG macros
with methods for vtkTest::ErrorObserver.  All tests that used the
CHECK macros in one form or another have been updated to use the
CheckErrorMessage and CheckWarningMessage methods.

This commit reindents the code with the following utility:
Utilities/Maintenance/vtk-reindent-code.py

This utility changes the positions of the braces so that they are no
longer indented relative to the code block they reside in.

The bash command line used was the following:

for d in Charts Common Deprecated Domains Examples Filters GUISupport \
         Geovis IO Imaging Infovis Interaction Parallel Rendering \
         Testing Views Web Wrapping; do
  for e in cxx cxx.in txx txx.in hxx hxx.in h h.in c c.in; do
    find "${d}" -name "*.${e}" -exec \
      python Utilities/Maintenance/vtk_reindent_code.py {} +
  done
done

It doesn't seem to have got everything, but it's a start.

Some resulting whitespace is suboptimal, but one day
we can fix that with clang-format. :)

Just ran this command:
run-clang-tidy.py -checks=-*,modernize-use-override -fix

(I actually had to build my own clang to make clang-tidy
output "VTK_OVERRIDE" instead of "override".)

A unit test that increases coverage from 77 percent to 98 percent. The
remaining uncovered lines of code are difficult to exercise.

While writing this unit test, we discovered that ExtentClipping
was not implemented. This patch repairs that defect.

Code extracted from:

    https://gitlab.kitware.com/third-party/proj.git

at commit 41bdf05361007f8c5186f3df9944d86bb273ed13 (for/vtk).

We no longer need this compatibility layer for the compilers we support.
Use the following commands to switch to standard header and namespace:

 git grep -l vtksys/ios/ | xargs sed -i 's|vtksys/ios/||'
 git grep -l vtksys_ios | xargs sed -i 's|vtksys_ios|std|g'

In the early days of VTK, support for stl was not portable. vtksys_stl
and vtksys_ios provided a portable implementation of the stl. Now, all
of the VTK supported compilers have portable stl implementations.

This patch:
  1) Replaces the vtksys_ios:: with std::.
  2) Replaces the vtksys_stl:: with std::.
  3) Removes "using" statements for stl

Change-Id: I10a54acbd076e055d8071414f2fff1ebafe1653d

In other words, changed from the C to the C++ header name.
Did this only in .cxx files, and not in ThirdParty.

Change-Id: I81e2b2c7f2db00e98b37d507232fbc84022e8d8f

Add to the Testing/Data directory ExternalData content links mirroring
the content and layout we use from the VTKData/Data directory.

Add a CMake/vtkLegacyData.cmake module, included from CMakeLists.txt and
Testing/External/CMakeLists.txt, to call ExternalData_Expand_Arguments
for all data directories added from VTKData/Data.  This will bulk-fetch
all test input data currently used by tests of any module, enabled or
not.  We can make the DATA{} references more granular later.

Add a VTK_TEST_DATA_DIR variable to refer to the directory we tell the
ExternalData module to populate the real data files.  Replace references
to VTK_DATA_ROOT in test command lines (after -D) with references to
VTK_TEST_DATA_DIR.  Drop the VTK_DATA_ROOT CMake option and stop using
the VTKData repository.

Remove the TESTING_DATA option from the vtk_add_test_cxx API and remove
the VTK_DATA_ROOT option from the vtk_add_test_mpi API since all test
input data are now handled through ExternalData and Testing/Data content
links.

Change-Id: Id02490b76ea2e161b9038188264a4830485039d8

Change-Id: I08fa5337157eda3867866956833ff80445ab70b5

Baseline images are now referenced by ExternalData content links stored
directly in each module source tree.  Drop the old VTKData baseline
subdirectory name from the vtk_add_test_* signatures.

Change-Id: I5bdc7a5bf87fc7c8fa77dcd50b79f2f54d6eba31

Tell calls to vtk_add_test_(cxx|python|tcl) explicitly when there is no
valid baseline image to avoid passing -V unnecessarily.

Change-Id: Ibe5aecdfa076446ddda0b95e814483eb6622af73

Use vtk_add_test_cxx and vtk_test_cxx_executable to replace calls to
vtk_tests.  Then remove vtk_tests and parse_optional_arguments.

Change-Id: I73dee627fa87a399c48b409af046b116fc75a0fd

The vtkTestingInteractor was trying to run regression tests even if
VTK_DATA_ROOT was not defined.

Many Testing/Cxx CMakeLists.txt files tried to run tests that required
input data, even though VTK_DATA_ROOT was not defined.

Subsequent topics will address Tcl and Python tests.

Change-Id: Iabf242f9f498ce044948ca1d4a29378b76ceb21d

Change-Id: Id024c377b6b85f3f9ca794984f7200362e6a565c

We don't plan to move the vtk baseline images so this new testing
macro needs an argument to tell it where to find the images to
compare with.

Change-Id: Iab3f617b07d80ea5fba18333a8c9afc83cb3ca16

The test run by fail. Need to fix these at some later point in time.

Change-Id: Ifa956c9c4410c410a9accb96877fe57c86693c66

- This module moved code common to various tests in different modules into a new
  Testing module.
- The export macros are changed accordingly.

Change-Id: I2b0c34ed7c4dca8cb3525ce121728249e9fac9b8

Exclude ThirdParty, Utilities/MetaIO, and Utilities/KWSys as these
are maintained outside VTK.

Co-Author: Marcus D. Hanwell <marcus.hanwell@kitware.com>
Co-Author: Chris Harris <chris.harris@kitware.com>
Co-Author: Brad King <brad.king@kitware.com>

Move source files from their former monolithic VTK location to their new
location in modular VTK without modification.  This preserves enough
information for "git blame -M" and "git log --follow" to connect
modularized VTK files to their original location and history.

Co-Author: Marcus D. Hanwell <marcus.hanwell@kitware.com>
Co-Author: Chris Harris <chris.harris@kitware.com>
Co-Author: Brad King <brad.king@kitware.com>
Co-Author: Nikhil Shetty <nikhil.shetty@kitware.com>