1. 18 May, 2018 1 commit
    • Peter Wu's avatar
      SystemTools: Fix GetLineFromStream to avoid libc++ bug on OS X 10.7 · 898dc6b9
      Peter Wu authored
      LLVM libc++ as included with Mac OS X 10.7 suffers from an issue where
      the trailing character is discarded when the delimiter (LF) is not found
      within the given buffer size (1024).  The returned length is also 1024
      rather than 1023.
      
      This issue results in truncated reads as observed with CMake 3.11.0 on
      Mac OS X 10.7 and `cmake -E cmake_link_script link.txt`.
      
      Solve this by replacing `istream::getline` by `std::getline` which does
      not trigger the buffering issue.  There is one edge case that I decided
      to leave up to the callers though: a file containing `\0` previously
      resulted in line truncation, but is now included in the result.
      
      Tested with Mac OS X 10.7 and 10.11:
      
          -DCMAKE_OSX_DEPLOYMENT_TARGET=10.7 -DCMAKE_CXX_FLAGS=-stdlib=libc++
      
      and `./kwsysTestsCxx testSystemTools`.
      
      Issue: cmake/cmake#15039
      898dc6b9
  2. 15 May, 2018 1 commit
  3. 12 May, 2018 1 commit
  4. 11 May, 2018 1 commit
  5. 09 May, 2018 1 commit
  6. 24 Apr, 2018 2 commits
  7. 23 Apr, 2018 1 commit
  8. 19 Apr, 2018 1 commit
  9. 12 Apr, 2018 1 commit
  10. 11 Apr, 2018 1 commit
  11. 29 Mar, 2018 1 commit
  12. 28 Mar, 2018 1 commit
  13. 09 Mar, 2018 2 commits
  14. 08 Mar, 2018 1 commit
  15. 07 Mar, 2018 2 commits
  16. 06 Mar, 2018 2 commits
  17. 22 Feb, 2018 1 commit
  18. 21 Feb, 2018 1 commit
  19. 20 Feb, 2018 2 commits
  20. 01 Feb, 2018 1 commit
  21. 31 Jan, 2018 11 commits
  22. 23 Jan, 2018 1 commit
  23. 19 Jan, 2018 2 commits
  24. 17 Jan, 2018 1 commit