Ben Boeckel authored 4 years ago and Kitware Robot committed 4 years ago

435022fb win32: use the right preprocessor symbol check

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !29

Utkarsh Ayachit authored 4 years ago and Kitware Robot committed 4 years ago

59ac2a76 Added ability to check widget's size and aspect ratio.

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Merge-request: !26

e.g

check if the widget size is at least a given size:

<pqevent object=".../MultiViewWidget1" command="sizeGreaterOrEqual"
arguments="640,400" />

check if the widget aspect ratio matches:

<pqevent object=".../MultiViewWidget1" command="aspectRatio"
arguments="1.6" />

Ben Boeckel authored 4 years ago and Kitware Robot committed 4 years ago

2b5ae08f pqObjectNaming: align found name with requested name

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Cory Quammen <cory.quammen@kitware.com>
Merge-request: !24

Ben Boeckel authored 5 years ago and Kitware Robot committed 5 years ago

e21f51e9 cmake: hide the BUILD_EXAMPLES option if already defined

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Acked-by: Mathieu Westphal <mathieu.westphal@kitware.com>
Merge-request: !23

Aron Helser authored 5 years ago and Kitware Robot committed 5 years ago

37725876 Add multi-select record and replay to ItemViews

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !22

Watch the selectionChanged signal on ItemViews, and record
the ranges of item selection when multi-select is enabled.
Replay reconstructs the ranges from pairs of indexes.

Aron Helser authored 5 years ago and Kitware Robot committed 5 years ago

e4cbf115 Record and replay doubleClick for ItemView widgets.

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Cory Quammen <cory.quammen@kitware.com>
Merge-request: !21

Some non-editable widgets need the doubleClick event instead.
Playing an 'edit' event also is needed for ParaView tests.

Utkarsh Ayachit authored 5 years ago and Kitware Robot committed 5 years ago

8177fe4f Set combo-box text if it is editable

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Merge-request: !19

Also strip out some legacy code

Mathieu Westphal (Kitware) authored 5 years ago and Kitware Robot committed 5 years ago

916c61fc Allow events to be played individually

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Julien Finet <julien.finet@kitware.com>
Acked-by: Mathieu Westphal <mathieu.westphal@kitware.com>
Merge-request: !16

Play event was available but not accessible.
This can be usefull if a user needs to explicitly play the next event
while playing another one.

Ben Boeckel authored 6 years ago and Kitware Robot committed 6 years ago

89b053a5 cmake: add an option for building examples

Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !14

Utkarsh Ayachit authored 7 years ago and Kitware Robot committed 7 years ago

6434f092 Add ability to add custom library prefix/suffix.

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !12

Since QtTesting is often part of other projects, we add mechanism to
allow those projects to add prefix/suffix to the QtTesting library.

Utkarsh Ayachit authored 7 years ago and Kitware Robot committed 7 years ago

25869ff1 clang-format: fix code formatting
6aa39647 Add gitattributes.
1da4e67d Add clang-format file (same as ParaView).

Acked-by: Kitware Robot <kwrobot@kitware.com>
Reviewed-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !11

This run of `clang-format` cleanups indentation and spacing to match
ParaView style.

Ben Boeckel authored 7 years ago and Kitware Robot committed 7 years ago

bd8c472e clang-tidy: fix override issues

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Merge-request: !9

Utkarsh Ayachit authored 7 years ago and Kitware Robot committed 7 years ago

20f23d30 Fixes issues when test playback fails to find an object.

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Ben Boeckel <ben.boeckel@kitware.com>
Merge-request: !10

Fixes multiple issues when test playback failed to find an object.
1. The failure message was printed out twice. Fixed that. Only 1 call to
   `qCritical()` is sufficient.
2. `qCritical() << QString()` causes the '\n's to be escaped. Avoid
   that by converting QString to `char*`.
3. Don't report crazy long list of possible matches or available
   widgets. That's very useless and makes terminal (or output log)
   unreadable. Limit it to 20 matches.

This run of `clang-tidy` removes unnecessary `virtual` keywords and adds
`override` where necessary.

Utkarsh Ayachit authored 7 years ago and Kitware Robot committed 7 years ago

fe6abd40 Added ability to check a widget's size.

Acked-by: Kitware Robot <kwrobot@kitware.com>
Reviewed-by: Shawn Waldon <shawn.waldon@kitware.com>
Merge-request: !8

Adding a new command to check a widget's size.

e.g.

  <pqevent object=".../MultiViewWidget1" command="size" arguments="640,400" />

Jean-Christophe Fillion-Robin authored 7 years ago and Kitware Robot committed 7 years ago

46837aa3 test: Fix pqEventRecorderTest

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Acked-by: Mathieu Westphal <mathieu.westphal@kitware.com>
Merge-request: !6

Jean-Christophe Fillion-Robin authored 7 years ago and Kitware Robot committed 7 years ago

bcbe1708 test: Fix pq(Double)SpinBoxEventTranslatorTest

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Acked-by: Mathieu Westphal <mathieu.westphal@kitware.com>
Merge-request: !5

Jean-Christophe Fillion-Robin authored 7 years ago and Kitware Robot committed 7 years ago

70308a5c Fix -Woverloaded-virtual warning in custom event translator
8f3038e8 Fix -Woverloaded-virtual warning in custom event player

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Acked-by: Mathieu Westphal <mathieu.westphal@kitware.com>
Merge-request: !7

This commit fixes warning like one reported below occuring when imlementing
custom event translators:


```
In file included from /home/jcfr/Projects/Slicer/Libs/MRML/Widgets/qMRMLNodeComboBoxEventTranslator.h:28:0,
                 from /home/jcfr/Projects/Slicer/Base/QTGUI/qSlicerApplication.cxx:84:
/home/jcfr/Projects/Slicer-Release/CTK-build/QtTesting/pqWidgetEventTranslator.h:62:16: warning: ‘virtual bool pqWidgetEventTranslator::translateEvent(QObject*, QEvent*, int, bool&)’ was hidden [-Woverloaded-virtual]
   virtual bool translateEvent(QObject* object, QEvent* event, int eventType, bool& error);
                ^
In file included from /home/jcfr/Projects/Slicer/Base/QTGUI/qSlicerApplication.cxx:84:0:
/home/jcfr/Projects/Slicer/Libs/MRML/Widgets/qMRMLNodeComboBoxEventTranslator.h:43:16: warning:   by ‘virtual bool qMRMLNodeComboBoxEventTranslator::translateEvent(QObject*, QEvent*, bool&)’ [-Woverloaded-virtual]
   virtual bool translateEvent(QObject *Object, QEvent *Event, bool &Error);
                ^
```

This commit fixes warning like one reported below occuring when imlementing
custom event players:

```
In file included from /home/jcfr/Projects/Slicer/Libs/MRML/Widgets/qMRMLCheckableNodeComboBoxEventPlayer.h:25:0,
                 from /home/jcfr/Projects/Slicer/Base/QTGUI/qSlicerApplication.cxx:82:
/home/jcfr/Projects/Slicer-Release/CTK-build/QtTesting/pqWidgetEventPlayer.h:60:16: warning: ‘virtual bool pqWidgetEventPlayer::playEvent(QObject*, const QString&, const QString&, bool&)’ was hidden [-Woverloaded-virtual]
   virtual bool playEvent(
                ^
In file included from /home/jcfr/Projects/Slicer-Release/CTK-build/QtTesting/pqTreeViewEventPlayer.h:35:0,
                 from /home/jcfr/Projects/Slicer/Libs/MRML/Widgets/qMRMLTreeViewEventPlayer.h:25,
                 from /home/jcfr/Projects/Slicer/Base/QTGUI/qSlicerApplication.cxx:85:
/home/jcfr/Projects/Slicer-Release/CTK-build/QtTesting/pqAbstractItemViewEventPlayerBase.h:51:8: warning:   by ‘virtual bool pqAbstractItemViewEventPlayerBase::playEvent(QObject*, const QString&, const QString&, int, bool&)’ [-Woverloaded-virtual]
   bool playEvent(QObject* object, const QString& command,
        ^
```

This commit updates "pqDoubleSpinBoxEventTranslatorTest" and
"pqSpinBoxEventTranslatorTester" to account for changes introduced
in 61d84487 (Using isPrint() instead of isLetterOrNumber()).

The new behavior only record value numerical values associated with the
key event.

Ben Boeckel authored 7 years ago and Kitware Robot committed 7 years ago

6be6b822 cmake: don't set the minimum version if not the top-level

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Utkarsh Ayachit <utkarsh.ayachit@kitware.com>
Reviewed-by: Brad King <brad.king@kitware.com>
Merge-request: !4

See paraview#17161.

Mathieu Westphal (Kitware) authored 7 years ago and Kitware Robot committed 7 years ago

e936b75c Add feature to record interaction timings

Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: Joachim Pouderoux <joachim.pouderoux@kitware.com>
Acked-by: Julien Finet <julien.finet@kitware.com>
Merge-request: !2