GitLab

be470278 CTest: Fix regression in test timeout compuatation
Acked-by: Kitware Robot <kwrobot@kitware.com>
Acked-by: dublet <github@dublet.org>
Merge-request: !1568

Refactoring in commit 66419bc0 (CTest: convert timeouts to
std::chrono::duration, 2017-11-20) accidentally changed the logic used
to compute the timeout for a test when it starts.  It incorrectly limits
the maximum possible timeout to 2 minutes rather than 2 minutes less
than the total allowed test time remaining.  Update the new logic to
restore the original behavior.

Avoid subtracting 2 minutes from our "infinite" timeout value to avoid
creating very large timeouts that are not "infinite" and may exceed
integer type ranges.

a2031d3a CPack/RPM: check executable flags for debuginfo packages
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !1565

b8b87489 ExternalProject: Support substituting <DOWNLOAD_DIR>
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !1537

f313541a FindOpenCL: Add support for AMD OpenCL SDK Light
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !1562

f92304c7 CMakeVersion RC file: Split patch into 2 components
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !1552

b7100756 Merge branch 'backport-revert-server-target-backtraces' into revert-server-target-backtraces
976370d1 server: drop "ctestInfo" backtrace information
8b2736c7 server: Revert "Report backtraces in codemodel response"
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !1564

935848a8 GoogleTest: Add test for missing test executable
29731d89 GoogleTest: Add timeout to discovery
e99e3982 GoogleTest: Improve gtest_discover_tests messages
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !1534

Merge-request: !1534

Debuginfo packages can not be created from programs and
shared libraries that do not have execute permissions.

Merge-request: !1564

Backtrace information was included by commit 35a52bd1 (server: add
"ctestInfo" request to get test info, 2017-10-25) to match that already
provided for targets.  However, the backtrace representation uses too
much memory and needs to be dropped.  Remove it from test information.

Issue: #17502

The backtrace information is very repetitive and hugely increases the
size of the codemodel object.  We need to remove it until an alternative
representation can be developed.  Revert commit v3.10.0-rc1~393^2
(server: Report backtraces in codemodel response, 2017-06-20), except
for the protocol version number (because it indicates other new things).

Unfortunately this is incompatible with clients that expect the
"crossReferences" field in targets.  However, the regression in memory
usage is quite serious, especially on large projects, and therefore
breaks even older clients that do not use backtraces.  Since the
"crossReferences" field was only provided by one release (3.10.0), it is
simplest to revert it outright for 3.10.1.

Fixes: #17502

6ecd8b60 Help: Document that ASM should be enabled last
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !1560

9432f686 Add generator expression support to per-source COMPILE_DEFINITIONS
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !1546

79b241de cmake-gui: Update RegexExplorer for changes to KWSys
4a8bbc52 Merge branch 'upstream-KWSys' into update-kwsys
52a5c4a8 KWSys 2017-12-05 (9376537e)
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !1558

bde7513d FindMPI: Correct legacy variable handling
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !1557

2047eb36 FindMPI: Fix multiple configure runs
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !1556

Add a test to verify expected behavior when a test executable on which
gtest_discover_tests is invoked was not built. (The test for the newly
added timeout conveniently sets up this situation, so this new test was
almost trivial to add.)

Add a TIMEOUT option to gtest_discover_tests. This provides a
work-around in case a test goes out to lunch, rather than causing the
build to simply hang. (Although this is still a problem with the user's
project, hanging the build is not cool, especially in the case of
automatically running CI builds. It is much preferred that the build
should actively fail in this case, and it is trivially easy for us to
implement that.)

ASM should be enabled after C and/or CXX because we consider the
compilers for those languages as possible assemblers.

Issue: #17532

* upstream-KWSys:
  KWSys 2017-12-05 (9376537e)

Code extracted from:

    https://gitlab.kitware.com/utils/kwsys.git

at commit 9376537ec0e4770a28f4b1705cfacf79650f71b6 (master).

Upstream Shortlog
-----------------

Brad King (1):
      e9557f37 RegularExpression: Fix regression in 'find' method

Sebastian Holtermann (4):
      4d1e8738 RegularExpression: Make compile() reentrant (thread safe)
      64f80068 RegularExpression: Make find() reentrant (thread safe)
      bbc94ba8 RegularExpression: Remove unused code
      cff58f07 RegularExpression: New RegularExpressionMatch class

This allows users to specify different genex-based compile definitions for each file in a target.

Fixes: #17508

Merge-request: !1557

Merge-request: !1556

3519c8f2 utilities: Swapped to use std C++11 mutex/threading constructs
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !1551

2c06e9e7 include_external_msproject: Support non-Windows target platforms
c89e8522 cmGlobalGenerator: Add IsIncludeExternalMSProjectSupported method
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !1525

Due to a erroneous logical dependency on a temporary variable, FindMPI
would depend its FOUND status on the set of flags needed to support
compiler-implicit MPI support after the first configure run.

This behavior is especially causing a misreported NOT FOUND status after
the first run on MPI implementations without MPI compiler like MS-MPI or
MPICH2 on Windows.

6bffc13e Refactor per-source generator expression evaluation
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !1550

Due to a minor logic error, MPI_LIBRARY, MPI_EXTRA_LIBRARY and
MPI_<LANG>_LIBRARIES hints are currently not correctly handled and
discarded.

Additionally, if either C or CXX aren't enabled, there subsequent calls
to FindMPI will cause cache variables of the sort "MPI_MPI_EXTRA_LIBRARY-NOTFOUND"
to appear due to an error in the compatibility handling. (Doesn't affect
functionality)

bfcc2034 Update cpplint support to return 0 and mark warnings for CDash.
Acked-by: Kitware Robot <kwrobot@kitware.com>
Merge-request: !1544