1. 02 Feb, 2019 1 commit
  2. 01 Feb, 2019 7 commits
  3. 31 Jan, 2019 26 commits
  4. 30 Jan, 2019 6 commits
    • Harry Mallon's avatar
      install: Fix stripping on macOS · 20291e8e
      Harry Mallon authored
      On macOS the `strip` tool requires special arguments depending on the
      type of binary to be stripped.
      
      Fixes: #11367
      Fixes: #16499
      20291e8e
    • Brad King's avatar
      Ninja: Use deps=gcc for Intel Compiler on Windows · a624a3e1
      Brad King authored
      Ninja 1.9 supports the depfile format generated by this compiler.
      Use `deps = gcc` when the version of Ninja is new enough.
      
      Unfortunately the Intel Compiler for Windows does not properly
      escape spaces in paths written to a depfile so if there is a
      space in the path we must still fall back to `deps = msvc`.
      
      Fixes: #18855
      a624a3e1
    • Brad King's avatar
      Ninja: Detect when ninja is new enough to support a multi-line depfile · f4f3b6b9
      Brad King authored
      Ninja 1.9 supports the multi-line depfile format generated by the
      Intel Compiler for Windows.  Teach the global generator to detect
      when the version is new enough to support this.
      f4f3b6b9
    • Brad King's avatar
      Ninja: Drop unnecessary deptype customization infrastructure · 699cd032
      Brad King authored
      Do not pass `CMAKE_NINJA_DEPTYPE_<LANG>` in place of `deps = gcc`.
      If Ninja ever introduces a new dependency type we will likely need
      to update CMake for it anyway.
      699cd032
    • chuck cranor's avatar
      ParseImplicitIncludeInfo: keep implicit incl. consistent when rerunning cmake · 1293ed85
      chuck cranor authored
      The first time you run cmake, it sets the implicit include path
      to the value reported by the parser (and this value gets saved
      in CMake${lang}Compiler.cmake).  But if you re-run cmake,
      UnixPaths.cmake blindly appends an extra /usr/include to the
      value saved in CMake${lang}Compiler.cmake.  That should not be
      harmful in most cases, but we want later runs of cmake to be
      consistent with the initial one.  Resolve using a solution
      suggested by Brad King:
      
        - UnixPaths now sets the default implicit include path in a new
          variable named _CMAKE_${lang}_IMPLICIT_INCLUDE_DIRECTORIES_INIT
          This value is only used the first time cmake is run (by
          CMakeDetermineCompilerABI.cmake when it calls the implicit
          include parser).
      
        - if CMakeDetermineCompilerABI.cmake successfully calls the
          implicit include parser, it overwrites the value in
          _CMAKE_${lang}_IMPLICIT_INCLUDE_DIRECTORIES_INIT with the
          value returned by the parser
      
        - CMakeDetermineCompilerABI.cmake always sets
          CMAKE_${lang}_IMPLICIT_INCLUDE_DIRECTORIES to the above value
          of _CMAKE_${lang}_IMPLICIT_INCLUDE_DIRECTORIES_INIT
      
        - the final value of CMAKE_${lang}_IMPLICIT_INCLUDE_DIRECTORIES gets
          saved to CMake${lang}Compiler.cmake when it is regenerated after
          the compiler tests are done.
      
        - CMakeDetermineCompilerABI.cmake is only executed the first time cmake
          is run.  Additional runs of cmake directly load the implicit include
          path from the value saved in CMake${lang}Compiler.cmake (the parser
          and _INIT variable are not used).
      
      The above depends on UnixPaths.cmake being loaded to set the _INIT value
      before CMakeDetermineCompilerABI.cmake runs the implicit include parser.
      1293ed85
    • Brad King's avatar
      Merge topic 'tidy-use-equals-delete' · eb2c2386
      Brad King authored and Kitware Robot's avatar Kitware Robot committed
      b05b778a
      
       clang-tidy: Use `= delete`
      Acked-by: Kitware Robot's avatarKitware Robot <kwrobot@kitware.com>
      Rejected-by: vvs31415's avatarvvs31415 <vstakhovsky@fastmail.com>
      Merge-request: !2848
      eb2c2386