1. 29 Jan, 2019 1 commit
    • Brad King's avatar
      macOS: Restore compatibility for setting FRAMEWORK after install() · d9dd68cb
      Brad King authored
      The `FRAMEWORK` target property affects the way the `install()` command
      treats the target and so should be set first.  Our implementation
      assumed that this was always the case and led to an assertion failure.
      Prior to CMake 3.12 this was visible only when using an explicit
      `LIBRARY ... NAMELINK_ONLY` option, but commit 0212d7c7 (install: add
      NAMELINK_COMPONENT argument, 2018-04-18, v3.12.0-rc1~139^2~3) made
      it possible with a simple `LIBRARY DESTINATION`.
      
      Fully supporting out-of-order specification will require non-trivial
      refactoring to defer install generator creation to generate time.
      For now simply restore the old behavior of installing the framework
      to the library destination.
      
      Fixes: #18848
      d9dd68cb
  2. 14 Jan, 2019 2 commits
  3. 13 Jan, 2019 2 commits
    • Craig Scott's avatar
      cmake: Ensure source and binary dirs are set · 27eb7c5b
      Craig Scott authored
      If only the source dir is provided, the binary dir is assumed
      to be the working directory. If only the binary dir is provided
      and it doesn't yet have a CMakeCache.txt to provide the
      source dir, then the source dir is assumed to be the working
      directory. This logic was not previously being handled
      correctly when -S and/or -B options were involved.
      Furthermore, when both were missing, no suitable error
      message was provided and an empty string was used for
      the build directory.
      
      Fixes: #18707
      27eb7c5b
    • Craig Scott's avatar
      cmake: Stop processing if -P option lacks file name · a1adbc72
      Craig Scott authored
      While an error message was being logged, processing was
      continuing nonetheless except with the -P argument omitted.
      This could have allowed unintended effects if the remaining
      arguments formed a valid set of command line options.
      a1adbc72
  4. 11 Jan, 2019 2 commits
  5. 10 Jan, 2019 4 commits
  6. 09 Jan, 2019 1 commit
  7. 08 Jan, 2019 3 commits
  8. 13 Dec, 2018 1 commit
  9. 10 Dec, 2018 2 commits
  10. 07 Dec, 2018 4 commits
  11. 05 Dec, 2018 2 commits
  12. 28 Nov, 2018 1 commit
  13. 27 Nov, 2018 2 commits
  14. 26 Nov, 2018 4 commits
  15. 20 Nov, 2018 3 commits
  16. 19 Nov, 2018 6 commits