Skip to content

Pick block fixes

Shawn Waldon requested to merge shawn.waldon/paraview:pick-block-fixes into master

@utkarsh.ayachit This copies logic from the multiblock inspector panel to the context menu action handlers to stop the context menu from calling the multiblock inspector panel -- this was causing crashes when the multiblock that was right clicked on was not the active representation. This branch still has 3 issues:

  • - the multiblock inspector panel doesn't observe/update when you right click and set color or opacity
  • - the code to get the current opacity fails if there is no current opacity set for the block - it defaults to 0 rather than 1 (missing API in vtkSMDoubleMapProperty - HasElement(key) or GetElement(key, default))
  • - GetBlockName isn't converted yet. It fails safe without crashing but returns wrong results if the active representation is not the one clicked on.

This is a follow-up to !1420 (merged) to fix a crash I found while testing that fix.

Merge request reports