Commit c02a3137 authored by Ben Boeckel's avatar Ben Boeckel

clang-tidy: fix override issues

This run of `clang-tidy` removes unnecessary `virtual` keywords and adds
`override` where necessary.
parent ffa82bd9

Too many changes to show.

To preserve performance only 1000 of 1000+ files are displayed.

......@@ -42,13 +42,13 @@ class ParaViewMainWindow : public QMainWindow
public:
ParaViewMainWindow();
~ParaViewMainWindow();
~ParaViewMainWindow() override;
protected:
void dragEnterEvent(QDragEnterEvent* evt);
void dropEvent(QDropEvent* evt);
void showEvent(QShowEvent* evt);
void closeEvent(QCloseEvent* evt);
void dragEnterEvent(QDragEnterEvent* evt) override;
void dropEvent(QDropEvent* evt) override;
void showEvent(QShowEvent* evt) override;
void closeEvent(QCloseEvent* evt) override;
protected slots:
void showHelpForProxy(const QString& groupname, const QString& proxyname);
......
......@@ -88,7 +88,7 @@ public:
protected:
vtkAnimationPlayer();
~vtkAnimationPlayer();
~vtkAnimationPlayer() override;
friend class vtkCompositeAnimationPlayer;
......
......@@ -73,19 +73,19 @@ public:
protected:
vtkCompositeAnimationPlayer();
~vtkCompositeAnimationPlayer();
~vtkCompositeAnimationPlayer() override;
//@{
/**
* Delegated to the active animation player.
*/
virtual void StartLoop(double starttime, double endtime, double* playbackWindow) VTK_OVERRIDE;
virtual void EndLoop() VTK_OVERRIDE;
virtual double GetNextTime(double currentime) VTK_OVERRIDE;
void StartLoop(double starttime, double endtime, double* playbackWindow) VTK_OVERRIDE;
void EndLoop() VTK_OVERRIDE;
double GetNextTime(double currentime) VTK_OVERRIDE;
//@}
virtual double GoToNext(double start, double end, double currenttime) VTK_OVERRIDE;
virtual double GoToPrevious(double start, double end, double currenttime) VTK_OVERRIDE;
double GoToNext(double start, double end, double currenttime) VTK_OVERRIDE;
double GoToPrevious(double start, double end, double currenttime) VTK_OVERRIDE;
vtkAnimationPlayer* GetActivePlayer();
......
......@@ -96,19 +96,19 @@ public:
/**
* Overridden to ignore the calls when this->Enabled == false.
*/
virtual void Initialize() VTK_OVERRIDE;
virtual void Tick(double currenttime, double deltatime, double clocktime) VTK_OVERRIDE;
virtual void Finalize() VTK_OVERRIDE;
void Initialize() VTK_OVERRIDE;
void Tick(double currenttime, double deltatime, double clocktime) VTK_OVERRIDE;
void Finalize() VTK_OVERRIDE;
//@}
protected:
vtkPVAnimationCue();
~vtkPVAnimationCue();
~vtkPVAnimationCue() override;
//@{
virtual void StartCueInternal() VTK_OVERRIDE;
virtual void TickInternal(double currenttime, double deltatime, double clocktime) VTK_OVERRIDE;
virtual void EndCueInternal() VTK_OVERRIDE;
void StartCueInternal() VTK_OVERRIDE;
void TickInternal(double currenttime, double deltatime, double clocktime) VTK_OVERRIDE;
void EndCueInternal() VTK_OVERRIDE;
//@}
friend class vtkSMAnimationSceneProxy;
......
......@@ -35,12 +35,12 @@ public:
* currenttime is normalized to the time range between
* this key frame and the next key frame.
*/
virtual void UpdateValue(
void UpdateValue(
double currenttime, vtkPVAnimationCue* cueProxy, vtkPVKeyFrame* next) VTK_OVERRIDE;
protected:
vtkPVBooleanKeyFrame();
~vtkPVBooleanKeyFrame();
~vtkPVBooleanKeyFrame() override;
private:
vtkPVBooleanKeyFrame(const vtkPVBooleanKeyFrame&) VTK_DELETE_FUNCTION;
......
......@@ -63,15 +63,15 @@ public:
void SetTimeKeeper(vtkSMProxy*);
//@}
virtual void BeginUpdateAnimationValues() VTK_OVERRIDE {}
virtual void SetAnimationValue(int, double) VTK_OVERRIDE {}
virtual void EndUpdateAnimationValues() VTK_OVERRIDE;
void BeginUpdateAnimationValues() VTK_OVERRIDE {}
void SetAnimationValue(int, double) VTK_OVERRIDE {}
void EndUpdateAnimationValues() VTK_OVERRIDE;
void SetDataSourceProxy(vtkSMProxy* dataSourceProxy);
protected:
vtkPVCameraAnimationCue();
~vtkPVCameraAnimationCue();
~vtkPVCameraAnimationCue() override;
vtkPVRenderView* View;
vtkSMProxy* DataSourceProxy;
......
......@@ -73,17 +73,17 @@ public:
protected:
vtkPVCameraCueManipulator();
~vtkPVCameraCueManipulator();
~vtkPVCameraCueManipulator() override;
int Mode;
virtual void Initialize(vtkPVAnimationCue*) VTK_OVERRIDE;
virtual void Finalize(vtkPVAnimationCue*) VTK_OVERRIDE;
void Initialize(vtkPVAnimationCue*) VTK_OVERRIDE;
void Finalize(vtkPVAnimationCue*) VTK_OVERRIDE;
/**
* This updates the values based on currenttime.
* currenttime is normalized to the time range of the Cue.
*/
virtual void UpdateValue(double currenttime, vtkPVAnimationCue* cueproxy) VTK_OVERRIDE;
void UpdateValue(double currenttime, vtkPVAnimationCue* cueproxy) VTK_OVERRIDE;
vtkCameraInterpolator* CameraInterpolator;
vtkSMProxy* DataSourceProxy;
......
......@@ -43,12 +43,11 @@ public:
* this method is called to allow the key frame to use vtkCameraInterpolator2
* to do path-based interpolations for the camera.
*/
virtual void UpdateValue(
double currenttime, vtkPVAnimationCue* cue, vtkPVKeyFrame* next) VTK_OVERRIDE;
void UpdateValue(double currenttime, vtkPVAnimationCue* cue, vtkPVKeyFrame* next) VTK_OVERRIDE;
// Overridden, since these methods are not supported by this class.
virtual void SetKeyValue(unsigned int, double) VTK_OVERRIDE {}
virtual void SetKeyValue(double) VTK_OVERRIDE {}
void SetKeyValue(unsigned int, double) VTK_OVERRIDE {}
void SetKeyValue(double) VTK_OVERRIDE {}
virtual double GetKeyValue(unsigned int) { return 0; }
//@{
......@@ -85,7 +84,7 @@ public:
protected:
vtkPVCameraKeyFrame();
~vtkPVCameraKeyFrame();
~vtkPVCameraKeyFrame() override;
vtkCamera* Camera;
vtkCameraInterpolator2* Interpolator;
......
......@@ -54,11 +54,11 @@ public:
/**
* Overridden to pass on to the internal keyframe proxies.
*/
virtual void RemoveAllKeyValues() VTK_OVERRIDE;
virtual void SetKeyTime(double time) VTK_OVERRIDE;
virtual void SetKeyValue(double val) VTK_OVERRIDE { this->Superclass::SetKeyValue(val); }
virtual void SetKeyValue(unsigned int index, double val) VTK_OVERRIDE;
virtual void SetNumberOfKeyValues(unsigned int num) VTK_OVERRIDE;
void RemoveAllKeyValues() VTK_OVERRIDE;
void SetKeyTime(double time) VTK_OVERRIDE;
void SetKeyValue(double val) VTK_OVERRIDE { this->Superclass::SetKeyValue(val); }
void SetKeyValue(unsigned int index, double val) VTK_OVERRIDE;
void SetNumberOfKeyValues(unsigned int num) VTK_OVERRIDE;
//@}
//@{
......@@ -96,12 +96,11 @@ public:
* currenttime is normalized to the time range between
* this key frame and the next key frame.
*/
virtual void UpdateValue(
double currenttime, vtkPVAnimationCue* cue, vtkPVKeyFrame* next) VTK_OVERRIDE;
void UpdateValue(double currenttime, vtkPVAnimationCue* cue, vtkPVKeyFrame* next) VTK_OVERRIDE;
protected:
vtkPVCompositeKeyFrame();
~vtkPVCompositeKeyFrame();
~vtkPVCompositeKeyFrame() override;
int Type;
......
......@@ -86,7 +86,7 @@ protected:
virtual void UpdateValue(double currenttime, vtkPVAnimationCue* cueproxy) = 0;
vtkPVCueManipulator();