Commit 559ecc4e authored by Cory Quammen's avatar Cory Quammen

Change to breadth-first traversal when collapsing a KDTree

The MoveSubtree() function moves trees from lower down in the KDTree
up. The existing depth-first traversal recursive algorithm in this
function worked okay when descending the tree, but when moving back up
the tree, elements in the array would be clobbered before they were
moved to their correct destination. This would lead to some views
being incorrectly deleted and moved into the wrong location when a
level of the KDTree was being collapsed.

Change to a breadth-first algorithm so that elements in the tree are
always copied from lower to higher positions in the tree. This
resolves the incorrect subtree movement.
parent 2805aa2c
......@@ -38,7 +38,8 @@
#include "vtkWeakPointer.h"
#include <algorithm>
#include <assert.h>
#include <cassert>
#include <queue>
class vtkSMViewLayoutProxy::vtkInternals
......@@ -96,11 +97,37 @@ public:
Cell source_cell = this->KDTree[source];
this->KDTree[source] = Cell();
this->MoveSubtree(2 * destination + 1, 2 * source + 1);
this->MoveSubtree(2 * destination + 2, 2 * source + 2);
this->KDTree[destination] = source_cell;
// Do a breadth-first traversal of source and destination. This is to ensure that
// we swap elements in the KDTree in the proper order (moving from lower elements
// in the tree up) when moving the subtree up the tree.
std::queue<int> sourceQueue;
std::queue<int> destQueue;
int kdtreeSize = static_cast<int>(this->KDTree.size());
while (!sourceQueue.empty())
int currentSource = sourceQueue.front();
int currentDest = destQueue.front();
// Copy source to destination.
if (currentSource < kdtreeSize && currentDest < kdtreeSize)
this->KDTree[currentDest] = this->KDTree[currentSource];
this->KDTree[currentSource] = Cell();
// Push children onto queue
void Shrink()
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment