From 146838569b4f44ec6c64b61824a7136653df17a8 Mon Sep 17 00:00:00 2001 From: Ben Boeckel Date: Fri, 31 Jan 2025 21:08:16 +0100 Subject: [PATCH 1/4] ParaViewTesting: listen on `127.0.0.1`, not "any address" This resolves firewall prompt dialogs delaying tests on CI machines. Fixes: #22855 --- CMake/ParaViewTesting.cmake | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/CMake/ParaViewTesting.cmake b/CMake/ParaViewTesting.cmake index 3ecf039c1cb..e075a50efc0 100644 --- a/CMake/ParaViewTesting.cmake +++ b/CMake/ParaViewTesting.cmake @@ -24,7 +24,7 @@ function(paraview_add_test_driven) endif () set(_vtk_testing_python_exe "$") set(_vtk_test_python_args - --server $ + --server $ --bind-address 127.0.0.1 --client $ --dr) vtk_add_test_python(${ARGN}) endfunction () @@ -361,6 +361,7 @@ function (paraview_add_client_server_tests) _COMMAND_PATTERN __paraview_smtesting_args__ --server "$" + --bind-address 127.0.0.1 --enable-bt __paraview_args__ --client __paraview_client__ @@ -395,9 +396,11 @@ function (paraview_add_client_server_render_tests) _COMMAND_PATTERN __paraview_smtesting_args__ --data-server "$" + --bind-address 127.0.0.1 --enable-bt __paraview_args__ --render-server "$" + --bind-address 127.0.0.1 --enable-bt __paraview_args__ --client __paraview_client__ @@ -432,6 +435,7 @@ function (paraview_add_multi_server_tests count) __paraview_smtesting_args__ --test-multi-servers "${count}" --server "$" + --bind-address 127.0.0.1 --enable-bt --client __paraview_client__ --enable-bt @@ -462,6 +466,7 @@ function (paraview_add_tile_display_tests width height) _COMMAND_PATTERN __paraview_smtesting_args__ --server "$" + --bind-address 127.0.0.1 --enable-bt --tdx=${width} --tdy=${height} @@ -496,6 +501,7 @@ function (paraview_add_cave_tests num_ranks config) _COMMAND_PATTERN __paraview_smtesting_args__ --server "$" + --bind-address 127.0.0.1 --enable-bt # using offscreen to avoid clobbering display (although should not be # necessary) when running tests in parallel. -- GitLab From 6dd0d1a8409aea4d9a7668cf8710d623dbff72f8 Mon Sep 17 00:00:00 2001 From: Ben Boeckel Date: Fri, 31 Jan 2025 21:09:25 +0100 Subject: [PATCH 2/4] WIP: gitlab-ci: test on `ilum` The dialogs are known to cause issues on this machine. --- .gitlab/os-macos.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitlab/os-macos.yml b/.gitlab/os-macos.yml index 8c77559c2f4..de66a711aa4 100644 --- a/.gitlab/os-macos.yml +++ b/.gitlab/os-macos.yml @@ -58,6 +58,7 @@ spec: - shell - xcode-16.4 - nonconcurrent + - ilum ## macOS-specific scripts -- GitLab From d2f1a7de9cc71c34c2068085385e35e80e52c66f Mon Sep 17 00:00:00 2001 From: Ben Boeckel Date: Fri, 14 Nov 2025 12:35:17 -0500 Subject: [PATCH 3/4] vtkTCPNetworkAccessManager: use the bound address for the connection With the test suite now preferring to use `127.0.0.1` to avoid firewall interactions on systems, the bound address needs to be used instead of the hostname. Query the socket for its bound address and use it directly if available. --- Remoting/Core/vtkTCPNetworkAccessManager.cxx | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/Remoting/Core/vtkTCPNetworkAccessManager.cxx b/Remoting/Core/vtkTCPNetworkAccessManager.cxx index 49574f4fd58..95f269694fb 100644 --- a/Remoting/Core/vtkTCPNetworkAccessManager.cxx +++ b/Remoting/Core/vtkTCPNetworkAccessManager.cxx @@ -453,7 +453,13 @@ vtkMultiProcessController* vtkTCPNetworkAccessManager::WaitForConnection(int por vtksys::SystemInformation sys_info; sys_info.RunOSCheck(); - const char* sys_hostname = sys_info.GetHostname() ? sys_info.GetHostname() : "localhost"; + std::string const& boundAddress = server_socket->GetBoundAddress(); + const char* sys_hostname; + if (boundAddress.empty() || boundAddress == "0.0.0.0") { + sys_hostname = sys_info.GetHostname() ? sys_info.GetHostname() : "localhost"; + } else { + sys_hostname = boundAddress.c_str(); + } // print out a status message. cout << "Accepting connection(s): " << sys_hostname << ":" << server_socket->GetServerPort() -- GitLab From 64fde7a80f1ec537f758746227b24191080a1439 Mon Sep 17 00:00:00 2001 From: Ben Boeckel Date: Fri, 14 Nov 2025 12:36:26 -0500 Subject: [PATCH 4/4] WIP: VTK: bump for socket bound address API --- VTK | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/VTK b/VTK index 23daad7b687..7c2246ad978 160000 --- a/VTK +++ b/VTK @@ -1 +1 @@ -Subproject commit 23daad7b687725f22b1b5e24e3ac5f1042658c92 +Subproject commit 7c2246ad9789a9790416ea21dcf4eb3f2637be49 -- GitLab