Skip to content

use set_property to set PARAVIEW_PLUGIN_LOADER_PATHS in vtkPVPluginLoader

Drew Parsons requested to merge dparsons/paraview:vtkPVPluginLoader_defines into master

Use set_property APPEND instead of set_source_files_properties to add PARAVIEW_PLUGIN_LOADER_PATHS to compile definitions for vtkPVPluginLoader.cxx, in Remoting/Core/CMakeLists.txt

Otherwise the definition of BUILD_SHARED_LIBS earlier in CMakeLists.txt gets wiped.

This seems to be an inconsistency in the cmake API. set_property has the APPEND option, but set_source_files_properties does not.

Patch taken from debian https://salsa.debian.org/science-team/paraview/-/blob/f1e3c894269f997fd58d5642b40e0b3377fbf878/debian/patches/fix_PluginLoader_defines.patch

Closes: #22784 (closed)

Merge request reports