Commit e8e73c8e authored by Ben Boeckel's avatar Ben Boeckel
Browse files

cmake: ignore kit building in static builds

The configuration doesn't make much sense and it ends up avoiding corner
cases that aren't easy to resolve (namely how InSitu can reliably load
its own Python wrapping modules).
parent d453ea84
Pipeline #244023 waiting for manual action with stages
...@@ -18,7 +18,10 @@ mark_as_advanced(PARAVIEW_BUILD_LEGACY_SILENT) ...@@ -18,7 +18,10 @@ mark_as_advanced(PARAVIEW_BUILD_LEGACY_SILENT)
# Kits bundle multiple modules together into a single library, this # Kits bundle multiple modules together into a single library, this
# is used to dramatically reduce the number of generated libraries. # is used to dramatically reduce the number of generated libraries.
vtk_deprecated_setting(kits_default PARAVIEW_BUILD_WITH_KITS PARAVIEW_ENABLE_KITS "OFF") vtk_deprecated_setting(kits_default PARAVIEW_BUILD_WITH_KITS PARAVIEW_ENABLE_KITS "OFF")
option(PARAVIEW_BUILD_WITH_KITS "Build ParaView using kits instead of modules." OFF) cmake_dependent_option(PARAVIEW_BUILD_WITH_KITS "Build ParaView using kits instead of modules." OFF
# Static builds don't make sense with kits. Ignore the flag if shared
# libraries aren't being built.
"PARAVIEW_BUILD_SHARED_LIBS" OFF)
mark_as_advanced(PARAVIEW_BUILD_WITH_KITS) mark_as_advanced(PARAVIEW_BUILD_WITH_KITS)
vtk_deprecated_setting(external_default PARAVIEW_BUILD_WITH_EXTERNAL PARAVIEW_USE_EXTERNAL "OFF") vtk_deprecated_setting(external_default PARAVIEW_BUILD_WITH_EXTERNAL PARAVIEW_USE_EXTERNAL "OFF")
......
...@@ -324,9 +324,10 @@ More advanced build options are: ...@@ -324,9 +324,10 @@ More advanced build options are:
* `PARAVIEW_BUILD_WITH_EXTERNAL` (default `OFF`): When set to `ON`, the build * `PARAVIEW_BUILD_WITH_EXTERNAL` (default `OFF`): When set to `ON`, the build
will try to use external copies of all included third party libraries unless will try to use external copies of all included third party libraries unless
explicitly overridden. explicitly overridden.
* `PARAVIEW_BUILD_WITH_KITS` (default `OFF`): Compile ParaView into a smaller * `PARAVIEW_BUILD_WITH_KITS` (default `OFF`; requires
set of libraries. Can be useful on platforms where ParaView takes a long `PARAVIEW_BUILD_SHARED_LIBS`): Compile ParaView into a smaller set of
time to launch due to expensive disk access. libraries. Can be useful on platforms where ParaView takes a long time to
launch due to expensive disk access.
* `PARAVIEW_BUILD_ID` (default `""`): A build ID for the ParaView build. It * `PARAVIEW_BUILD_ID` (default `""`): A build ID for the ParaView build. It
can be any arbitrary value which can be used to indicate the provenance of can be any arbitrary value which can be used to indicate the provenance of
ParaView. ParaView.
......
# no-static-kits
ParaView no longer allows building kits with static builds. There are issues
with InSitu modules being able to reliably load Python in such configurations.
However, the configuration doesn't make much sense in the first place since the
goal of kits is to reduce the number of libraries that need to be loaded at
runtime and static builds do not have this problem.
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment