Skip to content
Snippets Groups Projects

Update to v5.6.0 rc1

Merge request reports

Pipeline #117735 passed

Pipeline passed for 54db8446 on cory.quammen:update-to-v5.6.0-RC1

Approval is optional

Merged by Kitware RobotKitware Robot 6 years ago (Sep 13, 2018 4:48pm UTC)

Merge details

  • Changes merged into master with 54db8446.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Warnings:

    • the merge request is marked as a work-in-progress.

    The warnings do not need to be fixed, but it is recommended to do so.

  • Author Maintainer

    Do: test

  • This merge request has been queued for testing. Test results may be viewed on:

    • CDash (master)
    • Buildbot (master) (only visible from inside Kitware)

    Branch-at-master: 265ed555

  • Author Maintainer

    Do: test --stop

  • Halting tests upon request

  • Cory Quammen added 1 commit

    added 1 commit

    • ea7de625 - Update the default version to 5.6.0-RC1

    Compare with previous version

  • Warnings:

    • the merge request is marked as a work-in-progress.

    The warnings do not need to be fixed, but it is recommended to do so.

  • Author Maintainer

    Do: test

  • This merge request has been queued for testing. Test results may be viewed on:

    • CDash (master)
    • Buildbot (master) (only visible from inside Kitware)

    Branch-at-master: ea7de625

  • Cory Quammen added 2 commits

    added 2 commits

    • fa9e9d4e - boxlib: Update to get parallel build fix
    • e739ef35 - Update the default version to 5.6.0-RC1

    Compare with previous version

  • Warnings:

    • the merge request is marked as a work-in-progress.

    The warnings do not need to be fixed, but it is recommended to do so.

  • Author Maintainer

    Do: test -i pvbinsdash

  • This merge request has been queued for testing. Test results may be viewed on:

    • CDash (master)
    • Buildbot (master) (only visible from inside Kitware)

    Branch-at-master: e739ef35

  • +1

    The current home for pvbinsdash doesn't have the convoluted X setup done on its normal home, so tests failing is expected at the moment. It will be verified as part of the normal release process.

  • Author Maintainer

    @ben.boeckel One last thing to resolve: hera is failing with

    C:\bbd\6c27b535\build>ninja
    [2/4] Performing build step for 'paraview'
    FAILED: superbuild/paraview/stamp/paraview-build
    cmd.exe /C "cd /D C:\bbd\6c27b535\build\superbuild\paraview\build && "C:/support/cmake/3.11.2/bin/ctest.exe" --launch --target-name TARGET_NAME --build-dir C:\bbd\6c27b535\build\superbuild --output C:\bbd\6c27b535\build\superbuild\paraview\stamp\paraview-build --  C:\support\cmake\3.11.2\bin\cmake.exe -P C:/bbd/6c27b535/build/superbuild/sb-paraview-build.cmake && "C:/support/cmake/3.11.2/bin/ctest.exe" --launch --target-name TARGET_NAME --build-dir C:\bbd\6c27b535\build\superbuild --output C:\bbd\6c27b535\build\superbuild\paraview\stamp\paraview-build --  C:\support\cmake\3.11.2\bin\cmake.exe -E touch C:/bbd/6c27b535/build/superbuild/paraview/stamp/paraview-build"
    [1/102] Generating moc_ParaViewMainWindow.cpp
    ninja: fatal: CreateProcess: The parameter is incorrect.
    
    CMake Error at C:/bbd/6c27b535/build/superbuild/sb-paraview-build.cmake:47 (message):
      Failed with exit code 1
    
    
    ninja: build stopped: subcommand failed.

    However, master builds were building fine before this branch point. See, e.g., https://open.cdash.org/viewFiles.php?buildid=5528916 so I'm not sure what is going on.

  • ninja: fatal: CreateProcess: The parameter is incorrect.

    Usually that means the command line is too long :/ .

  • Author Maintainer

    More specifically:

    [94/102] Linking CXX shared library bin\plugins\NonOrthogonalSource\NonOrthogonalSource.dll
       Creating library lib\NonOrthogonalSource.lib and object lib\NonOrthogonalSource.exp
    ninja: fatal: CreateProcess: The parameter is incorrect.iles\paraview.dir\Icon.rc.res

    This is odd because that source isn't new.

  • Author Maintainer

    I think the above is an intermingled error message. Running with ninja -j 1 shows just

    ninja: fatal: CreateProcess: The parameter is incorrect.

    I'm going to run ninja clean and then ninja.

  • Usually it is some .rc file compilation that causes this error. See cmake/cmake#16171. If it isn't, we probably need to just use response files in some add_custom_command or add_custom_target.

  • Author Maintainer

    I guess the difference between the succeeding master superbuilds and failing RC1 builds is the location of the ParaView source. Maybe we could work around the issue by changing that directory?

    I tried creating the resource file for the icon manually after stripping out all the -I options. It appeared to succeed, but I got the same error running ninja afterwards.

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading