1. 13 Jan, 2022 4 commits
  2. 10 Jan, 2022 1 commit
  3. 06 Jan, 2022 2 commits
    • Kenneth Moreland's avatar
      Pre-allocate arrays for MergePartitionedDataSet · 10f21b21
      Kenneth Moreland authored
      The initial implementation of `MergePartitionedDataSet` would grow each
      array as it was generated. As each partition was revisited, the arrays
      being merged would be reallocated and data appended to the end. Although
      this works, it is slower than necessary. Each reallocation has to copy
      the previously saved data into the newly allocated memory space.
      
      This new implementation first counts how big each array should be and
      then copies data from each partition into the appropriate location of
      each dataset.
      
      Also changed the templating of how fields are copied so that all field
      types are supported, not just those in the common types.
      10f21b21
    • Li-Ta Lo's avatar
      Merge topic 'NewFilter' · e5639b1f
      Li-Ta Lo authored and Kitware Robot's avatar Kitware Robot committed
      0801b242 add newline
      c9b8a31b add NewFilterField.cxx so EXPORT_CORE would work
      548df843 add CORE_EXPORT
      9ff52a98 Set default ActiveCoordinateSystemIndex to 0.
      90992406 Merge branch 'NewFilter' of gitlab.kitware.com:ollielo/vtk-m into NewFilter
      4a63b745 uniform treatment of primary/secondary field/coordinate_system
      6461857e Merge branch 'master' into NewFilter
      3720006d
      
       change based on code review
      ...
      Acked-by: Kitware Robot's avatarKitware Robot <kwrobot@kitware.com>
      Acked-by: Kenneth Moreland's avatarKenneth Moreland <morelandkd@ornl.gov>
      Merge-request: !2648
      e5639b1f
  4. 05 Jan, 2022 9 commits
  5. 04 Jan, 2022 5 commits
  6. 03 Jan, 2022 5 commits
    • Kenneth Moreland's avatar
      Store UnknownCellSet instead of DynamicCellSet in DataSet · 0a89a5ff
      Kenneth Moreland authored
      `UnknownCellSet` is an updated replacement for `DynamicCellSet`. The
      next step in the replacement is to change `DataSet` to use the new
      class.
      
      Also replaced `DynamicCellSet` with `UnknownCellSet` in a few
      places where `DynamicCellSet.h` was not directly included (and
      therefore now no longer included at all). This change would have
      to be made at some point anyway.
      0a89a5ff
    • Kenneth Moreland's avatar
      Merge topic 'less-device-compile' · c1d3bd85
      Kenneth Moreland authored and Kitware Robot's avatar Kitware Robot committed
      a2ab460f
      
       Compile more sources without device compiler
      Acked-by: Kitware Robot's avatarKitware Robot <kwrobot@kitware.com>
      Acked-by: Li-Ta Lo's avatarLi-Ta Lo <ollie@lanl.gov>
      Merge-request: !2658
      c1d3bd85
    • Kenneth Moreland's avatar
      Better fallback for ArrayGetValue · 5b34e6f7
      Kenneth Moreland authored
      To avoid having to use a device compiler every time you wish to use
      `ArrayGetValue`, the actual implementation is compiled into the `vtkm_cont`
      library. To allow this to work for all the templated versions of
      `ArrayHandle`, the implementation uses the extract component features of
      `UnknownArrayHandle`. This works for most common arrays, but not all
      arrays.
      
      For arrays that cannot be directly represented by an `ArrayHandleStride`,
      the fallback is bad. The entire array has to be pulled to the host and then
      copied serially to a basic array.
      
      For `ArrayGetValue`, this is just silly. So, for arrays that cannot be
      simply represented by `ArrayHandleStride`, make a fallback that just uses
      `ReadPortal` to get the data. Often this is not the most efficient method,
      but it is better than the current alternative.
      5b34e6f7
    • Kenneth Moreland's avatar
      Compile more sources without device compiler · a2ab460f
      Kenneth Moreland authored
      We have been doing a better job at hiding device code (and moving code
      into libraries). Smoke out source that no longer needs to be compiled by
      device compilers.
      a2ab460f
    • Kenneth Moreland's avatar
      Add secondary image for MapperConnectivity test · 1981f906
      Kenneth Moreland authored
      It looks like there might be a precision problem that is causing some
      rays to terminate before they start. However, I leave that to someone
      else to diagnose.
      1981f906
  7. 30 Dec, 2021 5 commits
    • Kenneth Moreland's avatar
      Add secondary image for MapperQuad test · d4d1ef95
      Kenneth Moreland authored
      I suspect that this test is not actually mapping colors correctly, and
      the difference in images might be part of that problem. However, I leave
      that to someone else to diagnose.
      d4d1ef95
    • Kenneth Moreland's avatar
      Reduce templating in RenderTest code · 54c1a85d
      Kenneth Moreland authored
      The `Canvas`, `Mapper`, and `View` classes use virtual polymorphism
      amongst each other, so might as well use it.
      54c1a85d
    • Kenneth Moreland's avatar
      c0fbe5f3
    • Kenneth Moreland's avatar
      Expand test_equal_images · 0fe9300e
      Kenneth Moreland authored
      The `test_equal_images` function has been expanded to supply the
      generated image in a `Canvas` or a `DataSet` in addition to a `View`.
      Much of the templating code has been removed from `test_equal_images`
      and most of the code has moved into the `vtkm_rendering_testing`
      library.
      0fe9300e
    • Kenneth Moreland's avatar
      Redefine RenderTest interface for library · 12e11641
      Kenneth Moreland authored
      The previous functions that enabled the render regression tests were
      heavily templated, which required every test using rendering to
      recompile the entire rendering system being used. Changed the interface
      to not rely on templating so that the RenderTest method can be moved
      into a library.
      
      Also moved the options into a struct where they can be better managed.
      The render testing functions tended to have lots of arguments that were
      difficult to manage. Instead, created a single `struct` that holds all
      the potential options. That way when someone specifies on option, it is
      clear what option is being set.
      12e11641
  8. 29 Dec, 2021 4 commits
    • Kenneth Moreland's avatar
      Add struct for passing options to render tests · afa8c908
      Kenneth Moreland authored
      This allows you to set the parameters of the `test_equal_image` without
      having to call it directly.
      afa8c908
    • Kenneth Moreland's avatar
      Rename RegressionTests to RenderTests · 9173d6bb
      Kenneth Moreland authored
      The tests that used rendering and image comparison were named
      `RegressionTest*`. However, this name is not very descriptive as all the
      tests are regression tests. These have all been renamed to be
      `RenderTest*` to more clearly indicate that they are tests that use
      rendering as part of the test.
      9173d6bb
    • Kenneth Moreland's avatar
      Move non-templated testing functions to library · d29532c2
      Kenneth Moreland authored
      Previously, all methods in the `vtkm::cont::testing::Testing` class were
      inlined in the header file. This makes sense for the methods that are
      templated, but not so much for methods that are not templated.
      
      Although this change provides minimal improvements with compile times
      and object sizes (maybe). But the real benefit is that some of these
      methods declare static objects. When declared in inlined functions, a
      different object will be created for each translation unit. This can
      lead to unexpected behavior when multiple versions of a supposed
      singleton static object exist.
      d29532c2
    • Kenneth Moreland's avatar
  9. 17 Dec, 2021 4 commits
  10. 16 Dec, 2021 1 commit