1. 04 Nov, 2016 3 commits
    • Kitware Robot's avatar
      Revise C++ coding style using clang-format · 6c973b46
      Kitware Robot authored
      Run the `clang-format.bash` script to update all our C and C++ code to a new
      style defined by `.clang-format`.  Use `clang-format` version 3.8.
      
      * If you reached this commit for a line in `git blame`, re-run the blame
        operation starting at the parent of this commit to see older history
        for the content.
      
      * See the parent commit for instructions to rebase a change across this
        style transition commit.
      
      Change-Id: Ie3aedc03bfe5c3999d4a077fafb8c6f3bbffc5c5
      6c973b46
    • Brad King's avatar
      Simplify KWSys per-source license notices · c41c1bc4
      Brad King authored
      Per-source copyright/license notice headers that spell out copyright holder
      names and years are hard to maintain and often out-of-date or plain wrong.
      Precise contributor information is already maintained automatically by the
      version control tool.  Ultimately it is the receiver of a file who is
      responsible for determining its licensing status, and per-source notices are
      merely a convenience.  Therefore it is simpler and more accurate for
      each source to have a generic notice of the license name and references to
      more detailed information on copyright holders and full license terms.
      
      Our `Copyright.txt` file now contains a list of Contributors whose names
      appeared source-level copyright notices.  It also references version control
      history for more precise information.  Therefore we no longer need to spell
      out the list of Contributors in each source file notice.
      
      Replace KWSys per-source copyright/license notice headers with a short
      description of the license and links to `Copyright.txt` and online
      information available from "https://cmake.org/licensing#kwsys".
      
      Run the `filter-notices.bash` script to perform the replacements mechanically.
      Manually fix up the shebang line in one file.
      
      Change-Id: I8497f7c868664dcf54a8608ab302ad93c860b334
      c41c1bc4
    • Brad King's avatar
      Sort includes to stabilize include order w.r.t. clang-format · 15e90a3c
      Brad King authored
      The clang-format tool sorts `#include` lines within contiguous blocks.
      Separate blocks with blank lines and sort the include lines within them
      so that clang-format does not re-order anything.
      
      Change-Id: I96d6828f470b9a234464972172d46afab322487c
      15e90a3c
  2. 09 Mar, 2016 1 commit
  3. 22 Feb, 2016 1 commit
    • Zack Galbreath's avatar
      Process: Allow timeout to be changed after child starts · 4847aedd
      Zack Galbreath authored
      Recompute `TimeoutTime` after `Timeout` changes so that one may modify
      the timeout of a process after it has started running by calling the
      normal `kwsysProcess_SetTimeout` method.
      
      Change-Id: I460a02d0d3c5f107b844abb56e39f5c844e7e3fb
      4847aedd
  4. 08 Jan, 2016 1 commit
  5. 01 Dec, 2015 1 commit
  6. 22 Jul, 2015 1 commit
    • James Johnston's avatar
      Process: Fix leaked file descriptor in ProcessUNIX · 52874e6a
      James Johnston authored
      kwsysProcess leaked a file descriptor every time a process would start.
      This was causing exhaustion of available file descriptors on some
      operating systems (e.g. Mac OS X).
      
      Change-Id: I78eed0755f9766065c36460ffab468b2d7d1df12
      52874e6a
  7. 15 Jul, 2015 3 commits
    • James Johnston's avatar
      Process: Added initial support for process groups. · ef517b19
      James Johnston authored
      kwsysProcess_SetOption now allows you to specify a new
      kwsysProcess_Option_CreateProcessGroup option, which creates the
      process in a new process group (Windows/UNIX) and a new session
      (UNIX).  Child process groups receive signals separately from their
      parents.  This allowed for the introduction of the new
      kwsysProcess_Interrupt function, which allows one to safely request
      the child process in its own group to terminate.  The Ctrl+C handler
      also manually sends that signal to child process groups, since it's
      no longer automatic.
      
      Change-Id: Id0a420ad65f1b1c1d299ac0eb95fbb8b50a52409
      ef517b19
    • James Johnston's avatar
      Process: Wait for children to terminate on Ctrl+C. · faff2ab0
      James Johnston authored
      The following applies to any KWSys console app on Windows or UNIX
      (e.g. cmake.exe):  The default behavior of such an app when Ctrl+C is
      pressed is to call ExitProcess or _exit.  If the user has a
      subprocess open (e.g. by way of cmake --build) when this happens, the
      subprocess will be orphaned because the kwsys-based program will
      immediately exit.  This can lead to odd behavior such as the orphaned
      subprocess continuing to run and mix output with the operating system
      shell.  We prevent this behavior on Windows by tracking all
      subprocesses and waiting for their termination when Ctrl+C is pressed
      before allowing the call to ExitProcess to proceed.  On UNIX, we reap
      every single child process and then call _exit.
      
      Change-Id: Iebd2eedb1c06719e9797dd5b1309d473145476a8
      faff2ab0
    • James Johnston's avatar
      Process: Remove trailing whitespace in ProcessUNIX.c · 4cd8846c
      James Johnston authored
      Change-Id: I821de08dd10b5f1f4af6287a5d7dc6e03e2c1e78
      4cd8846c
  8. 05 May, 2015 2 commits
    • Brad King's avatar
      Process: Add option to merge stdout/stderr · 34fceb50
      Brad King authored
      When enabled, ignore all stderr pipe configuration options and
      just give the child a copy of stdout as its stderr.
      
      Change-Id: I87a64657cc701b706da78f7bfc56ad0071383372
      34fceb50
    • Brad King's avatar
      Process: Refactor child pipe creation · 8c8b2273
      Brad King authored
      Consolidate logic to prepare stdin/stdout/stderr in the same way
      before starting any processes.  This will simplify alternative
      approaches to select the child pipes.
      
      Change-Id: I36175a8cfc2578543103297420908a539ad71a3a
      8c8b2273
  9. 09 Jan, 2015 1 commit
  10. 07 Aug, 2014 1 commit
    • Brad King's avatar
      Add assert() to quiet Clang scan-build warnings · 4d526097
      Brad King authored
      In ProcessUNIX.c, testProcess.c, and testCommandLineArguments1.cxx, add
      assert() calls to tell Clang scan-build that we do not expect certain
      pointers to be NULL.
      
      Change-Id: I4a2b035cf58198606b4698c9d0e2048a66f15fd0
      4d526097
  11. 19 May, 2014 1 commit
    • Brad King's avatar
      Process: Workaround child kill trouble on Cygwin · c282e64f
      Brad King authored
      When we kill a child we send SIGSTOP first so that we can traverse its
      child processes recursively.  On unwinding the recursion we then send
      SIGKILL.  Current Cygwin has trouble when both signals are sent in quick
      succession by the parent process.  Add a usleep(1) after sending the
      first signal to give up our time slice and give Cygwin a chance to
      process the first signal before sending the second.
      
      Change-Id: I75ab55cf969a0ea6104a9798c761c0ba1fcd1dbc
      c282e64f
  12. 03 Dec, 2013 1 commit
    • Rolf Eike Beer's avatar
      ProcessUNIX: close /proc entry before starting recursion · b2fd7da5
      Rolf Eike Beer authored
      If a group of processes needs to be terminated recursively the entry in /proc
      doesn't need to be kept open during the recursion as all the interesting
      information was already read from it. Especially in case of deeper recursion
      this lowers the memory pressure.
      
      Change-Id: I95b969f42c8dd68b57cdaf8fc1b705f358f1dc58
      b2fd7da5
  13. 21 Mar, 2013 1 commit
  14. 25 Jan, 2013 1 commit
  15. 11 Jan, 2013 1 commit
  16. 06 Jan, 2013 1 commit
  17. 06 Oct, 2012 1 commit
  18. 11 Jun, 2010 2 commits
  19. 11 May, 2010 1 commit
    • Brad King's avatar
      KWSys: Process tree kill for kFreeBSD, GNU/Hurd · edae70c0
      Brad King authored
      kFreeBSD and Hurd have the same userland as Linux.  This change is
      necessary to enable kwsysProcessKill() to kill child processes on
      kFreeBSD.  The bug was detected by CTestTestTimeout test.
      
      Patch from "Modestas Vainius <modestas@vainius.eu>".
      See issue #10432.
      edae70c0
  20. 19 Apr, 2010 1 commit
  21. 18 Mar, 2010 1 commit
  22. 12 Jan, 2010 1 commit
  23. 01 Dec, 2009 2 commits
    • Brad King's avatar
      KWSys: List processes with "ps -ef" on OpenSolaris · b9b9aeda
      Brad King authored
      In order to kill process trees we need to list all processes to find
      those whose parent we are killing.  We implement process listing on
      OpenSolaris by using "ps -ef" and parsing the resulting format:
      
           UID   PID  PPID   C    STIME TTY         TIME CMD
           %*s    %d    %d   %*[^\n]\n
      b9b9aeda
    • Brad King's avatar
      KWSys: Use "ps -Af" for process list on QNX · 5f7195d1
      Brad King authored
      In order to kill process trees we need to list all processes to find
      those whose parent we are killing.  We implement process listing on QNX
      using "ps -Af" and parsing the resulting format:
      
        UID        PID       PPID  C STIME TTY          TIME CMD
        %*d         %d         %d  %*[^\n]\n
      5f7195d1
  24. 30 Nov, 2009 1 commit
    • Brad King's avatar
      KWSys: Restore SIGSTOP/SIGKILL to end process tree · 2988287a
      Brad King authored
      On UNIX systems we kill a tree of processes by performing a DFS walk of
      the tree.  We send SIGSTOP to each process encountered, recursively
      handle its children, and then send SIGKILL.
      
      We once used the above approach in the past, but it was removed by the
      commit "Do not send both SIGSTOP and SIGKILL when killing a process".
      The commit was meant to work-around an OS X 10.3 bug in which the child
      would not always honor SIGKILL after SIGSTOP.  At the time we wrongly
      assumed that the process tree remains intact after SIGKILL and before
      the child is reaped.  In fact the grandchildren may be re-parented to
      ppid=1 even before the child is reaped, which causes the DFS walk to
      miss them.
      2988287a
  25. 19 Oct, 2009 1 commit
  26. 28 Sep, 2009 1 commit
    • Brad King's avatar
      Convert KWSys to OSI-approved BSD License · 62db264e
      Brad King authored
      This converts the KWSys license to a pure 3-clause OSI-approved BSD
      License.  We drop the previous license clause requiring modified
      versions to be plainly marked.  We also update the KWSys copyright to
      cover the full development time range.
      62db264e
  27. 13 Jul, 2009 1 commit
    • Brad King's avatar
      ENH: Provide unix-sytle command line parsing · e4e7f37c
      Brad King authored
      Add System_Parse_CommandForUnix to the KWSys System interface as a
      utility to parse a unix-style command line.  Move the existing
      implementation out of ProcessUNIX.  Add a flags argument reserved for
      future use in providing additional behavior.
      e4e7f37c
  28. 12 Jun, 2009 2 commits
  29. 10 Jun, 2009 2 commits
    • Brad King's avatar
      ENH: Teach KWSys Process basic VMS support · 48d72f12
      Brad King authored
      This achieves basic process execution on OpenVMS.  We use work-arounds
      for different fork()/exec() behavior and a lack of select().
      
      VMS emulates fork/exec using setjmp/longjmp to evaluate the child and
      parent return cases from fork.  Therefore both must be invoked from the
      same function.
      
      Since select() works only for sockets we use the BeOS-style polling
      implementation.  However, non-blocking reads on empty pipes cannot be
      distinguished easily from the last read on a closed pipe.  Therefore we
      identify end of data by an empty read after the child terminates.
      48d72f12
    • Brad King's avatar
      BUG: Fix non-select process impl without timeout · 6eac6c06
      Brad King authored
      This avoids use of an uninitialized value in the KWSys ProcessUNIX
      polling implementation when no timeout is given.
      6eac6c06
  30. 23 Apr, 2009 1 commit
  31. 16 Mar, 2009 1 commit