1. 14 Aug, 2013 1 commit
    • Rolf Eike Beer's avatar
      SystemInformation: fix truncation warnings · dbc8fa1b
      Rolf Eike Beer authored
      Fixes the following truncation warnings from g++ 4.8:
      
      kwsys/SystemInformation.cxx: In member function 'int cmsys::SystemInformationImplementation::GetFullyQualifiedDomainName(std::string&)':
      kwsys/SystemInformation.cxx:1738:31: warning: conversion to 'socklen_t {aka unsigned int}' from 'long unsigned int' may alter its value [-Wconversion]
               = (fam==AF_INET?sizeof(struct sockaddr_in):sizeof(struct sockaddr_in6));
                                     ^
      kwsys/SystemInformation.cxx:1738:58: warning: conversion to 'socklen_t {aka unsigned int}' from 'long unsigned int' may alter its value [-Wconversion]
               = (fam==AF_INET?sizeof(struct sockaddr_in):sizeof(struct sockaddr_in6));
                                                                ^
      kwsys/SystemInformation.cxx: In member function 'bool cmsys::SystemInformationImplementation::QueryLinuxMemory()':
      kwsys/SystemInformation.cxx:3839:33: warning: conversion to 'int' from 'long unsigned int' may alter its value [-Wconversion]
           char *r=fgets(buffer, sizeof(buffer), fd); // Skip "total: used:..."
                                       ^
      
      Change-Id: I1016a7e31325ee550322dde7a21ffc92d6ca49dc
      dbc8fa1b
  2. 06 Aug, 2013 2 commits
  3. 02 Aug, 2013 1 commit
    • Burlen Loring's avatar
      SystemInformation : Better stack trace · 1d882d4c
      Burlen Loring authored
      Add supprt for C++ name demangling during call stack
      introspection. This will be enabled at compile time
      if the required system libraries,header files, and
      compiler features are detected. Add a method so that
      the stack trace may be obtained on demand not just
      from within the stack trace signal handler.
      
      Change-Id: Ie829f4b24ab331e39b97f54e63564df70f129b7e
      1d882d4c
  4. 26 Jul, 2013 1 commit
  5. 24 Jul, 2013 1 commit
  6. 10 Jul, 2013 1 commit
    • Brad King's avatar
      SystemTools: Implement IsSubDirectory without loop · beef6819
      Brad King authored
      The loop condition "while ( path.size() > dir.size() )" assumes that
      eventually path will be no longer than dir but "c:/" will always be
      longer than "/" and loop forever.  Simplify the implementation to avoid
      the loop and the assumption.
      
      Change-Id: I5613c7554ebd05b12cfe4882ac3bec4ecaa6e0ae
      CMake-Issue: 14283
      beef6819
  7. 01 Jul, 2013 1 commit
  8. 24 Jun, 2013 1 commit
    • Cory Quammen's avatar
      SystemTools: MakeDirectory() reports failure if path is file · 3d1d4e7c
      Cory Quammen authored
      If the path passed to MakeDirectory() pointed to an existing file (not
      directory), it would return true indicating that the directory was
      successfully created even though creation of the directory failed.
      Now it returns true only when the existing path is a directory and
      returns false otherwise.
      
      Change-Id: Ieb3e6352d63868c824df35f19187a8d396f75296
      3d1d4e7c
  9. 03 Jun, 2013 1 commit
  10. 31 May, 2013 2 commits
    • Brad King's avatar
      SystemTools: Touch with better than 1s resolution if possible · dccf7725
      Brad King authored
      On Windows use CreateFile (with FILE_FLAG_BACKUP_SEMANTICS so it works
      for directories), GetSystemTimeAsFileTime, and SetFileTime to touch.  On
      other platforms prefer utimensat, then utimes, then utime.
      
      Change-Id: Ie85fe3766661803e66f39975a147cd6f7320ea59
      CMake-Issue: 14020
      dccf7725
    • Brad King's avatar
      SystemTools: Use COMPILE_DEFINITIONS to pass platform tests · e3370418
      Brad King authored
      Replace use of COMPILE_FLAGS with COMPILE_DEFINITIONS for the
      SystemTools.cxx source file property and spell out each definition on
      its own line.
      
      Change-Id: I213326b25fc7510107b78a8e233a3198862d9309
      e3370418
  11. 29 May, 2013 3 commits
  12. 28 May, 2013 1 commit
    • Brad King's avatar
      SystemTools: Fix FileIsDirectory with long paths · 9fd64779
      Brad King authored
      Allocate a buffer large enough to hold the input path when removing a
      trailing slash.  Use a local stack buffer when it is large enough and
      fall back to heap allocation otherwise.
      
      Change-Id: Ibc4b4c96c7b0fafae9f4b5cd7ea894bdd605a098
      9fd64779
  13. 21 May, 2013 3 commits
    • Rolf Eike Beer's avatar
      fix warnings about sizeof() return value truncation · 039d9598
      Rolf Eike Beer authored
      Change-Id: Ib8b8b5d406e5123ac9c280bb5d2948916f5a997b
      039d9598
    • Rolf Eike Beer's avatar
      SystemInformation: fix truncation warnings · 87abd647
      Rolf Eike Beer authored
      .../kwsys/SystemInformation.cxx: In member function ‘int cmsys::SystemInformationImplementation::GetFullyQualifiedDomainName(std::string&)’:
      .../kwsys/SystemInformation.cxx:1475:31: warning: conversion to ‘int’ from ‘long unsigned int’ may alter its value [-Wconversion]
               = (fam==AF_INET?sizeof(struct sockaddr_in):sizeof(struct sockaddr_in6));
                                     ^
      .../kwsys/SystemInformation.cxx:1475:58: warning: conversion to ‘int’ from ‘long unsigned int’ may alter its value [-Wconversion]
               = (fam==AF_INET?sizeof(struct sockaddr_in):sizeof(struct sockaddr_in6));
      
      POSIX says the type of the second argument to getnameinfo() should be
      socklen_t so use that as the variable type here. Chances are high that this
      has the same size as size_t so the warning would go away.
      
      Change-Id: Ie2816b401a8fe7d615fa17a58b611e2cad14e4ea
      87abd647
    • Rolf Eike Beer's avatar
      Tests: fix a warning with acc · e8269442
      Rolf Eike Beer authored
      This should fix this compiler warning observed with aCC:
      
      Warning 863: ".../kwsys/testSystemInformation.cxx", line 93 # Result of operator << is widened from int to long.
              if (info.DoesCPUSupportFeature(1 << i))
      
      Change-Id: Ie33521c354b11e3e852c801537c0c82f82c7041c
      e8269442
  14. 06 May, 2013 1 commit
  15. 25 Apr, 2013 1 commit
  16. 21 Mar, 2013 1 commit
  17. 15 Mar, 2013 1 commit
    • Sean McBride's avatar
      SystemInformation: Replace __GNUG__ with __GNUC__ · 13f5badd
      Sean McBride authored
      Commit 857bda17 (SystemInformation: Report more information, 2012-05-29)
      added use of __GNUG__ which is equivalent to __GNUC__ && __cplusplus.
      Since this is a C++ source file and we use __GNUC__ elsewhere it is more
      consistent and less redundant to use the latter.
      
      Change-Id: I6428e2601310dd35c14ac643dcec199b01977842
      13f5badd
  18. 05 Feb, 2013 1 commit
    • Brad King's avatar
      SystemTools: Do not abort with no current directory · 5c34ed2e
      Brad King authored
      Remove the abort() from the internal Getcwd implementation.  All callers
      check the return value already.  Fix one caller's "else" behavior to
      avoid crashing.
      
      Change-Id: I3450c4942ffa108b2313877c9472820f6b465baa
      5c34ed2e
  19. 31 Jan, 2013 2 commits
  20. 25 Jan, 2013 2 commits
  21. 14 Jan, 2013 3 commits
  22. 12 Jan, 2013 2 commits
  23. 11 Jan, 2013 4 commits
    • Rolf Eike Beer's avatar
      SystemInformation: query memory size with sysconf() on Solaris · 342c0ad2
      Rolf Eike Beer authored
      The manpage suggests this is available since Solaris 2.3, which is from
      1993. No need to spawn a process then for this information. As an extra
      bonus we get information about the available physical memory for free,
      which was missing before. On 32 bit processes we will still fall back
      to the old method as the values returned by a 32 bit process on a 64
      bit host are limited to 4 GiB.
      
      Rename QuerySolarisInfo() to QuerySolarisProcessor() as that is now what
      this function is about.
      
      Change-Id: I76fe77a7d746d92d1752119f2c2703652c575339
      342c0ad2
    • Rolf Eike Beer's avatar
      SystemInformation: make IsHyperThreadingSupported() return bool · 5a27bd4f
      Rolf Eike Beer authored
      Change-Id: Ic964ad79ab256e0ce693764065e92528a255fddc
      5a27bd4f
    • Rolf Eike Beer's avatar
      SystemInformation: fix "Multi-character character constant" · c6057a06
      Rolf Eike Beer authored
      Borland compiler correctly complains about this:
      
      Warning W8098 SystemInformation.cxx 3773:
         Multi-character character constant in function
         SystemInformationImplementation::IsHyperThreadingSupported()
      Warning W8098 SystemInformation.cxx 3775:
         Multi-character character constant in function
         SystemInformationImplementation::IsHyperThreadingSupported()
      Warning W8098 SystemInformation.cxx 3777:
         Multi-character character constant in function
         SystemInformationImplementation::IsHyperThreadingSupported()
      
      Change-Id: Id5b5411ed0d04d985dfc8235a6c8c817a4e12ccf
      c6057a06
    • Brad King's avatar
      Process: Avoid argv[0]==NULL from parsing empty command line · 84827cc1
      Brad King authored
      Change-Id: I55506c112cfffdb8d56a85bae0eeaae91d4035bf
      84827cc1
  24. 10 Jan, 2013 2 commits
  25. 09 Jan, 2013 1 commit