From 815cc59348a42067c26811f566246c81ed726df9 Mon Sep 17 00:00:00 2001
From: Sebastian Holtermann <sebholt@xwmw.org>
Date: Sun, 14 Apr 2019 17:54:55 +0200
Subject: [PATCH] SystemTools: Optimize range loop in FindProgramPath method

---
 SystemTools.cxx | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/SystemTools.cxx b/SystemTools.cxx
index 45e3ed9..b328568 100644
--- a/SystemTools.cxx
+++ b/SystemTools.cxx
@@ -3302,9 +3302,8 @@ bool SystemTools::FindProgramPath(const char* argv0, std::string& pathOut,
       msg << "  argv[0] = \"" << argv0 << "\"\n";
     }
     msg << "  Attempted paths:\n";
-    std::vector<std::string>::iterator i;
-    for (i = failures.begin(); i != failures.end(); ++i) {
-      msg << "    \"" << *i << "\"\n";
+    for (std::string const& ff : failures) {
+      msg << "    \"" << ff << "\"\n";
     }
     errorMsg = msg.str();
     return false;
-- 
GitLab