Skip to content
GitLab
Menu
Projects
Groups
Snippets
/
Help
Help
Support
Community forum
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
Menu
Open sidebar
Matthew Letter
VTK-m
Commits
3b847f9a
Commit
3b847f9a
authored
Oct 17, 2018
by
Kenneth Moreland
Browse files
Add change log for removal of TryExecute from filters
parent
bae6e5f4
Changes
1
Hide whitespace changes
Inline
Side-by-side
docs/changelog/filter-no-try-execute.md
0 → 100644
View file @
3b847f9a
# Remove TryExecute from filter
[
A recent change to dispatchers
](
dispatcher-auto-device.md
)
has embedded a
`TryExecute`
internally within the
`Invoke`
function of all dispatchers. This
means that it is no longer necessary to specify a device when invoking a
worklet.
Previously, this
`TryExecute`
was in the filter layer. The filter superclasses
would do a
`TryExecute`
and use that to pass to subclasses in methods like
`DoExecute`
and
`DoMapField`
. Since the dispatcher no longer needs a device
this
`TryExecute`
is generally unnecessary and always redundant. Thus, it has
been removed.
Because of this, the device argument to
`DoExecute`
and
`DoMapField`
has been
removed. This will cause current implementations of filter to change, but it
usually simplifies code. That said, there might be some code that needs to be
wrapped into a
`vtkm::cont::ExecObjectBase`
.
No changes need to be made to code that uses filters.
Write
Preview
Supports
Markdown
0%
Try again
or
attach a new file
.
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment