1. 13 Dec, 2017 3 commits
  2. 01 Dec, 2017 1 commit
  3. 22 Nov, 2017 2 commits
    • Philippe P. Pébaÿ's avatar
      Modified non-regression test for interface reconstruction. · 62cf7516
      Philippe P. Pébaÿ authored
      This version of the test better corresponds to the intent of
      material interface reconstruction, in that a material mask is
      now explicitly specified. Non-regression image updated accordingly.
      62cf7516
    • Philippe P. Pébaÿ's avatar
      Fixed issues with the computation of material interfaces in HTG · a4cc7836
      Philippe P. Pébaÿ authored
      This commit addresses to main issues:
      1. The AxisReflection was /adding/ modified arrays, as opposed to
         modifying in situ the interface arrays (vectors and intercepts).
         This had initially made on purpose with the intent of temporary
         retaining the original arrays for debugging purposes. However,
         this had been forgotten and left in place. As a result, interface
         computations after a reflection where incorrect. This bug was
         not revealing itself in the test harness so far as this combination
         (reflection + interface computations) was not exercised.
         As a result, this commit addresses the issue but also verifies
         this combination. Furthermore, the HTG source was modified in
         order to allow for the specification of intercepts arrays in
         the form that exercise this configuration.
      2. The Geometry extraction was not building material interfaces, as
         a result of some code having been leftover during the HTG-v2
         merger in VTK 8. This commit fixes this issue, and also adds
         a unit test to verify material extraction together with its
         corresponding non-regression image.
      a4cc7836
  4. 06 Nov, 2017 1 commit
  5. 02 Nov, 2017 1 commit
  6. 01 Nov, 2017 1 commit
  7. 31 Oct, 2017 3 commits
  8. 29 Oct, 2017 3 commits
    • Philippe P. Pébaÿ's avatar
      Fixed a bug · e93c5500
      Philippe P. Pébaÿ authored
      e93c5500
    • Philippe P. Pébaÿ's avatar
      Rewrite HTG cell centers filter as a HTG algorithm sub-class · e26f1910
      Philippe P. Pébaÿ authored
      The motivation for this refactoring was quite simple: amongst
      all ancient (but renovated) and new hypetree grid filters, which
      were part of the recently merged "HyperTreeGrid Version 2" branch,
      the HTG CellCenters filter stood out as the only one which was
      not deriving from vtkHyperTreeGridAlgorithm, which had also been
      reworked entirely for this new version of HTG support.
      
      This was because vtkHyperTreeGridCellCenters was, initially,
      deriving from the vtkCellCenters class in Filters/General.
      As VTK does not support multiple inheritance, it was left that
      way but that was not consistent with our overall approach of
      making all HTG algorithms derive from a single base class, in
      the double goal of facilitating both the writing of new HTG
      filters and their maintenance in the long run.
      
      The current commit thus provides a re-writing of the HTG cell
      center creating algorithm as subclass of vtkHyperTreeGridAlgorithm
      while preserving the outside appearance of a vtkCellCenter-derived
      filter in its API, specifically by introducing a VertexCells
      instance variable in order to mimic that which is provided
      in vtkCellCenters.
      
      Note that no new unit tests are provided as part of this commit,
      for the 4 existing ones for the previous incarnation of the HTG
      cell center filter are still passing with unchanged results (as
      they should indeed).
      e26f1910
    • Philippe P. Pébaÿ's avatar
      Fixed a bug in the Moore supercursor · baef249b
      Philippe P. Pébaÿ authored
      The goal of this commit was to fix a bug that occurred only in
      the (f=2;d=3) case ("binary 3D"), and that had been caused
      by a typo in the MooreChildCursorToChildTable and
       MooreChildCursorToParentCursorTable tables: specifically,
      a "23" had been written instread of "32".
      
      In addition, two non-regression tests, as well as their baseline
      images, were added in order to validate this fix:
      (i) a geometry case which does not exercise the offending part of
      the code but that illustrates the case built to do it; and
      (ii) a contouring case that does exercise that part of the code,
      for it relies on the "32" section of the Moore supercursor tables.
      baef249b
  9. 25 Oct, 2017 2 commits
    • Cory Quammen's avatar
      Remove error message in vtkPKdTree::VolumeBounds() · 2645784e
      Cory Quammen authored
      The code executes fine when this condition is encountered, so the
      error message has been converted to a code comment instead.
      2645784e
    • Cory Quammen's avatar
      Ensure that all processes in subgroup invoke collectives · 68921645
      Cory Quammen authored
      In a distributed dataset where some processes have datasets with no
      points or cells, not all processes would invoke the same collective
      communication operations in
      vtkPKdTree::CreateGlobalDataArrayBounds(). This would lead to a
      deadlock in pvserver where processes waited for messages that never
      came.
      
      This is solved by distributing the maximum number of cell and point
      data arrays to all processes so that they all participate in the
      collective operations.
      68921645
  10. 24 Oct, 2017 2 commits
  11. 20 Oct, 2017 1 commit
  12. 17 Oct, 2017 1 commit
  13. 16 Oct, 2017 4 commits
    • Cory Quammen's avatar
      Update TestConnectivityFilter · 6b106fb0
      Cory Quammen authored
      Change variable type too accommodate changes in GetOutput()'s return
      type.
      6b106fb0
    • Cory Quammen's avatar
      Change superclass of vtkConnectivityFilter · 2958a034
      Cory Quammen authored
      Because vtkConnectivityFilter may produce a vtkPolyData as output,
      change the base class from vtkUnstructuredGridAlgorithm to
      vtkPointSetAlgorithm. This provides convenience methods for accessing
      the output as different types, e.g., GetUnstructuredGridOutput() and
      GetPolyDataOutput().
      
      This will break backwards compatibility where callers to
      vtkConnectivityFilter::GetOutput() assign the value returned to a
      vtkUnstructuredGrid pointer or invoke uninherited API in
      vtkUnstruturedGrid from a temporary returned by GetOutput(). Changing
      the call from GetOutput() to GetUnstructuredGridOutput() is that path
      forward in such cases. Note that GetUnstructuredGridOutput() will
      return nullptr if the input to vtkConnectivityFilter is a vtkPolyData
      (its output will be a vtkPolyData).
      2958a034
    • Cory Quammen's avatar
      Updated vtkConnectivityFilter documentation · f2b71559
      Cory Quammen authored
      f2b71559
    • Cory Quammen's avatar
      Produce different output types for connectivity filter · 0d79bd2a
      Cory Quammen authored
      This changes the vtkConnectivityFilter so that it produces a
      vtkPolyData when the input is a vtkPolyData and a vtkUnstructuredGrid
      when the input is anything else. It used to produce only
      vtkUnstructuredGrid outputs.
      0d79bd2a
  14. 15 Oct, 2017 1 commit
    • Sean McBride's avatar
      Fixed numerous warnings from the new cppcheck 1.81 · 442381f5
      Sean McBride authored
      Specifically:
      
      very strange braces!
      syntaxError,Common/DataModel/vtkHyperTreeGrid.cxx:699,error,syntax error
      
      changed size()>0 to !empty()
      stlSize,Filters/General/vtkLoopBooleanPolyDataFilter.cxx:1426,performance,Possible inefficient checking for 'nocellregion' emptiness.
      
      This useless flag has been there since code was added in 2000 in f50b0909
      knownConditionTrueFalse,Common/DataModel/vtkPointLocator.cxx:323,style,Condition 'flag' is always true
      knownConditionTrueFalse,Common/DataModel/vtkPointLocator.cxx:415,style,Condition 'flag' is always true
      knownConditionTrueFalse,Common/DataModel/vtkStaticPointLocator.cxx:788,style,Condition 'flag' is always true
      knownConditionTrueFalse,Common/DataModel/vtkStaticPointLocator.cxx:879,style,Condition 'flag' is always true
      
      This useless 'result' has been there since code was added in 2003 in dd39b9e4
      knownConditionTrueFalse,IO/XML/vtkXMLRectilinearGridReader.cxx:236,style,Condition 'result' is always true
      knownConditionTrueFalse,IO/XML/vtkXMLRectilinearGridReader.cxx:245,style,Condition 'result' is always true
      knownConditionTrueFalse,IO/XML/vtkXMLRectilinearGridReader.cxx:254,style,Condition 'result' is always true
      
      New check in cppcheck 1.81, block is indeed dead code:
      oppositeInnerCondition,Rendering/OpenGL/vtkXOpenGLRenderWindow.cxx:272,warning,Opposite inner 'if' condition leads to a dead code block.
      oppositeInnerCondition,Rendering/OpenGL/vtkXOpenGLRenderWindow.cxx:293,warning,Opposite inner 'if' condition leads to a dead code block.
      oppositeInnerCondition,Rendering/OpenGL/vtkXOpenGLRenderWindow.cxx:349,warning,Opposite inner 'if' condition leads to a dead code block.
      
      false positive, suppressed with zero initialization:
      uninitvar,Filters/Statistics/vtkKMeansStatistics.cxx:810,error,Uninitialized variable: curDistance
      uninitvar,Filters/Statistics/vtkKMeansStatistics.cxx:812,error,Uninitialized variable: curDistance
      
      free(NULL) is allowed, so just remove null check
      knownConditionTrueFalse,IO/Geometry/Testing/Cxx/TestIncrementalOctreePointLocator.cxx:920,style,Condition 'truthIds' is always false
      knownConditionTrueFalse,IO/Geometry/Testing/Cxx/TestIncrementalOctreePointLocator.cxx:956,style,Condition 'diskFile' is always false
      
      Simplified the calculation, verified same codegen on x86_64 with godbolt
      shiftTooManyBitsSigned,Rendering/Volume/vtkHAVSVolumeMapper.cxx:53,error,Shifting signed 32-bit value by 31 bits is undefined behaviour
      
      These have all been thus since their inception, but a global search find the same pattern in TestDijkstraGraphGeodesicPath.cxx, from which I copied the apparent solution
      knownConditionTrueFalse,Interaction/Widgets/Testing/Cxx/TestPolygonalRepresentationHandleWidget.cxx:119,style,Condition 'distanceOffsetSpecified' is always false
      knownConditionTrueFalse,Interaction/Widgets/Testing/Cxx/TestPolygonalRepresentationHandleWidget.cxx:199,style,Condition 'distanceOffsetSpecified' is always false
      knownConditionTrueFalse,Interaction/Widgets/Testing/Cxx/TestPolygonalSurfaceConstrainedDistanceWidget.cxx:244,style,Condition 'distanceOffsetSpecified' is always false
      knownConditionTrueFalse,Interaction/Widgets/Testing/Cxx/TestPolygonalSurfaceConstrainedDistanceWidget.cxx:325,style,Condition 'distanceOffsetSpecified' is always false
      knownConditionTrueFalse,Interaction/Widgets/Testing/Cxx/TestSurfaceConstrainedHandleWidget.cxx:117,style,Condition 'distanceOffsetSpecified' is always false
      knownConditionTrueFalse,Interaction/Widgets/Testing/Cxx/TestSurfaceConstrainedHandleWidget.cxx:189,style,Condition 'distanceOffsetSpecified' is always false
      
      Toggle with #if instead
      knownConditionTrueFalse,Imaging/Hybrid/vtkSurfaceReconstructionFilter.cxx:300,style,Condition 'orientationPropagation' is always true
      
      Added parens
      clarifyCalculation,Common/DataModel/vtkLagrangeWedge.cxx:906,style,Clarify calculation precedence for '/' and '?'.
      442381f5
  15. 14 Oct, 2017 1 commit
    • David Thompson's avatar
      Fix some dashboard issues. · 1b0571a5
      David Thompson authored
      + Skip tests where the render window is generating images the wrong size.
      + Use stupid parentheses to make cppcheck happy.
      1b0571a5
  16. 13 Oct, 2017 2 commits
  17. 12 Oct, 2017 1 commit
    • David Gobbi's avatar
      Fix tabs and utf-8 quotes in source code · d636213c
      David Gobbi authored
      Some VTK source code still had tabs (even some of the .py files!).
      Also, several comments used utf-8 quotes, which are hard to tell
      from regular quotes by eye and can lead to confusing mistakes.
      d636213c
  18. 11 Oct, 2017 3 commits
  19. 09 Oct, 2017 3 commits
  20. 06 Oct, 2017 1 commit
  21. 05 Oct, 2017 1 commit
  22. 04 Oct, 2017 2 commits
    • Ken Martin's avatar
      manually convert more NULL to nullptr · de3c93a3
      Ken Martin authored
      This topic catches another batch of NULL conversions that
      clang did not handle for various reasons. It also includes
      a number of changes to comments and strings where NULL was
      used. It also catches some recent code changes where NULL
      was used instead of nullptr.
      de3c93a3
    • Kitware Robot's avatar
      Replace VTK_DELETE_FUNCTION with =delete. · 1ac2c008
      Kitware Robot authored
      Now that VTK requires a C++11 compiler we can ditch using custom typedefs to
      wrap =delete;
      1ac2c008