1. 18 Jul, 2017 1 commit
    • Utkarsh Ayachit's avatar
      Cleanup offscreen rendering support in VTK. · d0e7aab3
      Utkarsh Ayachit authored
      This commit cleans up offscreen rendering support in VTK. This includes
      several changes.
      1. It makes EGL support independent of onscreen GL
         support. It's now possible to enable EGL and GLX in same build of
         VTK, for example, so long as the two use shared GL-dispatch
         mechanism.  Previously, EGL could not be enabled together with GLX
         (i.e.  `VTK_USE_X` set to ON). These changes allow for that
      2. `VTK_USE_OFFSCREEN_EGL` is replaced by `VTK_OPENGL_HAS_EGL`.
          This is consistent with `VTK_OPENGL_HAS_OSMESA` flag. And also
          in similar vein to changes to `FindOpenGL.cmake` where EGL
          becomes a component of `find_package(OpenGL)`.
      3. `VTK_EGL_DEVICE_INDEX` has been replaced by
         `VTK_DEFAULT_EGL_DEVICE_INDEX` since it only affect the default
         value, and doesn't preclude users from manually specifying the
         device index.
      4. `VTK_USE_OFFSCREEN` has been replaced by
         `VTK_DEFAULT_RENDER_WINDOW_OFFSCREEN`, since similar to `3`
         this option was only intended to affect the default value.
      5. Simplified `FindEGL.cmake`. Apps don't need to link against
         `gldispatch` library and hence removed it and created an
         imported target to simplify use.
      6. For all changes to CMake variables, we put out `DEPRECATION`
         messages if old variables are used.
      7. When `VTK_USE_X` and `VTK_OPENGL_HAS_EGL` or
         `VTK_OPENGL_HAS_OSMESA` in ON, following things happen:
         i.   The object-factory simply returns the X-based (or
              onscreen) render window i.e. `vtkXOpenGLRenderWindow`.
         ii.  To create one of the offscreen render windows, one can
              manually instantiate them e.g. by explicitly
              instantiating `vtkEGLRenderWindow`.
              `vtkXOpenGLRenderWindow` has implementation to swap to
              OSMesa if `SetUseOffscreen(true)` is called.
         iii. As soon any off-screen features are enabled, `glew`
              uses the offscreen library APIs to get OpenGL function pointers
              irrespective of how the active context was initialized.
  2. 08 Jul, 2017 1 commit
    • Bill Lorensen's avatar
      COMP: Mac issues with odd-sized baseline images · 36a75873
      Bill Lorensen authored
      NSWindow's behaviour round sizes *up* to even integral sizes.
      This seems to be related to the limitation for Macs with retina
      display - they can only create windows with width and height with even
      number of pixels.
      If you try to create a window with height or width
      with odd number of pixels you end up with height or width with even
      number of pixels.
  3. 23 Jun, 2017 1 commit
  4. 14 Jun, 2017 1 commit
  5. 03 Jun, 2017 1 commit
  6. 22 May, 2017 1 commit
  7. 01 May, 2017 1 commit
  8. 25 Apr, 2017 1 commit
  9. 13 Apr, 2017 1 commit
    • Sean McBride's avatar
      Fixed various warnings from new cppcheck 1.78 · 25058c30
      Sean McBride authored
      Types of warnings:
      - mismatch between parameters names in declaration vs definition
      - make certain parameters references, or const references
      - checking array index after its use
      - prefer preincrement
      - change return type of operator=
      There are some very minor API chages here (const/reference).
  10. 10 Apr, 2017 1 commit
  11. 20 Mar, 2017 1 commit
  12. 14 Mar, 2017 4 commits
  13. 07 Mar, 2017 1 commit
  14. 22 Feb, 2017 1 commit
    • Utkarsh Ayachit's avatar
      Fix translucent QVTKOpenGLWidget. · d916a694
      Utkarsh Ayachit authored
      QVTKOpenGLWidget would render see-through, when using Mesa
      (paraview/paraview#17159). The symptom was seen on OsX when
      the default format requests alpha buffers (which is now the default
      for standard Render Window). While this may be exposing some odd
      side effect in Qt 5, explicitly making the renderer use alpha=1.0
      when filling the background overcomes this issue.
      Anyways, there was no API to vtkViewport to explicitly set the
      background alpha, only background color (RGB) was exposed. Exposed that
      (with default unchanged). QVTKOpenGLWidget uses the new API to tell
      all non-transparent renderer to render with alpha=1.0.
  15. 09 Feb, 2017 1 commit
  16. 22 Jan, 2017 1 commit
    • Sean McBride's avatar
      const improvements to APIs and internal usage · 8b32854b
      Sean McBride authored
      - Made a few APIs' params const
      - Changed many usages of the evil GetBounds() to expect a const
        return value, even though it does not (yet?) return const
      - Slightly changed return values of vtkTextActor3D::GetBounds()
        to return its own ivar instead of its ImageActor's
  17. 16 Jan, 2017 3 commits
  18. 10 Jan, 2017 1 commit
    • Sean McBride's avatar
      Fixed many trivial cppcheck 1.77 warnings · ea372f58
      Sean McBride authored
      These are all new warnings vs the previous version, 1.76.1
      No real bugs found/fixed here.
      Most are either overwriting a never-read variable value,
      usually only at intialiazation, or a useless comparison.
      In a couple of places, threw in a const or did other minor reworking.
  19. 09 Jan, 2017 1 commit
    • Sean McBride's avatar
      Removed some ancient sparc-only workarounds · 05d5600b
      Sean McBride authored
      Did so to fix cppcheck 1.77 warnings within the code:
      redundantAssignment  Rendering/OpenGL/vtkOpenGLRenderWindow.cxx:585  Variable 'p_data' is reassigned a value before the old one has been used.
      redundantAssignment  Rendering/OpenGL/vtkOpenGLRenderWindow.cxx:732  Variable 'p_data' is reassigned a value before the old one has been used.
  20. 06 Jan, 2017 2 commits
  21. 05 Jan, 2017 1 commit
    • David Gobbi's avatar
      Prefer GetIncrements(incs) over getting a pointer · 0f2b56e4
      David Gobbi authored
      The GetIncrements() method calls ComputeIncrements(), and if you do not
      supply your own array, then the vtkImageData::Increments ivar is modified
      and returned.  This means that the signature of ComputeIncrements() that
      returns a pointer is not thread safe.
  22. 18 Nov, 2016 1 commit
  23. 25 Oct, 2016 1 commit
  24. 28 Sep, 2016 1 commit
  25. 26 Sep, 2016 2 commits
  26. 23 Sep, 2016 2 commits
    • Kitware Robot's avatar
      Reindent using the reindentation script. · f830ff47
      Kitware Robot authored
      This commit reindents the code with the following utility:
      This utility changes the positions of the braces so that they are no
      longer indented relative to the code block they reside in.
      The bash command line used was the following:
      for d in Charts Common Deprecated Domains Examples Filters GUISupport \
               Geovis IO Imaging Infovis Interaction Parallel Rendering \
               Testing Views Web Wrapping; do
        for e in cxx cxx.in txx txx.in hxx hxx.in h h.in c c.in; do
          find "${d}" -name "*.${e}" -exec \
            python Utilities/Maintenance/vtk_reindent_code.py {} +
    • David DeMarle's avatar
      replace VTK's nonstandard Doxygen with standard markup · 6a7e5148
      David DeMarle authored
      generated via:
      cd $VTKSRC
      perl Utilities/Doxygen/doc_header2doxygen.pl --to ~/tmp/vtkheaders .
      cp -r ~/tmp/vtkheaders/* .
  27. 20 Sep, 2016 1 commit
  28. 17 Sep, 2016 1 commit
    • David Gobbi's avatar
      Export the vtkCocoaGLView interface · 583d3dc3
      David Gobbi authored
      This interface can be used from other projects, as demonstrated
      in Examples/GUI/Cocoa/SimpleCocoaVTK, so it should be exported
      so that it can be used with shared linkage.
  29. 12 Sep, 2016 1 commit
    • Haocheng LIU's avatar
      Rewrite all public&private dependency in module.cmake file · 6e113ad4
      Haocheng LIU authored
      The current dependency relationship in vtk is unclear and misleading.
      This MR tries to rewrite them based on header files inclusion of headers
      and source files in each module. Corner cases are considered and
      modules are sorted in alphabetical order to facilitate future reference.
      See details in my gitlab python based script project. In future we can continue
      using this script to clean the VTK Dependency easily from
      time to time.
  30. 29 Aug, 2016 1 commit
  31. 22 Aug, 2016 1 commit
  32. 19 Aug, 2016 1 commit
    • Bill Lorensen's avatar
      ENH: Introduce vtkMTimeType · 9333d9d1
      Bill Lorensen authored
      This is a fix for:
      Windows applications that run for a long time report that rendered
      objects do not change. This is because the modified time on a Windows
      system is 32 bits. This causes overflows that defeat the modified time
      mechanism. This patch defines a new type, vtkMTimeType that is 64
      unsigned integer regardless of the architecture.
      A mechanism to provide backward compatibility is introduced. The
      preprocessor define "VTK_HAS_MTIME_TYPE" can be used in applications
      that must build against VTK versions that use the "unsigned long" type
      for MTime's.
      Methodology used to find MTime occurences:
      1) Identify files as follows:
         git grep "unsigned long" | grep ime | cut -d":" -f1,1 | sort | uniq
      2) Hand edit each of those files replacing "unsigned long" with
         "vtkMTimeType" where appropriate.
      3) Temporarily change typedef for vtkMTimeType to "double" to detect
         missing conversions