GitLab

found via `codespell` 

Cleanup imports and usages of the same in LagrangeGeometricOperations

Building on 8de09365 to not warn for 0 cells. 0 cells is not a warnable
offense.

Also updated UnitTestDataSetSurfaceFilter test.

Typos fixes for documentation and source code comments. This commit is a follow up to:   vtk/vtk!3424

+ Skip tests where the render window is generating images the wrong size.
+ Use stupid parentheses to make cppcheck happy.

... so try adding them explicitly.

Adding in functionality to allow inserting vtkNew objects into
stl containers of vtkSmartPointer objects as well as comparisons
between vtkNew objects and raw pointers. Also removing Get() and
GetPointer() calls from vtkNew objects since in most instances we
can just pass in the vtkNew<> object instead of having to use the
Get() or GetPointer() methods to get the raw pointer.

T.J. Corona authored May 19, 2016 and David Thompson committed Sep 21, 2017

This commit adds support for Lagrange cells of the following shape:
curve, triangle, quadrilateral, tetrahedron, hexahedron, and wedge.
The new cell types may have arbitrary order, up to a compile-time maximum of 10.
The maximum may be changed easily.
The order is inferred from the number of points defining the cell
and is assumed to be the same along each coordinate axis.

Visualization operations that cells must provide (contouring, clipping, cutting)
are implemented by approximating each higher-order cell as a collection of
multi-linear "primitive" cells of the same shape.

Note that the wedge element, when asked for boundary faces, returns faces
with outward-pointing normals. This is not the same convention as vtkWedge
but is the same as other VTK cell shapes.

See the vtkCellTypeSource class in vtkFiltersSources for an example of how
cell connectivity is specified. In general, the shape corner points are
specified first, matching the linear cell counterparts. Then points on
edges and faces bounding the shape are listed. Finally, interior points
are listed. This will allow simpler connectivity entries in the future
where points on edges and faces may only require 2 numbers each instead
of a number proportional to the order raised to the parametric dimension
of the boundary.

T. J. Corona provided the triangle and tetrahedron implementations.

Joachim Pouderoux authored Aug 16, 2017 and Mathieu Westphal committed Aug 24, 2017

For such grids, no output was generated. We now use the specialized
surface filters to extract lines.
We add a new Filters/Geometry/Cxx test for testing the feature.

Kitware Robot authored Jul 26, 2017 and Ken Martin committed Jul 26, 2017

updating the tests to follow modern standards

Kitware Robot authored Jul 26, 2017 and Ken Martin committed Jul 26, 2017

This topic is the result of running clang-tidy to
modernize our usage of NULL and 0 to nullptr. It also
includes some manual and semi manual changes where
clang-tidy would not be expected to work (such as in
comments, or classes not compiled on this build)

There are definitely many comments and occurances that
this topic misses that we will need to fix over time.

This makes VTK build again when VTK_LEGACY_REMOVE is on

Found and auto-fixed by clang-tidy’s performance-unnecessary-value-param check.

The check had other suggestions too, but I limited it to these ones, which are easier to reason about.

This cell type was not supported so far by this filter. This used
to generate an error when applying the Triangulate feature of
ParaView on a dataset or when a dataset contained Polyhedron and
non-linear cells.

vtkDataSetSurfaceFilter delegates some work to
vtkUnstructuredGridGeometryFilter.  This change ensures that duplicate
ghost cells are not removed by the delegate filter.

Added test for this filter with quadratic ghost cells

The default behavior of vtkUnstructuredGridGeometryFilter is to clip
away duplicate ghost cells. In situations where another surface filter
is applied to the output geometry, this may lead to spurious surface
cells being added at the interface between regular cells and the
removed ghost cells.

To fix this, add a flag named DuplicateGhostCellClipping that is on by
default for backwards compatibility.

Added test to exercise this new option.

CHECK_ERROR_MSG and CHECK_WARNING_MSG are used to check the
content of error and warning messages. Error and warning code is often
overlooked during testing. Over the years, these two macros have been
refined to increase their utility. Tests that use the macros defined
their own interpretations. Three different API's have been used in the
macros.

This patch replaces the CHECK_ERROR_MSG and CHECK_WARNING_MSG macros
with methods for vtkTest::ErrorObserver.  All tests that used the
CHECK macros in one form or another have been updated to use the
CheckErrorMessage and CheckWarningMessage methods.

The filter modified the input point data. It used PassData which only
shallow copies the input data arrays. As part of its transformations,
the filter recomputed the point data. Since the data was shallow
copied, the input point data was modified. The defect only showed up
if the input was subsequently rendered.

Kitware Robot authored Sep 23, 2016 and David Gobbi committed Sep 23, 2016

This commit reindents the code with the following utility:
Utilities/Maintenance/vtk-reindent-code.py

This utility changes the positions of the braces so that they are no
longer indented relative to the code block they reside in.

The bash command line used was the following:

for d in Charts Common Deprecated Domains Examples Filters GUISupport \
         Geovis IO Imaging Infovis Interaction Parallel Rendering \
         Testing Views Web Wrapping; do
  for e in cxx cxx.in txx txx.in hxx hxx.in h h.in c c.in; do
    find "${d}" -name "*.${e}" -exec \
      python Utilities/Maintenance/vtk_reindent_code.py {} +
  done
done

Like vtkDataSetSurfaceFilter, vtkDataSetRegionSurfaceFilter is a filter that
extracts the surface from a dataset. Unlike vtkDataSetSurfaceFilter, the
filter accepts integer cell data to denote regions; the regions are then used
as an additional criterion for determining surfaces.

This filter has been ported from ParaView's VTKExtensions.

Only duplicate points were supported. Added support for
hidden points. If a single hidden point is in a surface
cell, we do not show it. On the other hand, all points
need to be duplicate for the cell to be hidden.

Made several params const reference.
Mostly in tests, but a couple are slight API change.

vtkLinearToQuadraticCellsFilter takes an unstructured grid comprised of linear
cells and degree elevates each of the cells to quadratic. Additional points
are simply interpolated from the existing points (there is no snapping to an
external model).

defined copy constr without defined copy op

Other existing, non-unit tests covered 78 percent. This Unit test
alone covers over 90 percent. The remaing uncovered code is for
unusual use cases that are difficult to replicate.

Changes also made to vtkDataSetSurfaceFilter:

COMP: Removed unreachable code. Mainly unreachable Delete's.

COMP: Added missing vtkWarningMacro's

COMP: Added Get() methods to PrintSelf,

COMP: Fixed some spelling errors.

SafeDownCast performs a series of virtual calls and string comparisons,
which is quite slow, especially when used in worker functions.

vtkArrayDownCast will switch between SafeDownCast and the more
efficient FastDownCast (only available for common vtkAbstractArray
subclasses) depending on whether or not FastDownCast is defined for
the specific array type.

Kitware Robot authored Mar 08, 2016 and Dan Lipsa committed Mar 08, 2016

Code extracted from:

    https://gitlab.kitware.com/third-party/proj.git

at commit 41bdf05361007f8c5186f3df9944d86bb273ed13 (for/vtk).

vtkDataArray subclasses now use

ComponentValue --> TypedComponent
TupleValue --> TypedValue

for their type-specific methods.

# Conflicts:
#	Rendering/Annotation/vtkScalarBarActor.cxx

vtkStreamer, vtkStreamLine, vtkStreamPoints, vtkDashedStreamLine
will be deprecated. In preparation, change tests to use vtkStreamTracer.
Also removed some references to these classes in comments.

1) Change unicode string unicode string check in TestTemplates.py.
2) Eliminate some obsolete imports (like "exceptions").
3) Convert string to bytes in TestDataEncoder.py.