GitLab

When handling a 3d volume it was accessing too far when
there was cell data present.

(cherry picked from commit 428d603a)

When handling a 3d volume it was accessing too far when
there was cell data present.

Found via `codespell` and `grep`

154 occurances of ;;\n

This required some clean up, because the automatic changes borked a couple of files, but mostly resulted in stupid whitespacing. A few find/replace fixed things up.

There are now some duplicate semis because it did changes like:

  ~AMRIndexIterator() override{};
to
  ~AMRIndexIterator() override= default;;

Note there was a pointless semi before, which clang-tidy didn’t expect / account for.

My next commit will remove them.

Found via `codespell` and `grep`

I was surprised how many there were.  But no bugs at least, as best as I could tell.

Removed a few useless semi-colons that were nearby.

Found via `codespell -q 3 -I ../vtk-whitelist-words.txt --skip="./ThirdParty,./Utilities"`

found via `codespell` 

includes grammar and uniformity fixes as well.

Found with regexes:

vtkBooleanMacro.*int\)
vtkBooleanMacro.*int \)

Cleanup imports and usages of the same in LagrangeGeometricOperations

Mostly removing superflous double whitespace on both user-facing and non-user-facing strings. Some misc. typo fixes sprinkled in as well.

Now that Tcl wrapping is gone, all wrapping tools now use
`WRAP_EXCLUDE_PYTHON` instead.

Use std::unordered_map & std::unordered_set instead of vtksys::hash_map
and vtksys::hash_set. Since we now use C++11, we can use these new
standard library containers.

For now, vtkTypeBool is just a typedef for int, but one day it can become a real bool.

Found with a regex:

vtkBooleanMacro.*int\)

Now that instantiators are gone, nothing cares about the ABSTRACT
property.

Building on 8de09365 to not warn for 0 cells. 0 cells is not a warnable
offense.

Also updated UnitTestDataSetSurfaceFilter test.

Having 0 cells is not a warning, it happens.

Typos fixes for documentation and source code comments. This commit is a follow up to:   vtk/vtk!3424

+ Skip tests where the render window is generating images the wrong size.
+ Use stupid parentheses to make cppcheck happy.

... so try adding them explicitly.

Now that VTK requires a C++11 compiler we can ditch using custom typedefs to
wrap =delete;

Now that VTK requires a C++11 compiler we can ditch using custom typedefs

Adding in functionality to allow inserting vtkNew objects into
stl containers of vtkSmartPointer objects as well as comparisons
between vtkNew objects and raw pointers. Also removing Get() and
GetPointer() calls from vtkNew objects since in most instances we
can just pass in the vtkNew<> object instead of having to use the
Get() or GetPointer() methods to get the raw pointer.

T.J. Corona authored May 19, 2016 and David Thompson committed Sep 21, 2017

This commit adds support for Lagrange cells of the following shape:
curve, triangle, quadrilateral, tetrahedron, hexahedron, and wedge.
The new cell types may have arbitrary order, up to a compile-time maximum of 10.
The maximum may be changed easily.
The order is inferred from the number of points defining the cell
and is assumed to be the same along each coordinate axis.

Visualization operations that cells must provide (contouring, clipping, cutting)
are implemented by approximating each higher-order cell as a collection of
multi-linear "primitive" cells of the same shape.

Note that the wedge element, when asked for boundary faces, returns faces
with outward-pointing normals. This is not the same convention as vtkWedge
but is the same as other VTK cell shapes.

See the vtkCellTypeSource class in vtkFiltersSources for an example of how
cell connectivity is specified. In general, the shape corner points are
specified first, matching the linear cell counterparts. Then points on
edges and faces bounding the shape are listed. Finally, interior points
are listed. This will allow simpler connectivity entries in the future
where points on edges and faces may only require 2 numbers each instead
of a number proportional to the order raised to the parametric dimension
of the boundary.

T. J. Corona provided the triangle and tetrahedron implementations.

As above for the GeometryFilter previously rectilinear
grids were always producing float which is bad for
large coordinate systems.

Joachim Pouderoux authored Aug 16, 2017 and Mathieu Westphal committed Aug 24, 2017

For such grids, no output was generated. We now use the specialized
surface filters to extract lines.
We add a new Filters/Geometry/Cxx test for testing the feature.

Kitware Robot authored Jul 26, 2017 and Ken Martin committed Jul 26, 2017

updating the tests to follow modern standards