GitLab

Make it more explicit in docs that a few methods in vtkPythonUtil and
vtkPythonAlgorithm return new reference PyObject (similar to how Python
docs document such functions).

the variable name. Shoudl fix dsashboard issues.

(cherry picked from commit 7279cebc)

The old code did not correctly handle DataObjects
that had string arrays in them. It would cause
the index to be off after the string array. So it
might look liek it worked but the data would
be incorrect. Very bad. This fixes PV issue
paraview/paraview#12967

(cherry picked from commit 81f882c4)

When handling a 3d volume it was accessing too far when
there was cell data present.

(cherry picked from commit 428d603a)

Without it, the sanity check for field type fails in
vtkExtractSelection::GetAttributeTypeOfSelection() when block
selections are made.

Also added test for selecting and extracting a block

this is causing warnings on dashboards.

(cherry picked from commit fa9b8ddee39be035a27e47a9211ca4ff7cc278ba)

If t == 1.0, the logic for determining that t is 1.0 was incorrect
when the tolerance is 0.0.

(cherry picked from commit 21cffcb58ec27d0c707d0038ad0d6b9ccef4089a)

Using a faster vtkRandomSequence, plus scaling the cast ray provides
better and faster results when computing whether points are
inside/outside a closed surface.

The new filter replaces it and the old version becomes
vtkExtractSelectionLegacy for now (and is deprecated).  The methods to
set UseProbeForLocations and ShowBounds are stubbed in on the new filter
but have no effect when called and are marked as deprecated.

Utkarsh Ayachit authored Apr 26, 2018 and Shawn Waldon committed May 03, 2018

This includes several improvements to vtkExtractSelection2.

1. Correctly handle composite input in RequesDataObject. Also simplies
   the code to easier to follow.
2. Not create SelectionOperators during iteration over blocks, instead
   create them before the iteration begins. This is essential, otherwise
   all the acceleration structures created in
   vtkSelectionOperator::Initialize need to be recreated per block which
   defeats the objective of that method.
3. Add support to extract blocks by block ids or AMR level/idx.
4. When locating points in a cell, use vtkDataSet::GetCellPoints instead
   of vtkDataSet::GetCell as it is a less expensive call.
5. Make `NewSelectionOperator` virtual so it can be overridden by
   subclasses. Also, gave than method a `New` following VTK style.
6. Update TestExtractionExpression to correct set FieldType on all
   nodes. Not setting FieldType is now correctly dectected as an error.

This option now is counted as a cell-level selection for purposes of
creating the expression.  It is implemented by running a selection on
the points and then generating the selected cells array from the
resulting selected points array.

This consolidates the "operator failed fill array with 0" code into the
extraction filter rather than in every operator.

This generalizes the selection API to accept a vtkDataObject that the
individual selection operator is responsible for downcasting as
necessary.  This avoids reimplementing the same function for points,
cells, etc. for operators where the implementation is the same.