GitLab

It doesn't seem to have got everything, but it's a start.

Some resulting whitespace is suboptimal, but one day
we can fix that with clang-format. :)

Just ran this command:
run-clang-tidy.py -checks=-*,modernize-use-override -fix

(I actually had to build my own clang to make clang-tidy
output "VTK_OVERRIDE" instead of "override".)

Kitware Robot authored Mar 08, 2016 and Dan Lipsa committed Mar 08, 2016

Code extracted from:

    https://gitlab.kitware.com/third-party/proj.git

at commit 41bdf05361007f8c5186f3df9944d86bb273ed13 (for/vtk).

In the early days of VTK, support for stl was not portable. vtksys_stl
and vtksys_ios provided a portable implementation of the stl. Now, all
of the VTK supported compilers have portable stl implementations.

This patch:
  1) Replaces the vtksys_ios:: with std::.
  2) Replaces the vtksys_stl:: with std::.
  3) Removes "using" statements for stl

OpenGL 3.2 does not support line width greater than 1 although
many drivers do support it. This adds valid images for cases
where line width is greater than 1.0

Also minor VisualStudio error check

A few good fixes in here that are all related. The biggest is a
fix to OpenGLActor to use the more comprehensive GetIsOpaque
method in determining if an actor is opaque. The old code only
looked at the property's opacity. This is why you would see folks
setting somethings opacity to 0.99 to get it treated as translucent
because the actor code wasn't handling it correctly. This change
resulted in 3 new valid images for tests that were rendering
translucent items as if they were opaque. I removed these tests
from the old backend as I did not want to change the behavior
for that backend.

Next up is depth peeling. OpenGL2 depth peeling would render
a number of peels up to the limit and then just stop. Any geometry
left between the opaque layer and the last translucent layer was
just thrown out.  This created very noticable artifacts and was bad.
This change makes it so that when it gets to the last pass, it will
render all remaining geometry using alpha blending. This is much
better. Fix example if you get the limit to 20 layers and 20 was
not enough to render all the geometry, this change renders 19
layers using depth peeling, then in the 20th render it would add
in all the remaining geometry as last layer. That last layer may
have overlapping geometry which is rendered using alpha blending.

Finally some changes to the PointGaussianMapper. It turns out that
the point gaussian mapper is an translucent mapper which means it
needs the first change, and it is a very tough case for depth peeling
resulting in the second change. While at it I modified this mapper
to render far fewer fragments, resulting is far fewer overlapping
layers and fewer artifacts. Really when using PointGaussian you
should turn off depthpeeling as it is not needed and actually makes
it worse, but these changes will make it better if you happen to have
it on.  Also cleaned up the mapper so that the radius is equal to
the standard devisation of the gaussian, previously it was four
standard deviations.

Change-Id: I62d90b6e424ac0e939033387ed10ba8caac66095

The Mesa Gallium 'swrast' driver combines pixel-wide overlapping lines
differently, but validly.  Add a baseline representing its result.

Change-Id: I31973e8a6b6776fdb322f6efa8c09b3ac9446525

Change-Id: I10a54acbd076e055d8071414f2fff1ebafe1653d

vtkParallelCoordinatesView was not tested. The lack of a test
resulted in low coverage for vtkParallelCoordinatesView,
vtkParallelCoordinatesRepresentation and SCurveSpline.

This patch also repairs a memory leak in
ParallelCoordinatesRepresentation that was uncovered when the test was
added.

Also, since vtkSCurveSpline is only used in
vtkParallelCoordinatesRepresentation and vtkSCurveSpline did not have a unit
test, this path moves vtkSCurveSpline is moved into Views/Infovis.

NOTE: vtkParallelCoordinatesView has a lot of interactive content. To
improve the coverage, future tests must exercise the interactive parts
of this class. This patch is a minimal effort at improving the
coverage.

Change-Id: I1dfe93ecb1db85edfc5a887c4576c6274e8284ea

The previous commit (9c5d6061) changed the orientation of the
collapsed subtree label in this test.  While the prior orientation
also looked nice, it was a side-effect of the orientation of the
heatmap's column label.  Thus, it was subject to change based on
what order the items in the scene were rendered.  It also did not
look correct for all possible dendrogram orientations.  This new
baseline depicts the label where its orientation is determined
by that of the dendrogram.

Change-Id: Ia6ef68ff573234f1e189a3124bc92295ac85ba6a

vtkDendrogramItem has a new option to draw the number of leaf nodes
hidden by a collapsed subtree's triangle.  This behavior is enabled
by default.

Change-Id: I929ea76a7d2353516f72903266d75ce1acfd0388

As tree edge width is no longer hardcoded, we need to update this
affected test so that its resulting image remains the same.

Change-Id: I28980f6348646d8c7ec6c986eab846b86ac21dcd

* New test in Charts/Core to color the new class vtkCategoryLegend

* New tests to cover the continuous & categorical heatmaps now
  available from vtkHeatmapItem

Change-Id: I06fa49c65e85ad421d5a360920a679379e77be89

Add a test for the new column tree functionality of
vtkTreeHeatmapItem.

This commit also updates the test for vtkTanglegramItem.  The
appearance of this item has changed now that column labels are
included in the values returned by GetBounds().

Change-Id: I36b8383533d9c61db81e47df278d34577d6ddbeb

* Change the format of the correspondence table to be a matrix.
This change allows us to use a vtkLookupTable to assign different
colors to the tangles.  Previously, all tangles were drawn using
a single color.  TestTanglegramItem and its baseline have been
updated to take advantage of this new feature.

* Make the tangles line up evenly on both ends of the tanglegram.
We use a dotted line to connect tangles to their labels.

Change-Id: I01d1bd3fe5d9717fc503ca134a79b603f6771b57

* Rename some tests to more closely reflect the classes that they are
  exercising.

* Update some tests & baselines so that the items are better centered
  & scaled within the render window.

* Add a test for the new vtkTanglegramItem class.

Change-Id: Iea71bc5cc806fead23bba7cc4b9e9d6971309b55

Use the new function vtkAbstractArray::SetMaxDiscreteValues within
vtkTreeHeatmapItem.  This allows us to properly color categorical
datasets that contain more than 32 distinct values.

Within this commit, we also change the color set that we're using for
the categorical color map.  The accent set is pretty, but it only has
8 different values.  Instead we'll use qualitative set3 because it
has 12 values.

Finally, we fix a bug in vtkTreeHeatmapItem so that our NaN color
(grey) is used appropriately by our categorical lookup table.

Change-Id: I53bc9f13240be8c0c10b5dbc77bdcca1ea0fa2a1

Update the baseline images for the tests of vtkTreeHeatmapItem.
This is necessary now that we are using separate color maps for
categorical & continuous data.

Change-Id: I5819db094fe988a579853f62f71b41aa4f66bf01

Add to the Testing/Data directory ExternalData content links mirroring
the content and layout we use from the VTKData/Data directory.

Add a CMake/vtkLegacyData.cmake module, included from CMakeLists.txt and
Testing/External/CMakeLists.txt, to call ExternalData_Expand_Arguments
for all data directories added from VTKData/Data.  This will bulk-fetch
all test input data currently used by tests of any module, enabled or
not.  We can make the DATA{} references more granular later.

Add a VTK_TEST_DATA_DIR variable to refer to the directory we tell the
ExternalData module to populate the real data files.  Replace references
to VTK_DATA_ROOT in test command lines (after -D) with references to
VTK_TEST_DATA_DIR.  Drop the VTK_DATA_ROOT CMake option and stop using
the VTKData repository.

Remove the TESTING_DATA option from the vtk_add_test_cxx API and remove
the VTK_DATA_ROOT option from the vtk_add_test_mpi API since all test
input data are now handled through ExternalData and Testing/Data content
links.

Change-Id: Id02490b76ea2e161b9038188264a4830485039d8

Update the test baseline to match the test update by commit 8ee7cfbf
(Initialize representation's scalar bar actors, 2012-12-06).

Change-Id: Iba7659736e3741f952d0be12fdb320d49f740143

Baseline images are now referenced by ExternalData content links stored
directly in each module source tree.  Drop the old VTKData baseline
subdirectory name from the vtk_add_test_* signatures.

Change-Id: I5bdc7a5bf87fc7c8fa77dcd50b79f2f54d6eba31

Change-Id: I7c6ab523d022f28256bb9d29e23ebacbcf6eafdd

Refactor */*/Testing/Cxx/CMakeLists.txt to use the vtk_add_test_cxx
function instead of direct add_test calls.

Change-Id: I73dee627fa87a399c48b409af046b116fc75a0fd

Neither vertex nor edge scalar bar widgets were using lookup tables
provided by the view theme. Nor were their titles being set.
We also have the representation provide access to the scalar bar
widgets so that their locations can be set programatically.

Change-Id: I1184632cebb7b637344b3ed209f857f615384146

Fixed by adding 'static' and/or 'const' to several
variables that had neither.

Removed one obsolete comment too.

Change-Id: I8775c9a1fa8d9cc75b28619216bbe7f901117a0f

New functionality introduced in this commit allows us to draw each line
in the tree with a color specified by the target vertex.  This is
accomplished by calling the new function SetTreeColorArray().

The parameter of this function specifies the name of a vtkDoubleArray
within the tree's VertexData.  The values of this array are used as the
key of a color lookup table.

Change-Id: I4c6d20f90b5791e2ce0e57ea86ad05f742a13449

The vtkTestingInteractor was trying to run regression tests even if
VTK_DATA_ROOT was not defined.

Many Testing/Cxx CMakeLists.txt files tried to run tests that required
input data, even though VTK_DATA_ROOT was not defined.

Subsequent topics will address Tcl and Python tests.

Change-Id: Iabf242f9f498ce044948ca1d4a29378b76ceb21d

TestRenderView fails on some platforms, reporting:
X Error of failed request:  BadMatch (invalid parameter attributes)
  Major opcode of failed request:  73 (X_GetImage)

This patch changes the test to use the newer testing framework and
seems to fix the problem.

Change-Id: I7e85c2da6235c4bb7787659b8d9bc3681ea4b7a9

This change gets the test passing again on our VS71 nightly builds.

Change-Id: Ie8829cffde66fbb636c30eabc72789420cf4e60b

this causes the test results to match the appearance of
TestTreeHeatmapItem with a collapsed subtree.

Change-Id: I7036b3f1487b85060647e45a4d268d8d0885780b

Make sure the correct source file is referenced in the copyright header.
Remove unnecessary #include directives.

Change-Id: I5d664d44a087cdfa3ee66913ce7f316afc0fa785

This function allows the user to specify how many leaf nodes they would
like to see in the tree.  Subtrees are collapsed in such a way that
the leaf nodes that remain visible are those that are closest to the
root (in terms of depth).

Change-Id: Ie38fb54222ba4b4adb0bf2f16b89554650572df3

1: Improved rendering performance by only drawing data that
is visible on the screen.  This is important for the visualization
of large data.

2: Improved visualization of collapsed subtrees.  We now use color
to indicate how many leaf nodes are hidden within a collapsed subtree.

3.  More changes to collapsible subtrees.  You can no longer collapse
a single leaf node.  This required a slight change to the test to
ensure that the relevant code remains covered.  I also made sure that
the visualization of this item does not change when a subtree is
collapsed & re-expanded.  This requires me to update the baseline
for TestTreeHeatmapItem

Change-Id: Ib750c6056939b61b11e693f910dcbcca91217868

The user can now collapse and expand subtrees in the dendrogram
by double clicking on a vertex.

I updated TestTreeHeatmapItem to cover this new functionality.

This change required me to create a new option for vtkPruneTreeFilter.
You can now tell this filter to prune the children of the specified
vertex, rather than the vertex itself.  I also added a test for
vtkPruneTreeFilter.

Change-Id: Iaeb9f3eed54f59b9df8c00fca9aab7f538e32c4b

when the user mouses over the heatmap, a tooltip will display the value
of the cell underneath the cursor.

this commit also includes some updates to the tests for this class:
* remove unnecessary include file
* add the renderer to the scene

Change-Id: I9cd1d4b0c9f088953d00d909de90760159e0967e

vtkTreeHeatmapItem can now handle the case where only one of
its two inputs are set.

Change-Id: I309c4a1565b12328a2b872d4c7e3c20040f56dd7