GitLab

The current dependency relationship in vtk is unclear and misleading.
This MR tries to rewrite them based on header files inclusion of headers
and source files in each module. Corner cases are considered and
modules are sorted in alphabetical order to facilitate future reference.
See details in my gitlab python based script project. In future we can continue
using this script to clean the VTK Dependency easily from
time to time.

This is a fix for:
#14310

Windows applications that run for a long time report that rendered
objects do not change. This is because the modified time on a Windows
system is 32 bits. This causes overflows that defeat the modified time
mechanism. This patch defines a new type, vtkMTimeType that is 64
unsigned integer regardless of the architecture.

A mechanism to provide backward compatibility is introduced. The
preprocessor define "VTK_HAS_MTIME_TYPE" can be used in applications
that must build against VTK versions that use the "unsigned long" type
for MTime's.

Methodology used to find MTime occurences:
1) Identify files as follows:
   git grep "unsigned long" | grep ime | cut -d":" -f1,1 | sort | uniq
2) Hand edit each of those files replacing "unsigned long" with
   "vtkMTimeType" where appropriate.
3) Temporarily change typedef for vtkMTimeType to "double" to detect
   missing conversions

It doesn't seem to have got everything, but it's a start.

Some resulting whitespace is suboptimal, but one day
we can fix that with clang-format. :)

Just ran this command:
run-clang-tidy.py -checks=-*,modernize-use-override -fix

(I actually had to build my own clang to make clang-tidy
output "VTK_OVERRIDE" instead of "override".)

vtk(.*)\(const vtk\1&\);\s*//\s*Not implemented[\.]*
to
vtk\1(const vtk\1\&) VTK_DELETE_FUNCTION;

vtk(.*)\(const vtk\1 &\);\s*//\s*Not implemented[\.]*
to
vtk\1(const vtk\1 \&) VTK_DELETE_FUNCTION;

vtk(.*)\( const vtk\1 & \);\s*//\s*Not implemented[\.]*
to
vtk\1( const vtk\1 \& ) VTK_DELETE_FUNCTION;

vtk(.*)\( const vtk\1& \);\s*//\s*Not implemented[\.]*
to
vtk\1( const vtk\1\& ) VTK_DELETE_FUNCTION;

vtk(.*) \(const vtk\1&\);\s*//\s*Not implemented[\.]*
to
vtk\1 (const vtk\1\&) VTK_DELETE_FUNCTION;

(operator\s*=.*);\s*//\s*Not\s*implemented[\.]*
to
\1 VTK_DELETE_FUNCTION;

After that, this finds basically nothing:

operator.*implemented

then manually reverted changed files in VPIC and KWSys folders.

Kitware Robot authored May 24, 2016 and David Gobbi committed May 25, 2016

Perl was used to remove all the BTX and ETX markers from the code.
The specific command that was run on all "vtk*.h" files was this:
    perl -0777 -i -pe 's/(\n* *\/\/ *[BE]TX *\n+)+/\n\n/g'

This regex replaces each BTX/ETX line, plus any leading or trailing
blank lines, with a single blank line.

SafeDownCast performs a series of virtual calls and string comparisons,
which is quite slow, especially when used in worker functions.

vtkArrayDownCast will switch between SafeDownCast and the more
efficient FastDownCast (only available for common vtkAbstractArray
subclasses) depending on whether or not FastDownCast is defined for
the specific array type.

Kitware Robot authored Mar 08, 2016 and Dan Lipsa committed Mar 08, 2016

Code extracted from:

    https://gitlab.kitware.com/third-party/proj.git

at commit 41bdf05361007f8c5186f3df9944d86bb273ed13 (for/vtk).

vtkDataArray subclasses now use

ComponentValue --> TypedComponent
TupleValue --> TypedValue

for their type-specific methods.

# Conflicts:
#	Rendering/Annotation/vtkScalarBarActor.cxx

Find/replace of:

with C++ counterparts.  Changed only vtk*.cxx files.
Didn’t touch .h or .c or any 3rd party.

We no longer need this compatibility layer for the compilers we support.
Use the following commands to switch to standard header and namespace:

 git grep -l vtksys/ios/ | xargs sed -i 's|vtksys/ios/||'
 git grep -l vtksys_ios | xargs sed -i 's|vtksys_ios|std|g'

In the early days of VTK, support for stl was not portable. vtksys_stl
and vtksys_ios provided a portable implementation of the stl. Now, all
of the VTK supported compilers have portable stl implementations.

This patch:
  1) Replaces the vtksys_ios:: with std::.
  2) Replaces the vtksys_stl:: with std::.
  3) Removes "using" statements for stl

OpenGL 3.2 does not support line width greater than 1 although
many drivers do support it. This adds valid images for cases
where line width is greater than 1.0

Also minor VisualStudio error check

This is not supported by the new OpenGL2 backend, and doesn't support
new text features, like MathText, FontConfig, or custom font files.

It only implements vtkTextMapper, which now will use a texture-based
implementation, similar to vtkTextActor and friends.

Also removed some dead code as a consequence,
like setting the deallocated pointer to null
then to a new address.

Also removed setting some ivars to null in dtors.

A few good fixes in here that are all related. The biggest is a
fix to OpenGLActor to use the more comprehensive GetIsOpaque
method in determining if an actor is opaque. The old code only
looked at the property's opacity. This is why you would see folks
setting somethings opacity to 0.99 to get it treated as translucent
because the actor code wasn't handling it correctly. This change
resulted in 3 new valid images for tests that were rendering
translucent items as if they were opaque. I removed these tests
from the old backend as I did not want to change the behavior
for that backend.

Next up is depth peeling. OpenGL2 depth peeling would render
a number of peels up to the limit and then just stop. Any geometry
left between the opaque layer and the last translucent layer was
just thrown out.  This created very noticable artifacts and was bad.
This change makes it so that when it gets to the last pass, it will
render all remaining geometry using alpha blending. This is much
better. Fix example if you get the limit to 20 layers and 20 was
not enough to render all the geometry, this change renders 19
layers using depth peeling, then in the 20th render it would add
in all the remaining geometry as last layer. That last layer may
have overlapping geometry which is rendered using alpha blending.

Finally some changes to the PointGaussianMapper. It turns out that
the point gaussian mapper is an translucent mapper which means it
needs the first change, and it is a very tough case for depth peeling
resulting in the second change. While at it I modified this mapper
to render far fewer fragments, resulting is far fewer overlapping
layers and fewer artifacts. Really when using PointGaussian you
should turn off depthpeeling as it is not needed and actually makes
it worse, but these changes will make it better if you happen to have
it on.  Also cleaned up the mapper so that the radius is equal to
the standard devisation of the gaussian, previously it was four
standard deviations.

Change-Id: I62d90b6e424ac0e939033387ed10ba8caac66095

Change-Id: I5adee5e4e29ae03aa4363550a11a044d447ae74b

Used the following command:

find . \( -iname *.h -and -type f \) -exec perl -pi -w -e 's/__vtk(.*)_h/vtk$1_h/g;' {} \;

Fixes many, but not all, clang -Wreserved-id-macro warnings.

Change-Id: I694ff053cb204c70e37b261296f496064d91fc07

Change-Id: I76848acf2f0939f63df6c3194b302eebd6a68009

This change makes more modules dynamically switch between the
rendering backends if they have no OpenGL code, or introduces some
ifdefs in the case of RenderingParallel (which may not be functional
at this stage). Added RenderingFreeTypeOpenGL2 which will also need
some additional work before it is properly integrated with the new
rendering backend, but it surprisingly seems to render on the
desktop.

This commit contains everything needed to get a minimal ParaView
build using the new rendering backend for polygonal rendering.

Change-Id: If8676d41d263b046a54060965fc760b5d4bd64a1

This resolves PGI ~ 600 warnings "#111-D: statement is unreachable"

Change-Id: I9937c4f22eec4e9f56b6b770e35a6a1ca7390974

Lots of places where we pass floating point values as integers; make the
loss of precision more explicit.

Change-Id: Icafde395f0463421b5f36d1e4e855fa25cab5ab4

Storing these as integers truncates the actual value when restoring.

Change-Id: I5fd5eee053db12a1c96c51dd359cd9410d0f68a6

This adds dependencies to tests that were missed in the initial move
for vtkRenderingContext2D.

Change-Id: If816a2a15ca02bca8c5f736872d4166b90f73bcf

The Mesa Gallium 'swrast' driver combines pixel-wide overlapping lines
differently, but validly.  Add a baseline representing its result.

Change-Id: I31973e8a6b6776fdb322f6efa8c09b3ac9446525

Change-Id: I10a54acbd076e055d8071414f2fff1ebafe1653d

Change-Id: Ibd1956b5e76f47e39f08fd787f57e0688312f6fd

As of this commit, we no longer assume that the 1st column of
the input table specifies the names of the table's rows.  Instead,
we search by default for a column named "name".  The user can
change the name of this array by calling vtkHeatmapItem::
SetNameColumn(vtkStdString).  We fallback to using the 1st column
only if no such array can be found by name.

Change-Id: I2494ff21f3efa4a379dce82e159715dc023d8995

Apparently functions whose signatures contain vtkSmartPointer
are not wrapped into python.  Change such methods of
vtkTreeHeatmapItem to contain ordinary pointers instead.

Change-Id: Ic98311c10f1e7a99fb4ad071d3981e4febb0604e

Various places used abs(), which takes int, when dealing with
floating point numbers.  Use fabs instead.

Change-Id: If6f2f3784f199a3a60dcf0d1e8e96bf5ee4deb92

Also made some const correctness improvements,
which cascaded to clients of this class.

Other misc cleanup too.

Change-Id: Ic7688a12949a9b8cc752afb957e13317e50ba085

vtkParallelCoordinatesView was not tested. The lack of a test
resulted in low coverage for vtkParallelCoordinatesView,
vtkParallelCoordinatesRepresentation and SCurveSpline.

This patch also repairs a memory leak in
ParallelCoordinatesRepresentation that was uncovered when the test was
added.

Also, since vtkSCurveSpline is only used in
vtkParallelCoordinatesRepresentation and vtkSCurveSpline did not have a unit
test, this path moves vtkSCurveSpline is moved into Views/Infovis.

NOTE: vtkParallelCoordinatesView has a lot of interactive content. To
improve the coverage, future tests must exercise the interactive parts
of this class. This patch is a minimal effort at improving the
coverage.

Change-Id: I1dfe93ecb1db85edfc5a887c4576c6274e8284ea

vtkDendrogramItem now displays a vtkColorLegend after SetColorArray()
has been called.  This allows the consumers of this visualization to
see the scalar values associated with the colored edges of the tree.

This commit also contains a bug fix.  When SetColorArray() is called
with an array that only contains a single value, the edges of the tree
should be drawn in grey.  This bug previously caused such edges to be
drawn in either red or blue.

Change-Id: Ia897109b119029e57e053b368dc910fb87266a76

The previous commit (9c5d6061) changed the orientation of the
collapsed subtree label in this test.  While the prior orientation
also looked nice, it was a side-effect of the orientation of the
heatmap's column label.  Thus, it was subject to change based on
what order the items in the scene were rendered.  It also did not
look correct for all possible dendrogram orientations.  This new
baseline depicts the label where its orientation is determined
by that of the dendrogram.

Change-Id: Ia6ef68ff573234f1e189a3124bc92295ac85ba6a